Re: [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug

2022-07-27 Thread Sam James


> On 27 Jul 2022, at 08:17, Michał Górny  wrote:
> 
> Signed-off-by: Michał Górny 
> ---
> eclass/virtualx.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 

Please reference the vim bug (guessing it's 
https://github.com/vim/vim/issues/10673)
in the commit message and in the eclass I guess so that we know when it's fixed.

I love my bug links, okay?

> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index b7a25c897b4a..5c4b39164cff 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -53,7 +53,7 @@ case ${VIRTUALX_REQUIRED} in
>   *)
>   BDEPEND="${VIRTUALX_REQUIRED}? ( ${VIRTUALX_DEPEND} )"
>   IUSE="${VIRTUALX_REQUIRED}"
> - [[ ${VIRTUALX_REQUIRED} == test ]] &&
> + [[ ${VIRTUALX_REQUIRED} == "test" ]] &&
>   RESTRICT+=" !test? ( test )"
>   ;;
> esac
> --
> 2.35.1
> 
> 



signature.asc
Description: Message signed with OpenPGP


Re: [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug

2022-07-27 Thread Ulrich Mueller
> On Wed, 27 Jul 2022, Michał Górny wrote:

> - [[ ${VIRTUALX_REQUIRED} == test ]] &&
> + [[ ${VIRTUALX_REQUIRED} == "test" ]] &&

Really? You should rather fix vim, or use Emacs. :)


signature.asc
Description: PGP signature