Re: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8

[Mike Gilbert]

On Thu, Sep 8, 2022 at 1:38 PM Ulrich Mueller  wrote:
>
> > On Thu, 08 Sep 2022, Mike Gilbert wrote:
>
> > @@ -18,7 +18,7 @@ case "${EAPI:-0}" in
> >   0|1|2|3|4|5|6)
> >   die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
> >   ;;
> > - 7)
> > + 7|8)
> >   ;;
> >   *)
> >   die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
>
> While at it, maybe convert the conditional to the standard form in all
> these eclasses? Like this:
>
> case ${EAPI} in
> 7|8) ;;
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> esac
>
> I'd also drop EAPI 5 where it is applicable.

Done. Check the PR for updates.

Re: [gentoo-dev] [PATCH 1/8] dist-kernel-utils.eclass: support EAPI 8

[Ulrich Mueller]

> On Thu, 08 Sep 2022, Mike Gilbert wrote:

> @@ -18,7 +18,7 @@ case "${EAPI:-0}" in
>   0|1|2|3|4|5|6)
>   die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
>   ;;
> - 7)
> + 7|8)
>   ;;
>   *)
>   die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"

While at it, maybe convert the conditional to the standard form in all
these eclasses? Like this:

case ${EAPI} in
7|8) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac

I'd also drop EAPI 5 where it is applicable.


signature.asc
Description: PGP signature