Re: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass
> On Sun, 06 Sep 2020, David Seifert wrote: > On Sun, 2020-09-06 at 21:49 +0200, Ulrich Mueller wrote: >> Maybe just commit the new eclass, update ebuilds, then remove the >> function from eutils? > I'll get a lot of heat for breaking EAPI 2 ebuilds in some random > abandoned overlay because we guarantee eclass API backwards > compatibility for 20 years! optfeature affects only elog output, so there won't be any real breakage. And of course, there should be some grace period (I'd suggest 30 days) between steps 2 and 3. Ulrich signature.asc Description: PGP signature
Re: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass
On Sun, 2020-09-06 at 21:49 +0200, Ulrich Mueller wrote:
> > > > > > On Sun, 06 Sep 2020, David Seifert wrote:
> > @@ -20,7 +20,7 @@ _EUTILS_ECLASS=1
> > # implicitly inherited (now split) eclasses
> > case ${EAPI:-0} in
> > 0|1|2|3|4|5|6)
> > - inherit desktop epatch estack ltprune multilib preserve-libs \
> > + inherit desktop epatch estack ltprune multilib optfeature
> > preserve-libs \
> > toolchain-funcs vcs-clean
> > ;;
> > esac
>
> I count 163 ebuilds calling optfeature in EAPI 7, but only 24 in older
> EAPIs, which makes me wonder if the conditional inherit makes any
> sense.
>
> Maybe just commit the new eclass, update ebuilds, then remove the
> function from eutils?
>
> Ulrich
I'll get a lot of heat for breaking EAPI 2 ebuilds in some random
abandoned overlay because we guarantee eclass API backwards
compatibility for 20 years!
Re: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass
> On Sun, 06 Sep 2020, David Seifert wrote:
> @@ -20,7 +20,7 @@ _EUTILS_ECLASS=1
> # implicitly inherited (now split) eclasses
> case ${EAPI:-0} in
> 0|1|2|3|4|5|6)
> - inherit desktop epatch estack ltprune multilib preserve-libs \
> + inherit desktop epatch estack ltprune multilib optfeature preserve-libs
> \
> toolchain-funcs vcs-clean
> ;;
> esac
I count 163 ebuilds calling optfeature in EAPI 7, but only 24 in older
EAPIs, which makes me wonder if the conditional inherit makes any sense.
Maybe just commit the new eclass, update ebuilds, then remove the
function from eutils?
Ulrich
signature.asc
Description: PGP signature
