Re: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep

2022-05-21 Thread Ulrich Mueller
> On Sat, 21 May 2022, Rolf Eike Beer wrote:

> You can get the patches directly from git here:
> https://github.com/DerDakon/gentoo/tree/qmail-eclass

Thanks, merged.


signature.asc
Description: PGP signature


Re: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep

2022-05-21 Thread Rolf Eike Beer
Am Samstag, 21. Mai 2022, 10:44:35 CEST schrieb Ulrich Mueller:
> > On Mon, 16 May 2022, Rolf Eike Beer wrote:
> > This does not use extended regular expressions in any way. While at it
> > change the way these matches are done: it's irrelevant if the entire
> > expression is in the file, if there is any rule for the given IP address
> > then do not add the new
> > expression.
> 
> Series LGTM. However, "git am" fails for the second patch because the
> line breaks in your message are messed up:
> 
>Applying: qmail.eclass: remove usage of egrep
>error: corrupt patch at line 17
>Patch failed at 0001 qmail.eclass: remove usage of egrep
> 
> (I believe the problem is not on my side, because I see the spurious
> line breaks also in archives:
> https://archives.gentoo.org/gentoo-dev/message/b34c3f96f9e4069516b1457e7b0b4
> 904#L32 )

This is likely a problem of the GPG signing.

You can get the patches directly from git here:

https://github.com/DerDakon/gentoo/tree/qmail-eclass


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] [PATCH 2/2] qmail.eclass: remove usage of egrep

2022-05-21 Thread Ulrich Mueller
> On Mon, 16 May 2022, Rolf Eike Beer wrote:

> This does not use extended regular expressions in any way. While at it change
> the way these matches are done: it's irrelevant if the entire expression is in
> the file, if there is any rule for the given IP address then do not add the 
> new
> expression.

Series LGTM. However, "git am" fails for the second patch because the
line breaks in your message are messed up:

   Applying: qmail.eclass: remove usage of egrep
   error: corrupt patch at line 17
   Patch failed at 0001 qmail.eclass: remove usage of egrep

(I believe the problem is not on my side, because I see the spurious
line breaks also in archives:
https://archives.gentoo.org/gentoo-dev/message/b34c3f96f9e4069516b1457e7b0b4904#L32
 )


signature.asc
Description: PGP signature