Re: [gentoo-dev] [PATCH 7/8] profiles/use.desc: Make USE=egl global
On Tue, 2023-12-19 at 12:50 +0100, Michał Górny wrote: > > > --- a/media-plugins/gst-plugins-gtk/metadata.xml > > > +++ b/media-plugins/gst-plugins-gtk/metadata.xml > > > @@ -6,7 +6,6 @@ > > > GStreamer package maintainers > > > > > > > > > - Enable EGL platform usage > > > Enable gtkglsink OpenGL sink based on > > > GLESv2 API > > > Enable gtkglsink OpenGL sink based on > > > desktop OpenGL API > > > > > > > Please do not lose extra information provided in local descriptions > > in this and many other cases where you remove the local description > > (in other proposed global USE flag cases as well). Just don't > > remove the local description then. Thanks. > > > > I've used my best judgment to figure out whether the local > description actually provides any "extra information". I didn't > touch the gtkglsink-related flags since they provided some > information. I fail to see how "platform usage" adds any information. With the tabs in the raw patch indent rendered as 8 spaces, my eyes shifted (no less than on 3 looking occurrences while also trying to get only this chunk into the reply) and I thought you are removing precisely that gtkglsink comment, sorry! > If you have "other proposed global USE flag cases" that are removing > information, please be more specific. I don't think any of these are very important, but if I were to nitpick: * x11-apps/mesa-progs local gles2 USE desc looked vaguely more useful than the new global; might be even more useful if it named the utilities by name (main one of interest is es2_info). * "asm - Enable using assembly for optimization" reads a bit weird - ultimately C, rust, etc end up using assembly in a way too. I would have went with something more of the "Enable use of hand optimized assembly routines" theme for the global desc. * gnustep-base/gnustep-gui USE=speech seems to have told something completely different than the global USE flag; maybe was looked into and determined it's actually indeed text-to-speech* Some specify what dep is used, but in many cases it's the obvious candidate. Maybe games- engine/scummvm isn't that obvious. But users will see from the deptree. * kde-apps/konqueror and net-misc/eventd specifies USE=speech installs a plugin, which might be useful information IF that's something that might need to be enabled by user on top to load the plugin. Not important. Mart
Re: [gentoo-dev] [PATCH 7/8] profiles/use.desc: Make USE=egl global
On Tue, 2023-12-19 at 10:33 +0200, Mart Raudsepp wrote: > Ühel kenal päeval, P, 17.12.2023 kell 17:05, kirjutas Michał Górny: > > Add a global USE=egl flag. It is used semi-consistently in 13 > > packages, > > though some use it as "EGL only" flag (there is also one using > > USE=egl-only). > > > > Signed-off-by: Michał Górny > > --- > > dev-games/openscenegraph-openmw/metadata.xml | 1 - > > dev-games/openscenegraph/metadata.xml | 1 - > > dev-qt/qtgui/metadata.xml | 1 - > > media-libs/clutter/metadata.xml | 1 - > > media-libs/gst-plugins-bad/metadata.xml | 1 - > > media-libs/gst-plugins-base/metadata.xml | 1 - > > media-libs/libepoxy/metadata.xml | 3 --- > > media-libs/libva-compat/metadata.xml | 1 - > > media-plugins/gst-plugins-gtk/metadata.xml | 1 - > > media-plugins/gst-plugins-vaapi/metadata.xml | 1 - > > profiles/use.desc | 1 + > > 11 files changed, 1 insertion(+), 12 deletions(-) > > > > diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media- > > plugins/gst-plugins-gtk/metadata.xml > > index 7235f1bab7ba..f3b18c11bcfc 100644 > > --- a/media-plugins/gst-plugins-gtk/metadata.xml > > +++ b/media-plugins/gst-plugins-gtk/metadata.xml > > @@ -6,7 +6,6 @@ > > GStreamer package maintainers > > > > > > - Enable EGL platform usage > > Enable gtkglsink OpenGL sink based on > > GLESv2 API > > Enable gtkglsink OpenGL sink based on > > desktop OpenGL API > > > > Please do not lose extra information provided in local descriptions in > this and many other cases where you remove the local description (in > other proposed global USE flag cases as well). Just don't remove the > local description then. Thanks. > I've used my best judgment to figure out whether the local description actually provides any "extra information". I didn't touch the gtkglsink-related flags since they provided some information. I fail to see how "platform usage" adds any information. If you have "other proposed global USE flag cases" that are removing information, please be more specific. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH 7/8] profiles/use.desc: Make USE=egl global
Ühel kenal päeval, P, 17.12.2023 kell 17:05, kirjutas Michał Górny: > Add a global USE=egl flag. It is used semi-consistently in 13 > packages, > though some use it as "EGL only" flag (there is also one using > USE=egl-only). > > Signed-off-by: Michał Górny > --- > dev-games/openscenegraph-openmw/metadata.xml | 1 - > dev-games/openscenegraph/metadata.xml | 1 - > dev-qt/qtgui/metadata.xml | 1 - > media-libs/clutter/metadata.xml | 1 - > media-libs/gst-plugins-bad/metadata.xml | 1 - > media-libs/gst-plugins-base/metadata.xml | 1 - > media-libs/libepoxy/metadata.xml | 3 --- > media-libs/libva-compat/metadata.xml | 1 - > media-plugins/gst-plugins-gtk/metadata.xml | 1 - > media-plugins/gst-plugins-vaapi/metadata.xml | 1 - > profiles/use.desc | 1 + > 11 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media- > plugins/gst-plugins-gtk/metadata.xml > index 7235f1bab7ba..f3b18c11bcfc 100644 > --- a/media-plugins/gst-plugins-gtk/metadata.xml > +++ b/media-plugins/gst-plugins-gtk/metadata.xml > @@ -6,7 +6,6 @@ > GStreamer package maintainers > > > - Enable EGL platform usage > Enable gtkglsink OpenGL sink based on > GLESv2 API > Enable gtkglsink OpenGL sink based on > desktop OpenGL API > Please do not lose extra information provided in local descriptions in this and many other cases where you remove the local description (in other proposed global USE flag cases as well). Just don't remove the local description then. Thanks. Mart
