Re: [gentoo-dev] [PATCH data/xml-schema 1/2] metadata.xsd: Add gnome remote-id
On Tue, Sep 13, 2022 at 12:00 PM Michał Górny wrote: > > On Tue, 2022-09-13 at 10:36 -0400, Matt Turner wrote: > > On Tue, Sep 13, 2022 at 2:38 AM Michał Górny wrote: > > > > > > On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote: > > > > Signed-off-by: Matt Turner > > > > --- > > > > metadata.xsd | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/metadata.xsd b/metadata.xsd > > > > index 87972cb..cced33d 100644 > > > > --- a/metadata.xsd > > > > +++ b/metadata.xsd > > > > @@ -279,6 +279,7 @@ > > > > > > > > > > > > > > > > + > > > > > > > > > > > > > > > > > > Some examples, please. Are these somehow "global" identifiers or > > > specific to their GitLab instances? > > > > This would be for gitlab.gnome.org. E.g. for x11-terms/gnome-terminal > > whose git repo is located at > > https://gitlab.gnome.org/GNOME/gnome-terminal.git, we'd have > > > > GNOME/gnome-terminal > > > > Similar situation for 'freedesktop' in patch 2/2, for > > gitlab.freedesktop.org. > > > > Well, then I guess I'd prefer if these were "gnome-gitlab" > and "freedesktop-gitlab" to make it clear which services the names > correspond to. Sure, will do.
Re: [gentoo-dev] [PATCH data/xml-schema 1/2] metadata.xsd: Add gnome remote-id
On Tue, 2022-09-13 at 10:36 -0400, Matt Turner wrote: > On Tue, Sep 13, 2022 at 2:38 AM Michał Górny wrote: > > > > On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote: > > > Signed-off-by: Matt Turner > > > --- > > > metadata.xsd | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/metadata.xsd b/metadata.xsd > > > index 87972cb..cced33d 100644 > > > --- a/metadata.xsd > > > +++ b/metadata.xsd > > > @@ -279,6 +279,7 @@ > > > > > > > > > > > > + > > > > > > > > > > > > > Some examples, please. Are these somehow "global" identifiers or > > specific to their GitLab instances? > > This would be for gitlab.gnome.org. E.g. for x11-terms/gnome-terminal > whose git repo is located at > https://gitlab.gnome.org/GNOME/gnome-terminal.git, we'd have > > GNOME/gnome-terminal > > Similar situation for 'freedesktop' in patch 2/2, for gitlab.freedesktop.org. > Well, then I guess I'd prefer if these were "gnome-gitlab" and "freedesktop-gitlab" to make it clear which services the names correspond to. -- Best regards, Michał Górny
Re: [gentoo-dev] [PATCH data/xml-schema 1/2] metadata.xsd: Add gnome remote-id
> On 13 Sep 2022, at 15:36, Matt Turner wrote: > > On Tue, Sep 13, 2022 at 2:38 AM Michał Górny wrote: >> >> On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote: >>> Signed-off-by: Matt Turner >>> --- >>> metadata.xsd | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/metadata.xsd b/metadata.xsd >>> index 87972cb..cced33d 100644 >>> --- a/metadata.xsd >>> +++ b/metadata.xsd >>> @@ -279,6 +279,7 @@ >>> >>> >>> >>> + >>> >>> >>> >> >> Some examples, please. Are these somehow "global" identifiers or >> specific to their GitLab instances? > > This would be for gitlab.gnome.org. E.g. for x11-terms/gnome-terminal > whose git repo is located at > https://gitlab.gnome.org/GNOME/gnome-terminal.git, we'd have > > GNOME/gnome-terminal > As long as it's mandatory for GNOME projects to have a corresponding Gitlab (ditto freedesktop), this is fine with me & sounds good. signature.asc Description: Message signed with OpenPGP
Re: [gentoo-dev] [PATCH data/xml-schema 1/2] metadata.xsd: Add gnome remote-id
On Tue, Sep 13, 2022 at 2:38 AM Michał Górny wrote: > > On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote: > > Signed-off-by: Matt Turner > > --- > > metadata.xsd | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/metadata.xsd b/metadata.xsd > > index 87972cb..cced33d 100644 > > --- a/metadata.xsd > > +++ b/metadata.xsd > > @@ -279,6 +279,7 @@ > > > > > > > > + > > > > > > > > Some examples, please. Are these somehow "global" identifiers or > specific to their GitLab instances? This would be for gitlab.gnome.org. E.g. for x11-terms/gnome-terminal whose git repo is located at https://gitlab.gnome.org/GNOME/gnome-terminal.git, we'd have GNOME/gnome-terminal Similar situation for 'freedesktop' in patch 2/2, for gitlab.freedesktop.org.
Re: [gentoo-dev] [PATCH data/xml-schema 1/2] metadata.xsd: Add gnome remote-id
On Mon, 2022-09-12 at 20:58 -0400, Matt Turner wrote: > Signed-off-by: Matt Turner > --- > metadata.xsd | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/metadata.xsd b/metadata.xsd > index 87972cb..cced33d 100644 > --- a/metadata.xsd > +++ b/metadata.xsd > @@ -279,6 +279,7 @@ > > > > + > > > Some examples, please. Are these somehow "global" identifiers or specific to their GitLab instances? -- Best regards, Michał Górny