Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Dan Douglas
On Sunday, January 13, 2013 06:02:26 PM Michał Górny wrote: On Sun, 13 Jan 2013 07:36:59 -0800 Alec Warner anta...@gentoo.org wrote: local -i ret ? Looks good. I didn't even know bash has something like that. Useless use of -i is usually unhelpful. In Bash (but not all shells), it's

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Dan Douglas
On Sunday, January 13, 2013 01:28:42 PM Mike Frysinger wrote: On Sunday 13 January 2013 08:29:43 Michał Górny wrote: + [[ ${BUILD_DIR} ]] || die ${FUNCNAME}: BUILD_DIR not set. really should use -n there Doesn't matter. Only zsh requires it (and pointlessly disagrees with every other

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Alec Warner
On Mon, Jan 14, 2013 at 9:30 AM, Dan Douglas orm...@gmail.com wrote: On Sunday, January 13, 2013 06:02:26 PM Michał Górny wrote: On Sun, 13 Jan 2013 07:36:59 -0800 Alec Warner anta...@gentoo.org wrote: local -i ret ? Looks good. I didn't even know bash has something like that. Useless

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-14 Thread Mike Frysinger
On Monday 14 January 2013 12:55:29 Dan Douglas wrote: On Sunday, January 13, 2013 01:28:42 PM Mike Frysinger wrote: On Sunday 13 January 2013 08:29:43 Michał Górny wrote: + [[ ${BUILD_DIR} ]] || die ${FUNCNAME}: BUILD_DIR not set. really should use -n there Doesn't matter. Only zsh

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread William Hubbs
On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The run_in_build_dir() command simply runs given command in the directory stated as BUILD_DIR. This variable is used commonly by autotools-utils, cmake-utils and python-r1 eclasses, therefore I'm proposing adding the relevant

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Michał Górny
On Sun, 13 Jan 2013 09:05:31 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The run_in_build_dir() command simply runs given command in the directory stated as BUILD_DIR. This variable is used commonly by autotools-utils,

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Alec Warner
On Sun, Jan 13, 2013 at 5:29 AM, Michał Górny mgo...@gentoo.org wrote: The run_in_build_dir() command simply runs given command in the directory stated as BUILD_DIR. This variable is used commonly by autotools-utils, cmake-utils and python-r1 eclasses, therefore I'm proposing adding the

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Gilles Dartiguelongue
Le dimanche 13 janvier 2013 à 16:08 +0100, Michał Górny a écrit : On Sun, 13 Jan 2013 09:05:31 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The run_in_build_dir() command simply runs given command in the directory stated

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread William Hubbs
On Sun, Jan 13, 2013 at 04:08:18PM +0100, Michał Górny wrote: On Sun, 13 Jan 2013 09:05:31 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The run_in_build_dir() command simply runs given command in the directory stated as

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Michał Górny
On Sun, 13 Jan 2013 09:52:09 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 04:08:18PM +0100, Michał Górny wrote: On Sun, 13 Jan 2013 09:05:31 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Michał Górny
On Sun, 13 Jan 2013 07:36:59 -0800 Alec Warner anta...@gentoo.org wrote: On Sun, Jan 13, 2013 at 5:29 AM, Michał Górny mgo...@gentoo.org wrote: The run_in_build_dir() command simply runs given command in the directory stated as BUILD_DIR. This variable is used commonly by autotools-utils,

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Gilles Dartiguelongue
Le dimanche 13 janvier 2013 à 09:52 -0600, William Hubbs a écrit : On Sun, Jan 13, 2013 at 04:08:18PM +0100, Michał Górny wrote: On Sun, 13 Jan 2013 09:05:31 -0600 William Hubbs willi...@gentoo.org wrote: On Sun, Jan 13, 2013 at 02:29:43PM +0100, Michał Górny wrote: The

Re: [gentoo-dev] [PATCH eutils] Introduce run_in_build_dir() used in a few ebuilds.

2013-01-13 Thread Mike Frysinger
On Sunday 13 January 2013 08:29:43 Michał Górny wrote: + [[ ${BUILD_DIR} ]] || die ${FUNCNAME}: BUILD_DIR not set. really should use -n there + pushd ${BUILD_DIR} /dev/null || die + popd /dev/null || die sending errors to /dev/null is wrong -mike signature.asc Description: This