Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

2019-10-12 Thread Mike 



On 10/9/19 7:14 PM, Mike Pagano wrote:

This change will support moving the genpatches tarballs from 
/space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches.

Co-authored-by: Thomas Deutschmann 

Signed-off-by: Mike Pagano 
---
  eclass/kernel-2.eclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..62e6c23e1 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,7 @@ handle_genpatches() {
   UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
   debug-print "genpatches tarball: $tarball"
 fi
-   GENPATCHES_URI+=" 
${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+   GENPATCHES_URI+=" ${use_cond_start}$(echo 
https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
   done
  }




This one committed. Thanks for all the review feedback.

--
2.21.0

--
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail : mpag...@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3=index

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

2019-10-12 Thread Ulrich Mueller 
> On Fri, 11 Oct 2019, Thomas Deutschmann wrote:

> Tilde expansion only happens when string to expand starts with "~" but
> this is not the case here (string starts with "https...").

I stand corrected.

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

2019-10-11 Thread Thomas Deutschmann 
On 2019-10-10 10:56, Ulrich Mueller wrote:
>> On Thu, 10 Oct 2019, Mike Pagano wrote:
> 
>> +   GENPATCHES_URI+=" ${use_cond_start}$(echo 
>> https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
> 
> The ~ should be backslash-escaped or quoted, otherwise it will be
> expanded if there's a user mpagano or whissi on the system. :-)

Just curious, are you sure? I think this is wrong:

Tilde expansion only happens when string to expand starts with "~" but
this is not the case here (string starts with "https...").

I also tried that code and it's working fine for me...


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

2019-10-10 Thread Ulrich Mueller 
> On Thu, 10 Oct 2019, Mike Pagano wrote:

> +   GENPATCHES_URI+=" ${use_cond_start}$(echo 
> https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"

The ~ should be backslash-escaped or quoted, otherwise it will be
expanded if there's a user mpagano or whissi on the system. :-)


signature.asc
Description: PGP signature

Re: [gentoo-dev] [PATCH v3 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace

2019-10-09 Thread Mike Pagano 
This change will support moving the genpatches tarballs from 
/space/distfiles-local to
the devspace ~developer/public_html/dist/genpatches.

Co-authored-by: Thomas Deutschmann 

Signed-off-by: Mike Pagano 
---
 eclass/kernel-2.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index c5f35cd3e..62e6c23e1 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -295,7 +295,7 @@ handle_genpatches() {
  UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}"
  debug-print "genpatches tarball: $tarball"
fi
-   GENPATCHES_URI+=" 
${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}"
+   GENPATCHES_URI+=" ${use_cond_start}$(echo 
https://dev.gentoo.org/~{mpagano,whissi}/dist/genpatches/${tarball})${use_cond_end}"
  done
 }

-- 
2.21.0

-- 
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Member
E-Mail : mpag...@gentoo.org
GnuPG FP   : EEE2 601D 0763 B60F 848C  9E14 3C33 C650 B576 E4E3
Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3=index