Re: [gentoo-dev] Package up for grabs: app-arch/snappy

2021-05-05 Thread Azamat Hackimov
Well, with a little patch magic, I was able to make GTest suite as an
optional dependency.
Here PR: https://github.com/gentoo/gentoo/pull/20692

ср, 5 мая 2021 г. в 21:09, Michał Górny :

> On Wed, 2021-05-05 at 19:47 +0300, Azamat Hackimov wrote:
> > Strangely enough, upstream actually released new 1.1.9 a few hours ago. I
> > don't see any issues with git submodules (there only gtest and benchmark
> > libraries which can be disabled via cmake).
> > Anyway, I can take maintainership over it.
> >
>
> Disabling the tests is not a solution.
>
> --
> Best regards,
> Michał Górny
>
>
>
>

-- 
>From Siberia with Love!


Re: [gentoo-dev] Package up for grabs: app-arch/snappy

2021-05-05 Thread Michał Górny
On Wed, 2021-05-05 at 19:47 +0300, Azamat Hackimov wrote:
> Strangely enough, upstream actually released new 1.1.9 a few hours ago. I
> don't see any issues with git submodules (there only gtest and benchmark
> libraries which can be disabled via cmake).
> Anyway, I can take maintainership over it.
> 

Disabling the tests is not a solution.

-- 
Best regards,
Michał Górny





Re: [gentoo-dev] Package up for grabs: app-arch/snappy

2021-05-05 Thread Azamat Hackimov
Strangely enough, upstream actually released new 1.1.9 a few hours ago. I
don't see any issues with git submodules (there only gtest and benchmark
libraries which can be disabled via cmake).
Anyway, I can take maintainership over it.

ср, 5 мая 2021 г. в 12:54, Michał Górny :

> Hi,
>
> The following package needs a new maintainer:
>
>   app-arch/snappy
>
> Technically, it's not a high traffic package.  It's pending version bump
> but upstream did not bother providing a working release archive,
> and GitHub archives do not work because they are missing git submodules.
>
> That said, it's a typical Google open source package -- bad quality,
> doesn't care the slightest bit about accepting patches or getting bug
> reports, or even making working releases.
>
> --
> Best regards,
> Michał Górny
>
>
>
>

-- 
>From Siberia with Love!