Re: [gentoo-dev] Re: Most common ebuild mistakes?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Donnie Berkholz wrote: > Nathan L. Adams wrote: > | What are the most common ebuild mistakes? > > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3 Thanks everyone. I'll bug each of you individually if I need clarification. Nathan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFDCVEa2QTTR4CNEQARApI1AJ4k5sKZN99EkEDwpPPcPQRB6ALFeQCeLmTB g3cJhP7sP0CTpM4DsTxVzgo= =3rMv -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: Most common ebuild mistakes?
On Sun, 21 Aug 2005 23:52:15 -0400 Jonathan Smith <[EMAIL PROTECTED]>
wrote:
| Georgi Georgiev wrote:
| > When should make be used? I thought that ebuilds should always use
| > emake, and if necessary -- emake -j1. But never make.
|
| make DESTDIR=${D} install || die "make install failed"
make DESTDIR="${D}" install || die "make install failed"
emake tends to break for autotooled things when highly parallelised.
--
Ciaran McCreesh : Gentoo Developer (Vim, Shell tools, Fluxbox, Cron)
Mail: ciaranm at gentoo.org
Web : http://dev.gentoo.org/~ciaranm
pgpOwgfcdWlwB.pgp
Description: PGP signature
Re: [gentoo-dev] Re: Most common ebuild mistakes?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Georgi Georgiev wrote:
> When should make be used? I thought that ebuilds should always use
> emake, and if necessary -- emake -j1. But never make.
make DESTDIR=${D} install || die "make install failed"
- --
smithj
Gentoo Developer
[ desktop stuff && network monitoring && documentation ]
Every email I send is digitally signed with OpenPGP key ID 33E2528C, available
from pgp.mit.edu
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDCUvvl5AvwDPiUowRAgx9AKCSRmJP/K7EVYhQs83mjHaK0yxC7QCeMUsp
eY0hu445uLhk62lFlSeOKDY=
=lEW3
-END PGP SIGNATURE-
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: Most common ebuild mistakes?
maillog: 22/08/2005-04:25:38(+0100): Ciaran McCreesh types
> On Sun, 21 Aug 2005 23:10:58 -0400 "Nathan L. Adams" <[EMAIL PROTECTED]>
> wrote:
> | What are the most common ebuild mistakes?
> | ...
>
> KEYWORDS, under-quoting of variables (we didn't used to care about
> quoting on ${D} etc), using einstall when it's not necessary, using
> emake when make should be used, using make when emake should be used,
When should make be used? I thought that ebuilds should always use
emake, and if necessary -- emake -j1. But never make.
> general formatting, missing ()s after use? tokens, duff header, duff
> indenting, weird extra blank lines, not being sandbox-aware, not using
> IUSE correctly, specifying USE flags and not using them, things being
> detected based upon what's installed rather than USE flags, not using
> eclasses when eclasses should be used. That lot should get you started,
> I can come up with a whole load more once you've gotten those ones
> nailed down :)
>
> Existing tools will already get some of these. However, most
> user-submitted ebuilds have quite clearly not been run through
> repoman...
--
> Georgi Georgiev> Good judgement comes from experience. >
< [EMAIL PROTECTED]< Experience comes from bad judgement. -- <
> +81(90)2877-8845> Jim Horning >
pgpNkentC2beU.pgp
Description: PGP signature
Re: [gentoo-dev] Re: Most common ebuild mistakes?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ciaran McCreesh wrote: > On Sun, 21 Aug 2005 23:10:58 -0400 "Nathan L. Adams" <[EMAIL PROTECTED]> > wrote: > | What are the most common ebuild mistakes? > Existing tools will already get some of these. However, most > user-submitted ebuilds have quite clearly not been run through > repoman... > unnecessarily defining S is another biggie - -- smithj Gentoo Developer [ desktop stuff && network monitoring && documentation ] Every email I send is digitally signed with OpenPGP key ID 33E2528C, available from pgp.mit.edu -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDCUeyl5AvwDPiUowRAuhjAJwJWu2eVftt4ybTOGPaTwa5kZGURgCghl31 e4OaDZm+7tF593dZIzpzngI= =Uvzh -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: Most common ebuild mistakes?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nathan L. Adams wrote: | What are the most common ebuild mistakes? http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=3 Thanks, Donnie -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFDCUdJXVaO67S1rtsRAnjxAJ9I4Zxt6aY2jBtmCHxSHPkvqrLgtACfXoC+ HnERhvFLrYpzBjNX2eyUQWg= =prfl -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: Most common ebuild mistakes?
On Sun, 21 Aug 2005 23:10:58 -0400 "Nathan L. Adams" <[EMAIL PROTECTED]>
wrote:
| What are the most common ebuild mistakes?
|
| A script will never be a substitute for good peer review, but it can
| easily detect (and even correct in some cases) common syntax errors.
| So I'm looking for a list of things like under-quoting variables,
| improper spacing, etc.
KEYWORDS, under-quoting of variables (we didn't used to care about
quoting on ${D} etc), using einstall when it's not necessary, using
emake when make should be used, using make when emake should be used,
general formatting, missing ()s after use? tokens, duff header, duff
indenting, weird extra blank lines, not being sandbox-aware, not using
IUSE correctly, specifying USE flags and not using them, things being
detected based upon what's installed rather than USE flags, not using
eclasses when eclasses should be used. That lot should get you started,
I can come up with a whole load more once you've gotten those ones
nailed down :)
Existing tools will already get some of these. However, most
user-submitted ebuilds have quite clearly not been run through
repoman...
--
Ciaran McCreesh : Gentoo Developer (Vim, Shell tools, Fluxbox, Cron)
Mail: ciaranm at gentoo.org
Web : http://dev.gentoo.org/~ciaranm
pgpJHMkjJW5SY.pgp
Description: PGP signature
