Re: [gentoo-portage-dev] Config Cleanup Last Call

2006-02-24 Thread Jason Stubbs
On Saturday 25 February 2006 10:40, Alec Warner wrote: > Please review for badness, otherwise I'll commit this soon ;) - self.backupenv = os.environ.copy() - self.configlist.append(self.backupenv) # XXX Why though? - self.configdict["backupenv"]=self.configlist[-1] + self.configdict["backupenv

Re: [gentoo-portage-dev] Config Cleanup Last Call

2006-02-24 Thread Jason Stubbs
On Saturday 25 February 2006 10:40, Alec Warner wrote: > Please review for badness, otherwise I'll commit this soon ;) $ grep "^\-" portage-config-cleanup.patch | wc -l 58 $ grep "^\+" portage-config-cleanup.patch | wc -l 41 The unrelated PORTAGE_BINHOST chunk is -15/+1 which makes the relevant p

[gentoo-portage-dev] Config Cleanup Last Call

2006-02-24 Thread Alec Warner
Please review for badness, otherwise I'll commit this soon ;) --- portage.py 2006-01-15 00:08:06.170717008 -0500 +++ - 2006-01-15 00:22:00.597106000 -0500 @@ -931,17 +931,8 @@ self.use_defs = copy.deepcopy(clone.use_defs) self.usemask = copy.deepc