On Thu, 27 Mar 2014 13:48:37 +0100
Alexander Berntsen wrote:
> The first two patches here are not interesting. The first one makes
> DEVELOPING cap at the same width as README. The second adds a "duh"
> paragraph on commits. They are only bundled with what I really wanna
> talk about because I ne
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Please remove the period from the commit message. I would prefer if
you used an explicit import here as well.
Other than those minor complaints, these patches look good to me.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Please use a max 50 char commit message headline, without the period.
On 29/03/14 19:45, Michał Górny wrote:
> +import locale +import math
Why not explicitly import what you are going to use? (On the form of
"from foo import bar, baz".)
- --
Alexan
This is necessary so that the size formatting function (and possibly
other locale-dependant functions in the future) respect the system
locale rather than using the 'C' locale.
---
pym/_emerge/main.py | 4
1 file changed, 4 insertions(+)
diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py
A similar size formatting function was used in two places in emerge
code. Instead, create a single function in portage.localization module
that formats sizes using the current locale and a common set of rules.
I'm not really convinced about 'ceiling' all sizes but I understand
the original point a