Please find the patch split into three smaller patch:
* refactoring: contains the Michal's suggestions. I also removed the
whitespace changes.
* profile attributes export: same as in the previous patch
* profile-env patch: uses "has" to check if profile-env is set. I also
included the documentation
Michal, not opposed to splitting the patch into three parts.
I'd rather use the env/ mechanism instead of the package.env one as it is
more flexible.
It also feels better as ebuild.sh will walk the profiles to source the
bashrc script so a bashrc from a
"low priority" profile may override a packag
On 09/17/2014 02:28 PM, Michał Górny wrote:
>> diff --git a/pym/portage/repository/config.py
>> b/pym/portage/repository/config.py
>> index 5e0d055..ef8054e 100644
>> --- a/pym/portage/repository/config.py
>> +++ b/pym/portage/repository/config.py
>> @@ -40,7 +40,7 @@ if sys.hexversion >= 0x30
Thanks for the patch. I have a few comments though.
Dnia 2014-09-16, o godz. 14:37:04
Bertrand Simonnet napisał(a):
> From 4bf1ee98bb97136e3f6f2182e205aed7ca597640 Mon Sep 17 00:00:00 2001
> From: Bertrand SIMONNET
> Date: Fri, 12 Sep 2014 05:07:20 -0700
> Subject: [PATCH] Make env/ bash script
On 09/17/2014 11:12 AM, Bertrand Simonnet wrote:
> Thanks Alexander and Zac for your review!
>
> I'll add documentation for profile-env.
> Do you prefer having it in the same patch or in a separate one ?
I'm not too particular, but all in one patch sounds good to me.
--
Thanks,
Zac
Thanks Alexander and Zac for your review!
I'll add documentation for profile-env.
Do you prefer having it in the same patch or in a separate one ?
Bertrand
On Wed, Sep 17, 2014 at 11:02 AM, Zac Medico wrote:
> On 09/17/2014 12:14 AM, Alexander Berntsen wrote:
> > On 17/09/14 00:13, Zac Medico
On 09/17/2014 12:14 AM, Alexander Berntsen wrote:
> On 17/09/14 00:13, Zac Medico wrote:
>> I all looks very well done to me now. I'd encourage others on the
>> list to review it now, in case there's anything that I missed.
> At a glance, it looks OK to me. You can commit it if you vouch for it,
>
On 09/17/2014 09:28 AM, Brian Dolbec wrote:
> On Fri, 12 Sep 2014 11:12:27 -0700
> Zac Medico wrote:
>
>> Since self._dynamic_config._slot_operator_deps only contains deps for
>> packages added to the graph, it doesn't contain potentially relevant
>> deps of installed packages that have not been
On Fri, 12 Sep 2014 11:12:27 -0700
Zac Medico wrote:
> Since self._dynamic_config._slot_operator_deps only contains deps for
> packages added to the graph, it doesn't contain potentially relevant
> deps of installed packages that have not been added to the graph.
> Therefore, generate pseudo-deps
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 17/09/14 00:13, Zac Medico wrote:
> I all looks very well done to me now. I'd encourage others on the
> list to review it now, in case there's anything that I missed.
At a glance, it looks OK to me. You can commit it if you vouch for it,
Zac.
- --
10 matches
Mail list logo
