[gentoo-portage-dev] Re: [PATCH] lib/portage/repository/config.py: fix trailing-comma-tuple

2020-08-04 Thread Zac Medico
On 8/4/20 7:35 PM, Aaron Bauman wrote: > * This fixes the one instance of trailing-comma-tuple in the repo > * A tuple does need created, but lets do so inside of parentheses as > expected > > Suggested-By: Sam James > Suggested-By: Zac Medico > Signed-off-by: Aaron Bauman > --- >

[gentoo-portage-dev] [PATCH] lib/portage/repository/config.py: fix trailing-comma-tuple

2020-08-04 Thread Aaron Bauman
* This fixes the one instance of trailing-comma-tuple in the repo * A tuple does need created, but lets do so inside of parentheses as expected Suggested-By: Sam James Suggested-By: Zac Medico Signed-off-by: Aaron Bauman --- lib/portage/repository/config.py | 2 +- pylintrc

Re: [gentoo-portage-dev] [PATCH] DEVELOPING: Update minimum python version

2020-08-04 Thread Zac Medico
On 8/4/20 6:05 PM, Aaron Bauman wrote: > * Other style/readability fixes > > Signed-off-by: Aaron Bauman > --- > DEVELOPING | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) Thanks, merged:

Re: [gentoo-portage-dev] [PATCH 1/2] lib/portage/repository/config.py: fix trailing comma

2020-08-04 Thread Brian Dolbec
On Tue, 4 Aug 2020 21:56:08 -0400 Aaron Bauman wrote: > On Tue, Aug 04, 2020 at 09:43:03PM -0400, Aaron Bauman wrote: > > * This fixes the one instance of a trailing comma in the repo which > > actually causes a tuple to be created. > > > > Signed-off-by: Aaron Bauman > > --- > >

Re: [gentoo-portage-dev] [PATCH 1/2] lib/portage/repository/config.py: fix trailing comma

2020-08-04 Thread Aaron Bauman
On Tue, Aug 04, 2020 at 09:43:03PM -0400, Aaron Bauman wrote: > * This fixes the one instance of a trailing comma in the repo which > actually causes a tuple to be created. > > Signed-off-by: Aaron Bauman > --- > lib/portage/repository/config.py | 2 +- > 1 file changed, 1 insertion(+), 1

[gentoo-portage-dev] [PATCH 2/2] pylintrc: turn on trailing commas check

2020-08-04 Thread Aaron Bauman
Signed-off-by: Aaron Bauman --- pylintrc | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pylintrc b/pylintrc index 337311daa..d651cd1ee 100644 --- a/pylintrc +++ b/pylintrc @@ -13,15 +13,16 @@

[gentoo-portage-dev] [PATCH 1/2] lib/portage/repository/config.py: fix trailing comma

2020-08-04 Thread Aaron Bauman
* This fixes the one instance of a trailing comma in the repo which actually causes a tuple to be created. Signed-off-by: Aaron Bauman --- lib/portage/repository/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/portage/repository/config.py

[gentoo-portage-dev] [PATCH] DEVELOPING: Update minimum python version

2020-08-04 Thread Aaron Bauman
* Other style/readability fixes Signed-off-by: Aaron Bauman --- DEVELOPING | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/DEVELOPING b/DEVELOPING index 31b559402..7bc559125 100644 --- a/DEVELOPING +++ b/DEVELOPING @@ -1,17 +1,15 @@ Code Guidelines

Re: [gentoo-portage-dev] [PATCH] pylintrc: add more module checks

2020-08-04 Thread Zac Medico
On 8/4/20 7:08 AM, Aaron Bauman wrote: > * Repo is already clear... so let's turn these on > > Signed-off-by: Aaron Bauman > --- > pylintrc | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/pylintrc b/pylintrc > index ad32f70d7..cd76d38dd

[gentoo-portage-dev] [PATCH] pylintrc: add more module checks

2020-08-04 Thread Aaron Bauman
* Repo is already clear... so let's turn these on Signed-off-by: Aaron Bauman --- pylintrc | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/pylintrc b/pylintrc index ad32f70d7..cd76d38dd 100644 --- a/pylintrc +++ b/pylintrc @@ -13,16 +13,23 @@