[gentoo-portage-dev] [PATCH] depgraph: autounmask for conditional USE deps (bug 566704)

2015-11-24 Thread Zac Medico
For parents with unsatisfied conditional dependencies, translate USE change suggestions into autounmask changes. X-Gentoo-Bug: 566704 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=566704 --- pym/_emerge/depgraph.py| 36 +++-

Re: [gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132)

2015-11-23 Thread Zac Medico
On 11/23/2015 02:39 AM, Alexander Berntsen wrote: > Sorry for not being up to date what this does, but the bug complains > specifically about GitHub mirrors, while the patch itself seems far > more invasive. Is it the case that they should *never* go to STDERR? Since the sync modules can call a

[gentoo-portage-dev] [PATCH] SyncManager: redirect command stderr to stdout (bug 566132)

2015-11-22 Thread Zac Medico
X-Gentoo-Bug: 566132 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=566132 --- pym/portage/sync/controller.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/pym/portage/sync/controller.py b/pym/portage/sync/controller.py index 4595293..e71ba67 100644 ---

[gentoo-portage-dev] [PATCH] SpawnProcess: re-check cgroup.procs until empty (bug 566420)

2015-11-21 Thread Zac Medico
For subshell die support (bug 465008), we need to re-check cgroup.procs until it's empty, in case any of the listed processes fork before we've had a chance to kill them. X-Gentoo-Bug: 566420 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=566420 --- pym/_emerge/SpawnProcess.py | 11

[gentoo-portage-dev] [PATCH] SpawnProcess: make _cancel kill all processes in cgroup (bug 566414)

2015-11-21 Thread Zac Medico
Since the _cancel method is used to kill subprocesses after die is called, this fixes die calls in subshells to kill all processes in the cgroup. For example, see the test ebuild attached to bug 465008, which would hang for 60 seconds after die was called as follows: sleep 60 | ( false || die

Re: [gentoo-portage-dev] [PATCH] src_prepare: Do not expect eapply_user in EAPIs not having it

2015-11-18 Thread Zac Medico
On 11/18/2015 08:32 AM, Michał Górny wrote: > --- > bin/phase-functions.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh > index abbc602..042e242 100644 > --- a/bin/phase-functions.sh > +++ b/bin/phase-functions.sh > @@

[gentoo-portage-dev] Re: [PATCH] eapply_user: die if current phase is not src_prepare

2015-11-18 Thread Zac Medico
On 11/18/2015 12:01 AM, Zac Medico wrote: > --- > bin/phase-helpers.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh > index da9aa7c..f42f805 100644 > --- a/bin/phase-helpers.sh > +++ b/bin/phase-helpers.sh &g

[gentoo-portage-dev] [PATCH] eapply_user: die if current phase is not src_prepare

2015-11-18 Thread Zac Medico
--- bin/phase-helpers.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index da9aa7c..f42f805 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -1079,6 +1079,8 @@ fi if ___eapi_has_eapply_user; then eapply_user() { +

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Zac Medico
On 11/17/2015 02:20 PM, Michał Górny wrote: > --- > bin/phase-functions.sh | 6 ++ > bin/phase-helpers.sh | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh > index 7bf4d63..abbc602 100644 > --- a/bin/phase-functions.sh > +++

Re: [gentoo-portage-dev] [PATCH v4] LinkageMapELF: account for {PROVIDES,REQUIRES}_EXCLUDE (bug 565792)

2015-11-16 Thread Zac Medico
On 11/16/2015 03:07 AM, Alexander Berntsen wrote: > Uh this probably makes sense. > > Anyone else know anything about this stuff? > I've just realized that intersection with REQUIRES is flawed, because REQUIRES automatically excludes all sonames that are in PROVIDES. So, as is, the patch will

Re: [gentoo-portage-dev] [PATCH] repoman: Update in_iuse & get_libdir inherit check for EAPI 6

2015-11-16 Thread Zac Medico
On 11/16/2015 08:58 AM, Michał Górny wrote: > Update the eclass inherit check not to complain about in_iuse and > get_libdir in EAPI 6 since they no longer require the respective > eclasses. > --- > pym/repoman/checks/ebuilds/checks.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-)

[gentoo-portage-dev] [PATCH] LinkageMapELF: account for {PROVIDES,REQUIRES}_EXCLUDE (bug 565792)

2015-11-15 Thread Zac Medico
Make LinkageMapELF safely discard NEEDED.ELF.2 data when possible, in a manner consistent with PROVIDES_EXCLUDE and REQUIRES_EXCLUDE. Achieve this by intersection with PROVIDES and REQUIRES, which is equivalent to evaluating PROVIDES_EXCLUDE and REQUIRES_EXCLUDE, but simpler to do. Do not apply

[gentoo-portage-dev] [PATCH v2] LinkageMapELF: account for {PROVIDES,REQUIRES}_EXCLUDE (bug 565792)

2015-11-15 Thread Zac Medico
Make LinkageMapELF safely discard NEEDED.ELF.2 data when possible, in a manner consistent with PROVIDES_EXCLUDE and REQUIRES_EXCLUDE. Achieve this by intersection with PROVIDES and REQUIRES, which is equivalent to evaluating PROVIDES_EXCLUDE and REQUIRES_EXCLUDE, but simpler to do. Do not apply

Re: [gentoo-portage-dev] [PATCH 1/2] Warn if LC_CTYPE does not transform ASCII chars like POSIX

2015-11-15 Thread Zac Medico
On 11/14/2015 02:56 PM, Michał Górny wrote: > +def check_locale(): > + """ > + Check whether the locale is sane. Returns True if it is, prints > + warning and returns False if it is not. Returns None if the check > + can not be executed due to platform limitations. > + """ > +

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Enforce LC_COLLATE=C in ebuild environment

2015-11-15 Thread Zac Medico
On 11/15/2015 12:16 AM, Michał Górny wrote: > --- > pym/portage/eapi.py| 9 +++-- > pym/portage/package/ebuild/config.py | 5 + > pym/portage/package/ebuild/doebuild.py | 2 +- > pym/portage/util/locale.py | 21 + > 4 files changed,

Re: [gentoo-portage-dev] [PATCH] util/locale: Cache check_locale() results for specific locales

2015-11-15 Thread Zac Medico
On 11/15/2015 02:49 PM, Michał Górny wrote: > --- > pym/portage/util/locale.py | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) > > diff --git a/pym/portage/util/locale.py b/pym/portage/util/locale.py > index 27a2806..58ecb2a 100644 > ---

Re: [gentoo-portage-dev] [PATCH 4/4] Enable EAPI 6

2015-11-15 Thread Zac Medico
On 11/15/2015 01:17 PM, Michał Górny wrote: > --- > pym/portage/const.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pym/portage/const.py b/pym/portage/const.py > index 6c4f613..814d7f4 100644 > --- a/pym/portage/const.py > +++ b/pym/portage/const.py > @@ -202,7

[gentoo-portage-dev] [PATCH v3] LinkageMapELF: account for {PROVIDES,REQUIRES}_EXCLUDE (bug 565792)

2015-11-15 Thread Zac Medico
Make LinkageMapELF safely discard NEEDED.ELF.2 data when possible, in a manner consistent with PROVIDES_EXCLUDE and REQUIRES_EXCLUDE. Achieve this by intersection with PROVIDES and REQUIRES, which is equivalent to evaluating PROVIDES_EXCLUDE and REQUIRES_EXCLUDE, but simpler when PROVIDES and

[gentoo-portage-dev] [PATCH v4] LinkageMapELF: account for {PROVIDES,REQUIRES}_EXCLUDE (bug 565792)

2015-11-15 Thread Zac Medico
Make LinkageMapELF safely discard NEEDED.ELF.2 data when possible, in a manner consistent with PROVIDES_EXCLUDE and REQUIRES_EXCLUDE. Achieve this by intersection with PROVIDES and REQUIRES, which is equivalent to evaluating PROVIDES_EXCLUDE and REQUIRES_EXCLUDE, but simpler when PROVIDES and

Re: [gentoo-portage-dev] [PATCH 3/4] EAPI 6: Enforce posixish LC_CTYPE

2015-11-15 Thread Zac Medico
On 11/15/2015 01:17 PM, Michał Górny wrote: > -def check_locale(): > +def check_locale(silent=False, env=None): We should memoize the result of this function, using the cache_key

Re: [gentoo-portage-dev] [PATCH] eapply: Ensure that files are sorted lexically

2015-11-14 Thread Zac Medico
On 11/14/2015 10:37 AM, Michał Górny wrote: > Ensure that patch files are sorted lexically even when both *.diff > and *.patch files co-exist within a single directory. > --- > bin/phase-helpers.sh | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git

Re: [gentoo-portage-dev] [PATCH] eapply: Ensure that files are sorted lexically

2015-11-14 Thread Zac Medico
On 11/14/2015 10:37 AM, Michał Górny wrote: > + _eapply_get_files "${f}" It looks like there's a typo in the enclosing for loop: for i in "${files[@]}"; do That i should be an f, right? And we need another local declaration for the outer f variable. -- Thanks,

Re: [gentoo-portage-dev] [PATCH] eapply: Fix off-by-one error when parsing options

2015-11-14 Thread Zac Medico
On 11/14/2015 01:42 PM, Michał Górny wrote: > Fix off-by-one error that skipped the first path when processing options > without a double-hyphen. > --- > bin/phase-helpers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh >

Re: [gentoo-portage-dev] [PATCH] __eapi6_src_prepare: Silence 'declare -p PATCHES' errors

2015-11-14 Thread Zac Medico
On 11/14/2015 01:46 PM, Michał Górny wrote: > Silence the error message when PATCHES array is not declared. > --- > bin/phase-helpers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh > index 3e619dc..6c45c25 100644 > ---

Re: [gentoo-portage-dev] [PATCH] eapply: Fix typo

2015-11-14 Thread Zac Medico
On 11/14/2015 01:30 PM, Michał Górny wrote: > --- > bin/phase-helpers.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh > index 1d3c976..6d563b5 100644 > --- a/bin/phase-helpers.sh > +++ b/bin/phase-helpers.sh > @@ -1037,7

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-13 Thread Zac Medico
On 11/13/2015 12:12 AM, Ulrich Mueller wrote: >>>>>> On Thu, 12 Nov 2015, Zac Medico wrote: > >> On 11/12/2015 04:06 PM, Mike Frysinger wrote: >>> from ebuilds/eclasses that have already stopped using __: >>> __do_sed_fix () >>> ___ECLASS_RECU

Re: [gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-13 Thread Zac Medico
On 11/13/2015 03:48 AM, Alexander Berntsen wrote: > On 12/11/15 01:11, Zac Medico wrote: >> Use the TaskScheduler class to parallelize GenChangeLogs. Fix >> AsyncFunction so it does not re-define 'args' in __slots__. > Why is this not two patches? Otherwise it looks OK, I

Re: [gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly

2015-11-13 Thread Zac Medico
On 11/13/2015 03:46 AM, Alexander Berntsen wrote: > On 11/11/15 22:33, Michał Górny wrote: >> Output a warning if LC_CTYPE is set to a value that causes libc >> toupper() and/or tolower() conversions not apply correctly to printable >> ASCII characters. > I think you a verb. > >> +

Re: [gentoo-portage-dev] [PATCH] Warn if LC_CTYPE does not toupper()/tolower() ASCII chars correctly

2015-11-13 Thread Zac Medico
On 11/13/2015 11:41 AM, Michał Górny wrote: > On Fri, 13 Nov 2015 12:46:31 +0100 > Alexander Berntsen wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> On 11/11/15 22:33, Michał Górny wrote: >>> Output a warning if LC_CTYPE is set to a value that causes

Re: [gentoo-portage-dev] Re: [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-13 Thread Zac Medico
On 11/13/2015 12:25 PM, Duncan wrote: > Alexander Berntsen posted on Fri, 13 Nov 2015 13:17:28 +0100 as excerpted: > >> On 12/11/15 16:00, Michał Górny wrote: >>> their generation should be run as the lask task done by egencache, >>> followed only by timestamp update. > >> Is "lask" supposed to

Re: [gentoo-portage-dev] [PATCH] egencache --update-changelogs: Respect GIT_DIR

2015-11-12 Thread Zac Medico
On 11/08/2015 11:24 PM, Michał Górny wrote: > Allow generating ChangeLogs from external git checkout via using > GIT_DIR, rather than requiring the repository to be git. > --- > bin/egencache | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/bin/egencache

[gentoo-portage-dev] [PATCH] FindVCS: support optional cwd argument

2015-11-12 Thread Zac Medico
Since os.chdir calls may not be safe to use in threads, iterators, or event-driven code, make FindVCS support a cwd argument which defaults to the current working directory. --- pym/repoman/vcs/vcs.py | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

Re: [gentoo-portage-dev] [PATCH] ebuild: clear __bashpid & __start_distcc from env

2015-11-12 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/12/2015 05:50 PM, Mike Frysinger wrote: > These are internal funcs that should not be exported into the env. > --- bin/save-ebuild-env.sh | 1 + 1 file changed, 1 insertion(+) > > diff --git a/bin/save-ebuild-env.sh b/bin/save-ebuild-env.sh

[gentoo-portage-dev] [PATCH] GenChangeLogs: parallelize remaining git calls, scale linearly (bug 565540)

2015-11-12 Thread Zac Medico
Move all git calls to the subprocesses, so performance scales linearly with --jobs. X-Gentoo-Bug: 565540 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=565540 --- bin/egencache | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Zac Medico
On 11/12/2015 06:07 PM, Tim Harder wrote: > On 2015-11-11 14:42, Zac Medico wrote: >> Please unset all new internal function inside bin/save-ebuild-env.sh. >> Note that it already uses this line to unset functions beginning with >> ___eapi: > >>unset -f

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Zac Medico
On 11/12/2015 06:33 PM, Tim Harder wrote: > On 2015-11-12 21:25, Zac Medico wrote: >>> Just to note another approach, pkgcore generates global and per-eapi >>> function lists at install time (or uses the generation scripts when >>> running from a checkout) so manual

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Zac Medico
On 11/12/2015 08:35 AM, Zac Medico wrote: > On 11/12/2015 07:00 AM, Michał Górny wrote: >> Since thick Manifests can reference other files (ChangeLogs especially), >> their generation should be run as the lask task done by egencache, >> followed only by timestamp update. >

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Zac Medico
On 11/12/2015 07:00 AM, Michał Górny wrote: > Since thick Manifests can reference other files (ChangeLogs especially), > their generation should be run as the lask task done by egencache, > followed only by timestamp update. GenPkgDescIndex needs to execute last, since it accesses the metadata.

Re: [gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-11 Thread Zac Medico
On 11/11/2015 02:30 PM, robb...@gentoo.org wrote: > From: "Robin H. Johnson" > > If GIT_DIR is used, and .git is outside the root of the checkout, then > --work-tree=... needs to be specified, otherwise any Git command that > relies on relative directories to the root will be

Re: [gentoo-portage-dev] [PATCH v2] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:00 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > This does not ban newer features, it tells bash to use > the older bash behavior when the behavior changes across > versions. > ---

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 01:11 PM, Mike Frysinger wrote: > On 11 Nov 2015 13:04, Zac Medico wrote: >> On 11/11/2015 12:55 PM, Mike Frysinger wrote: >>> On 11 Nov 2015 11:42, Zac Medico wrote: >>>> On 11/10/2015 08:39 PM, Mike Frysinger wrote: >>>>> +

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 10:33 PM, Zac Medico wrote: > On 11/11/2015 01:11 PM, Mike Frysinger wrote: >> On 11 Nov 2015 13:04, Zac Medico wrote: >>> On 11/11/2015 12:55 PM, Mike Frysinger wrote: >>>> On 11 Nov 2015 11:42, Zac Medico wrote: >>>>> On 11/10/2015 08:

[gentoo-portage-dev] [PATCH] egencache: parallelize --update-changelogs (bug 565540)

2015-11-11 Thread Zac Medico
Use the TaskScheduler class to parallelize GenChangeLogs. Fix AsyncFunction so it does not re-define 'args' in __slots__. X-Gentoo-Bug: 565540 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=565540 --- bin/egencache| 24 +++-

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/10/2015 08:39 PM, Mike Frysinger wrote: > To try and provide better stability across bash versions, > set the language compat level based on the current EAPI. > --- > bin/eapi.sh | 8 > bin/ebuild.sh | 39 +++ > 2 files changed, 47

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-11 Thread Zac Medico
On 11/11/2015 12:55 PM, Mike Frysinger wrote: > On 11 Nov 2015 11:42, Zac Medico wrote: >> On 11/10/2015 08:39 PM, Mike Frysinger wrote: >>> +# Set up the bash version compatibility level. >>> +__check_bash_version() { >> >> Please unset all new internal

Re: [gentoo-portage-dev] [PATCH 5/7] eapply_user: make idempotent per changes to EAPI 6

2015-11-09 Thread Zac Medico
On 11/09/2015 09:49 AM, Michał Górny wrote: > --- > bin/phase-helpers.sh | 4 > 1 file changed, 4 insertions(+) > > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh > index 2fea0b2..bd4e999 100644 > --- a/bin/phase-helpers.sh > +++ b/bin/phase-helpers.sh > @@ -1070,6 +1070,10 @@ fi

[gentoo-portage-dev] [PATCH v2] repos.conf: support sync-hooks-only-on-change attribute (bug 565172)

2015-11-09 Thread Zac Medico
If sync-hooks-only-on-change is set to true, do not trigger postsync hooks unless hooks would have executed for a master repository or the repository has changed since the previous sync operation. If the user has not explicitly enabled sync-hooks-only-on-change in repos.conf, then execute all

[gentoo-portage-dev] [PATCH] repos.conf: support sync-hooks-lazy attribute (bug 565172)

2015-11-08 Thread Zac Medico
If sync-hooks-lazy is set to true, do not trigger postsync hooks unless hooks would have executed for a master repository or the repository has changed since the previous sync operation. If the user has not explicitly enabled sync-hooks-lazy in repos.conf, then execute all hooks regardless of

Re: [gentoo-portage-dev] [PATCH] repos.conf: support sync-hooks-lazy attribute (bug 565172)

2015-11-08 Thread Zac Medico
On 11/08/2015 11:26 PM, Michał Górny wrote: > On Sun, 8 Nov 2015 15:20:01 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> If sync-hooks-lazy is set to true, do not trigger postsync hooks unless >> hooks would have executed for a master repository or the repo

Re: [gentoo-portage-dev] [PATCH] egencache --update-changelogs: Respect GIT_DIR

2015-11-08 Thread Zac Medico
On 11/08/2015 11:24 PM, Michał Górny wrote: > @@ -886,7 +884,7 @@ class GenChangeLogs(object): > repo_path = self._portdb.porttrees[0] > os.chdir(repo_path) > > - if 'git' not in FindVCS(): > + if not os.path.isdir(os.environ.get('GIT_DIR',

[gentoo-portage-dev] [PATCH] GitSync: skip metadata-transfer when appropriate (bug 564988)

2015-11-07 Thread Zac Medico
Set updatecache_flg to False if the git revision is unchanged. X-Gentoo-Bug: 564988 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=564988 --- pym/portage/sync/modules/git/git.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[gentoo-portage-dev] [PATCH] RsyncSync: skip metadata-transfer when appropriate (bug 564988)

2015-11-06 Thread Zac Medico
Fix flaws in logic involving the updatecache_flg variable, in order to skip metadata-transfer when sync fails (or the server timestamp has not changed). X-Gentoo-Bug: 564988 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=564988 --- pym/portage/sync/modules/rsync/rsync.py | 17

Re: [gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

2015-11-06 Thread Zac Medico
On 11/06/2015 10:39 AM, Michał Górny wrote: > On Fri, 6 Nov 2015 09:24:15 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> On 11/06/2015 12:20 AM, Alexander Berntsen wrote: >>> On 06/11/15 09:05, Michał Górny wrote: >>>>>> I know not

Re: [gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

2015-11-06 Thread Zac Medico
On 11/06/2015 12:20 AM, Alexander Berntsen wrote: > On 06/11/15 09:05, Michał Górny wrote: I know nothing about the egencache stuff. Maybe Michał can comment? >> Michał finds this black magic. Trusts zmedico. > I think it looks like it's probably supposed to be reasonable, perhaps. > >

Re: [gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

2015-11-06 Thread Zac Medico
On 11/06/2015 12:19 PM, Michał Górny wrote: > On Fri, 6 Nov 2015 11:49:44 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> On 11/06/2015 11:34 AM, Michał Górny wrote: >>> On Fri, 6 Nov 2015 10:58:23 -0800 >>> Zac Medico <zmed...@gentoo.org> wrot

Re: [gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

2015-11-06 Thread Zac Medico
On 11/06/2015 11:34 AM, Michał Górny wrote: > On Fri, 6 Nov 2015 10:58:23 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> On 11/06/2015 10:39 AM, Michał Górny wrote: >>> On Fri, 6 Nov 2015 09:24:15 -0800 >>> Zac Medico <zmed...@gentoo.org> wrote:

[gentoo-portage-dev] [PATCH] postsync: skip hooks and metadata-transfer when appropriate (bug 564988)

2015-11-05 Thread Zac Medico
Fix flaws in logic involving the updatecache_flg variable. Use this variable to skip hooks and metadata-transfer when sync fails (or the server timestamp has not changed). X-Gentoo-Bug: 564988 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=564988 ---

[gentoo-portage-dev] [PATCH] AbstractEbuildProcess: validate cgroup release agent

2015-11-03 Thread Zac Medico
Since commit e6be71af3f67ea274db455e9c24d5f84bd372c39, the release agent can refer to a temporary file if it was set while portage was updating itself. Fix it to reset the release agent when necessary. Fixes: e6be71af3f67 ("AbstractEbuildProcess: remove cgroup with release_agent (bug 561264)")

Re: [gentoo-portage-dev] [PATCHES] egencache --update-changelogs: fixes for infra rsync

2015-11-02 Thread Zac Medico
On 11/02/2015 10:18 AM, Michał Górny wrote: > Hi, > > A quick batch of patches fulfilling Infra requests needed for ChangeLog > generation on rsync mirrors and fixing some minor issues. > > -- > Best regards, > Michał Górny > > The whole series looks good, except it's missing updates to

Re: [gentoo-portage-dev] [PATCH] xpak-helper: rewrite to rely more on argparse

2015-11-02 Thread Zac Medico
On 11/02/2015 09:06 AM, Zac Medico wrote: > On 11/02/2015 08:52 AM, Mike Frysinger wrote: >> On 01 Nov 2015 09:36, Zac Medico wrote: >>> In order to handle python3 with arguments containing UTF-8 characters >>> (in ${PKGDIR}) and a mis-matched sys.getfilesystemencodi

Re: [gentoo-portage-dev] [PATCH] xpak-helper: rewrite to rely more on argparse

2015-11-02 Thread Zac Medico
On 11/02/2015 08:52 AM, Mike Frysinger wrote: > On 01 Nov 2015 09:36, Zac Medico wrote: >> In order to handle python3 with arguments containing UTF-8 characters >> (in ${PKGDIR}) and a mis-matched sys.getfilesystemencoding() value, it's >> safest to decode the arguments li

Re: [gentoo-portage-dev] [PATCH] xpak-helper: rewrite to rely more on argparse

2015-11-01 Thread Zac Medico
On 10/31/2015 10:23 PM, Mike Frysinger wrote: > The current code implements a lot of ad-hoc argument parsing when it > could simply let the argparse module do it all for it. This makes the > code easier to understand and extend in the process. > --- > bin/xpak-helper.py | 68 >

Re: [gentoo-portage-dev] [PATCH] runtests: create a global tempdir to hold subtest files

2015-10-30 Thread Zac Medico
On 10/30/2015 11:52 AM, Zac Medico wrote: > On 10/30/2015 11:00 AM, Mike Frysinger wrote: > >> +try: >> +# Set up a single tempdir for all the tests to use. >> +# This way we know the tests won't leak things on us. >> +tem

Re: [gentoo-portage-dev] [PATCH] runtests: create a global tempdir to hold subtest files

2015-10-30 Thread Zac Medico
On 10/30/2015 11:00 AM, Mike Frysinger wrote: > + try: > + # Set up a single tempdir for all the tests to use. > + # This way we know the tests won't leak things on us. > + tempdir = tempfile.mkdtemp(prefix='portage.runtests.') [snip] > + finally: > +

Re: [gentoo-portage-dev] [PATCH 2/2] _argparse: punt the module

2015-10-29 Thread Zac Medico
On 10/29/2015 08:57 PM, Mike Frysinger wrote: > Since we don't support python 2.6 anymore, there's no need to wrap > argparse, so switch all the users to the standard library for it. Both patches look good. -- Thanks, Zac

Re: [gentoo-portage-dev] [PATCH] vardbapi.aux_get: treat cache as valid if mtime is truncated (bug 564222)

2015-10-28 Thread Zac Medico
On 10/28/2015 04:44 AM, Alexander Berntsen wrote: > Sheesh. That expression barely fits in a tweet. ;) Please just use > intermediate statements or an if or something. Otherwise LGTM. I've split it with an if, and also eliminated a redundant comparison since long(cache_mtime) ==

[gentoo-portage-dev] [PATCH] vardbapi.aux_get: treat cache as valid if mtime is truncated (bug 564222)

2015-10-27 Thread Zac Medico
X-Gentoo-Bug: 564222 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=564222 --- pym/portage/dbapi/vartree.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py index 5ba8d9d..bac9837 100644 ---

[gentoo-portage-dev] [PATCH] repoman: checks deps of stable ebuilds for unstable configurations (bug 563546)

2015-10-25 Thread Zac Medico
For ebuilds with stable keywords, check if the dependencies are satisfiable for unstable configurations, since use.stable.mask is not applied for unstable configurations. Fix the KeywordsManager.isStable method to behave consistently for both repoman and emerge. X-Gentoo-Bug: 563546

[gentoo-portage-dev] [PATCH] calc_depclean: do not abort for broken soname dependencies (bug 563844)

2015-10-23 Thread Zac Medico
X-Gentoo-Bug: 563844 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=563844 --- pym/_emerge/actions.py | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py index 602715b..7f1cb59 100644 ---

Re: [gentoo-portage-dev] @sets and @profile does not work when ROOT=PORTAGE_CONFIGROOT=/my/new/root

2015-10-22 Thread Zac Medico
On 10/22/2015 12:16 PM, Joakim Tjernlund wrote: > On Thu, 2015-10-22 at 11:54 -0700, Zac Medico wrote: >> On 10/22/2015 11:29 AM, Joakim Tjernlund wrote: >>> On Thu, 2015-10-22 at 08:54 -0700, Zac Medico wrote: >>>> On 10/22/2015 12:05 AM, Joakim Tjernlund wrote: &

Re: [gentoo-portage-dev] @sets and @profile does not work when ROOT=PORTAGE_CONFIGROOT=/my/new/root

2015-10-22 Thread Zac Medico
On 10/22/2015 01:54 PM, Joakim Tjernlund wrote: > On Thu, 2015-10-22 at 12:25 -0700, Zac Medico wrote: >> On 10/22/2015 12:16 PM, Joakim Tjernlund wrote: >>> On Thu, 2015-10-22 at 11:54 -0700, Zac Medico wrote: >>>> On 10/22/2015 11:29 AM, Joakim Tjernlund wrote: >

[gentoo-portage-dev] [PATCH] RepoConfigLoader: allow subsitution of variables like ROOT in repos.conf

2015-10-22 Thread Zac Medico
This makes it possible to sync repositories inside $ROOT. X-Gentoo-Bug: 563836 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=563836 --- pym/portage/repository/config.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pym/portage/repository/config.py

Re: [gentoo-portage-dev] cross emerge pulls in my hosts gentoo repo

2015-10-22 Thread Zac Medico
On 10/22/2015 12:24 AM, Joakim Tjernlund wrote: > In my cross sysroot I have: > [DEFAULT] > main-repo = tm-cusfpv3 > > [tm-cusfpv3] > location = /usr/local/portage/tm-cusfpv3/ > masters = > priority = 500 > auto-sync = no > > Still "sudo powerpc-g2.20-linux-gnu-emerge -d -ep sys-libs/pam"

Re: [gentoo-portage-dev] @sets and @profile does not work when ROOT=PORTAGE_CONFIGROOT=/my/new/root

2015-10-21 Thread Zac Medico
On 10/21/2015 09:47 AM, Joakim Tjernlund wrote: > I have enabled @sets and @profile in my own profile and if I add > some pkg to either my new set or @profile in ROOT=PORTAGE_CONFIGROOT=/ > then emerge -aNDuv world notices this and pulls in the new pkg. > > Then I clone / to /my/new/root and add

[gentoo-portage-dev] [PATCH] emerge(1): document --oneshot caveats (bug 563482)

2015-10-20 Thread Zac Medico
X-Gentoo-Bug: 563482 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=563482 --- man/emerge.1 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/emerge.1 b/man/emerge.1 index 237fb79..c03f044 100644 --- a/man/emerge.1 +++ b/man/emerge.1 @@ -676,6 +676,13 @@ packages that

[gentoo-portage-dev] [PATCH] calc_depclean: adjust early warning messages

2015-10-20 Thread Zac Medico
Suppress "no system list" warning if @profile is non-empty, in order to support @profile as an alternative to @system. Suppress "no world file" warnings unless @world is completely empty, since having an empty world file can be a valid state. Abort if a PackageSetNotFound error is encountered, or

[gentoo-portage-dev] [PATCH v2] calc_depclean: adjust early warning messages

2015-10-20 Thread Zac Medico
Suppress "no system list" warning if @profile is non-empty, in order to support @profile as an alternative to @system. Always warn if the world file is empty, but drop the "Proceeding is likely to break your installation" message and 10 second countdown. Abort if a PackageSetNotFound error is

Re: [gentoo-portage-dev] [PATCH] emerge(1): document --oneshot caveats (bug 563482)

2015-10-20 Thread Zac Medico
On 10/20/2015 05:37 PM, Rob Wortman wrote: > On 2015-10-20 at 21:44:58 +0200, berna...@gentoo.org wrote: >> (since it's describing somewhat complicated functionality) > > So, I'm curious what's actually going on there. If I emerge packages > with --oneshot, does that create the possibility of

Re: [gentoo-portage-dev] !!! You have no world file.

2015-10-16 Thread Zac Medico
On 10/16/2015 06:43 AM, Joakim Tjernlund wrote: > emerge -a --depclean > !!! You have no world file. > !!! Proceeding is likely to break your installation. Waiting 10 seconds before starting... (Control-C to abort)... Depclean in: 10 9 8 7 6 5 4 3 2 1 > > Would be nice this warning

Re: [gentoo-portage-dev] [PATCH] repoman: Finally deprecate base.eclass

2015-10-11 Thread Zac Medico
On 10/11/2015 09:51 AM, Alexander Berntsen wrote: > On 11/10/15 18:45, Michał Górny wrote: >> Nope, don't have any. Though AFAICS there's all-over-the-place >> consensus that it's deprecated, and most of the developers complain >> when they see it. > If you can show me the consensus, I'll ACK

Re: [gentoo-portage-dev] [PATCH] repoman: Finally deprecate base.eclass

2015-10-11 Thread Zac Medico
On 10/11/2015 12:23 PM, Zac Medico wrote: > On 10/11/2015 09:51 AM, Alexander Berntsen wrote: >> On 11/10/15 18:45, Michał Górny wrote: >>> Nope, don't have any. Though AFAICS there's all-over-the-place >>> consensus that it's deprecated, and most of the developers

Re: [gentoo-portage-dev] Team leader(s) election meeting

2015-10-10 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2015 10:22 AM, Brian Dolbec wrote: > On Thu, 1 Oct 2015 16:24:20 +0200 Alexander Berntsen > wrote: > >>> On 01/10/15 16:19, Brian Dolbec wrote: Now for my re-election >>> platform / campaign speech ;) >> Mine is far

[gentoo-portage-dev] [PATCH] SyncRepos.async: group sync and callback as composite task (bug 562264)

2015-10-05 Thread Zac Medico
Group together the sync operation and the callback as a single task, so that the callback will not execute concurrently with another sync operation for --jobs=1. X-Gentoo-Bug: 562264 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=562264 --- pym/portage/sync/controller.py | 39

[gentoo-portage-dev] [PATCH] repoman: suppress dependency.badmasked triggered by use.force and use.mask

2015-10-04 Thread Zac Medico
Add 'minimum-all-ignore-profile' mode to portbapi.xmatch, and use it to ignore interactions between USE deps, use.force, and use.mask. --- pym/portage/dbapi/__init__.py | 23 --- pym/portage/dbapi/porttree.py | 18 +++--- pym/repoman/scanner.py| 2 +- 3

Re: [gentoo-portage-dev] [PATCH] repoman: Add file encoding sheband for py-2.7 compatibility

2015-10-03 Thread Zac Medico
On 10/03/2015 09:08 AM, Brian Dolbec wrote: > From 841660a8064012b734b5c62e1c1e3e1132403d5c Mon Sep 17 00:00:00 2001 > From: Brian Dolbec > Date: Sat, 3 Oct 2015 08:57:55 -0700 > Subject: [PATCH] repoman: Add file encoding sheband for py-2.7 compatibility > (bug 562108) > >

[gentoo-portage-dev] [PATCH v4] unpack: use chmod-lite helper for bug 554084

2015-10-03 Thread Zac Medico
Use the apply_recursive_permissions function to minimize the number of chmod calls. Also, fix an UnboundLocalError triggered in portage.data._get_global by chmod-lite. X-Gentoo-Bug: 554084 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=554084 --- [PATCH v4] adds backward compatibility

Re: [gentoo-portage-dev] [PATCH] repoman/argparser.py: _unicode_decode the commitmsg (bug 562108)

2015-10-03 Thread Zac Medico
On 10/03/2015 10:34 AM, Brian Dolbec wrote: > From 87ff1532e65e64c86fa80437944bda223aff3d93 Mon Sep 17 00:00:00 2001 > From: Brian Dolbec > Date: Sat, 3 Oct 2015 10:14:11 -0700 > Subject: [PATCH] repoman/argparser.py: _unicode_decode the commitmsg (bug > 562108) > > Force

[gentoo-portage-dev] [PATCH] dohtml: handle unicode (bug 561846)

2015-10-03 Thread Zac Medico
Decode all arguments and listdir results as UTF-8, and return unsuccessfully if anything fails to decode as UTF-8. Use portage os and shutil wrappers to encode file names as UTF-8 regardless of locale. X-Gentoo-Bug: 561846 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=561846 ---

[gentoo-portage-dev] [PATCH v3] unpack: use chmod-lite helper for bug 554084

2015-10-02 Thread Zac Medico
Use the apply_recursive_permissions function to minimize the number of chmod calls. Also, fix an UnboundLocalError triggered in portage.data._get_global by chmod-lite. X-Gentoo-Bug: 554084 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=554084 --- [PATCH v3] fixes

[gentoo-portage-dev] [PATCH v2] unpack: use chmod-lite helper for bug 554084

2015-10-02 Thread Zac Medico
Use the apply_recursive_permissions function to minimize the number of chmod calls. Also, fix an UnboundLocalError triggered in portage.data._get_global by chmod-lite. X-Gentoo-Bug: 554084 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=554084 --- [PATCH v2] fixes

[gentoo-portage-dev] Re: [PATCH] unpack: use chmod-lite helper for bug 554084

2015-10-02 Thread Zac Medico
On Fri, Oct 2, 2015 at 12:22 AM, Zac Medico <zmed...@gentoo.org> wrote: > Use the apply_recursive_permissions function to minimize the number of > chmod calls. Actually, apply_recursive_permissions fails with www-apache/mod_auth_token-1.0.6_beta, so it needs some work.

[gentoo-portage-dev] [PATCH] checksum._open_file: fix BytesWarning

2015-10-01 Thread Zac Medico
Fix the following warning message: pym/portage/checksum.py:25: BytesWarning: str() on a bytes instance func_call = "open('%s')" % filename --- pym/portage/checksum.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py index

Re: [gentoo-portage-dev] [PATCH] Revert "unpack: avoid useless chmods to improve speed"

2015-09-28 Thread Zac Medico
On 09/27/2015 06:24 AM, Mike Gilbert wrote: > This reverts commit 0dc7b2a3923508896cf217f325b8339d73353553. > > The "optimized" chmod is no longer recursive, which causes files to be > missed. > > X-Gentoo-Bug: 561368 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=561368 > --- >

[gentoo-portage-dev] [PATCH] SyncManager.async: initialize attributes before fork (bug 561234)

2015-09-23 Thread Zac Medico
Since commit 496ff326dc18890889d1ea5d2aec590394635960, the pre_sync method executes in a forked child process. Therefore, initialize attributes before the fork (in the async method). Fixes: 496ff326dc18 ("sync repositories in parallel (bug 557426)") X-Gentoo-Bug: 561234 X-Gentoo-Bug-url:

[gentoo-portage-dev] [PATCH v2] SyncManager.async: initialize attributes before fork (bug 561234)

2015-09-23 Thread Zac Medico
Since commit 496ff326dc18890889d1ea5d2aec590394635960, the pre_sync method executes in a forked child process. Therefore, initialize attributes before the fork (in the async method). Fixes: 496ff326dc18 ("sync repositories in parallel (bug 557426)") X-Gentoo-Bug: 561234 X-Gentoo-Bug-url:

Re: [gentoo-portage-dev] [PATCH v2] SyncManager.async: initialize attributes before fork (bug 561234)

2015-09-23 Thread Zac Medico
On 09/23/2015 02:58 PM, Brian Dolbec wrote: > OK, looks good Thanks. > > I suppose we'll need to do another release soon, but how long should we > wait...(new repoman code) or should we just patch 2.2.21 Well, you ran repoman on the whole tree and compared the output to the old version, right?

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Update description of =* operator.

2015-09-22 Thread Zac Medico
On 09/22/2015 12:15 AM, Ulrich Müller wrote: > After commit d4966a381ee4577818bd972946647338046715b1 > "match_from_list: restrict =* to match only on version part > boundaries" the description of the =* operator in ebuild(5) was > no longer accurate. > > This reverts commit

Re: [gentoo-portage-dev] Portage questions

2015-09-21 Thread Zac Medico
On 09/21/2015 06:45 AM, Joakim Tjernlund wrote: > On Sun, 2015-09-20 at 09:47 -0700, Zac Medico wrote: >> On 09/16/2015 06:13 AM, Joakim Tjernlund wrote: >>> 1) >>> Is there a way to generate a snapshot of an installed portage VDB and >>> then later

Re: [gentoo-portage-dev] Portage questions

2015-09-20 Thread Zac Medico
On 09/16/2015 06:13 AM, Joakim Tjernlund wrote: > 1) > Is there a way to generate a snapshot of an installed portage VDB and then > later > compare that snapshot against the current VDB and generate a list of > added/updated packages? This command will generate a flat file that is useful

[gentoo-portage-dev] [PATCH] match_from_list: restrict =* to match only on version part boundaries (bug 560466)

2015-09-20 Thread Zac Medico
Make the =* glob match only on boundaries between version parts, in order to eliminate ambiguity (so that 1* does not match version 10). Only break compatibility in cases where dependencies have been specified ambiguously. X-Gentoo-Bug: 560466 X-Gentoo-Bug-url:

<    8   9   10   11   12   13   14   15   16   17   >