Re: [gentoo-portage-dev] [PATCH] _writer: fix unsafe finally clause (bug 728580)

2020-06-18 Thread Zac Medico
On 6/18/20 7:13 AM, Brian Dolbec wrote: > On Thu, 18 Jun 2020 00:35:48 -0700 > Zac Medico wrote: > >> In the coroutine finally clause, do not call remove_writer in cases >> where fd has been closed and then re-allocated to a concurrent >> coroutine as in bug 716636. >> >> Also, assume that the

Re: [gentoo-portage-dev] [PATCH] _writer: fix unsafe finally clause (bug 728580)

2020-06-18 Thread Brian Dolbec
On Thu, 18 Jun 2020 00:35:48 -0700 Zac Medico wrote: > In the coroutine finally clause, do not call remove_writer in cases > where fd has been closed and then re-allocated to a concurrent > coroutine as in bug 716636. > > Also, assume that the caller will put the file in non-blocking mode > and

[gentoo-portage-dev] [PATCH] _writer: fix unsafe finally clause (bug 728580)

2020-06-18 Thread Zac Medico
In the coroutine finally clause, do not call remove_writer in cases where fd has been closed and then re-allocated to a concurrent coroutine as in bug 716636. Also, assume that the caller will put the file in non-blocking mode and close the file when done, so that this function is suitable for