Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

On 05/08/2018 08:55 AM, Alec Warner wrote: > lgtm. > > -A > > On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec > wrote: > > On Mon,  7 May 2018 03:18:32 -0700 > Zac Medico > wrote: > > > +   

Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

lgtm. -A On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec wrote: > On Mon, 7 May 2018 03:18:32 -0700 > Zac Medico wrote: > > > + # This attribute it used by _wrap_loop to detect if > > the > > typo, s/it/is > > this asynio stuff is mostly

Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

On Mon, 7 May 2018 03:18:32 -0700 Zac Medico wrote: > + # This attribute it used by _wrap_loop to detect if > the typo, s/it/is this asynio stuff is mostly beyond my familiarity... but all looks ok, and I know you ran the tests on it... should be good to

[gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

For python3.4 and later, in the main process, replace portage's internal event loop with the standard library's asyncio event loop. Continue to use portage's internal event loop in subprocesses, since asyncio's event loop is not guaranteed to work well in subprocesses (see upstream python issues