Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-14 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 13/08/15 20:36, Zac Medico wrote: > How's this future tense version? I greatly prefer patches in the imperative mood. "Add stuff. Do other stuff. Fix more stuff." But that's arguably a style preference. Your future tense version is unambiguous, an

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Brian Dolbec
On Thu, 13 Aug 2015 11:36:58 -0700 Zac Medico wrote: > On 08/13/2015 02:06 AM, Alexander Berntsen wrote: > > Superficially it looks OK, except a few minor details. > > > > On 13/08/15 10:34, Zac Medico wrote: > >> Repos are synced in parallel (includes their post-sync hooks). > >> Output of con

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Brian Dolbec
Hell with it, top posting this one ;) Thanks, questions answered :) On Thu, 13 Aug 2015 12:00:46 -0700 Zac Medico wrote: > On 08/13/2015 07:29 AM, Brian Dolbec wrote: > > On Thu, 13 Aug 2015 01:34:36 -0700 > > Zac Medico wrote: > >> + def _task_exit(self, task): > >> + ''' > >> +

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Zac Medico
On 08/13/2015 07:29 AM, Brian Dolbec wrote: > On Thu, 13 Aug 2015 01:34:36 -0700 > Zac Medico wrote: >> +def _task_exit(self, task): >> +''' >> +Remove the task from the graph, in order to expose >> +more leaf nodes. >> +''' >> +self.

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Zac Medico
On 08/13/2015 02:06 AM, Alexander Berntsen wrote: > Superficially it looks OK, except a few minor details. > > On 13/08/15 10:34, Zac Medico wrote: >> Repos are synced in parallel (includes their post-sync hooks). >> Output of concurrent processes is currently mixed (irrelevant with >> --quiet).

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Brian Dolbec
On Thu, 13 Aug 2015 01:34:36 -0700 Zac Medico wrote: > Repos are synced in parallel (includes their post-sync hooks). Output > of concurrent processes is currently mixed (irrelevant with --quiet). > Support for FEATURES=metadata-transfer is handled in the main process, > which may be required for

Re: [gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Superficially it looks OK, except a few minor details. On 13/08/15 10:34, Zac Medico wrote: > Repos are synced in parallel (includes their post-sync hooks). > Output of concurrent processes is currently mixed (irrelevant with > --quiet). Support f

[gentoo-portage-dev] [PATCH] sync repositories in parallel (bug 557426)

2015-08-13 Thread Zac Medico
Repos are synced in parallel (includes their post-sync hooks). Output of concurrent processes is currently mixed (irrelevant with --quiet). Support for FEATURES=metadata-transfer is handled in the main process, which may be required for some backends (such as sqlite). Repos are synced only after th