Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-21 Thread Tom Wijsman
On Sun, 19 Jan 2014 18:43:46 -0800 Alec Warner anta...@gentoo.org wrote: It is certainly weird (as we discussed on IRC.) I've never seen anyone do it in any codebase I liked. My backlog was limited so I didn't catch that discussion, feel free to share the log; I've since increased it. There's

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-19 Thread Mike Frysinger
On Friday 17 January 2014 18:03:57 Tom Wijsman wrote: --- please shorten your commit summary and move more content to the body +getNonSystemArchiveDepends.archivers = { it is super weird to attach to the object like this. some might even say wrong. move it into the class definition. def

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 6:23 PM, Tom Wijsman tom...@gentoo.org wrote: On Sun, 19 Jan 2014 04:38:31 -0500 Mike Frysinger vap...@gentoo.org wrote: On Friday 17 January 2014 18:03:57 Tom Wijsman wrote: --- please shorten your commit summary and move more content to the body Right, I'm