Jason Stubbs wrote:
> On Saturday 25 February 2006 10:40, Alec Warner wrote:
>
>>Please review for badness, otherwise I'll commit this soon ;)
>
>
> - self.backupenv = os.environ.copy()
> - self.configlist.append(self.backupenv) # XXX Why though?
> - self.configdict["backupenv"]=self.configli
On Sunday 26 February 2006 00:09, Alec Warner wrote:
> Jason Stubbs wrote:
> > - if 0 and match and mykey in ["PORTAGE_BINHOST"]:
> > - # These require HTTP Encoding
> > ...
> >
> > This shouldn't be in a "cleanup" patch either.
> >
>
> Er, may I ask why it's in the code at all? :)
(I cu
Jason Stubbs wrote:
> On Saturday 25 February 2006 10:40, Alec Warner wrote:
>
>>Please review for badness, otherwise I'll commit this soon ;)
>
>
> - self.backupenv = os.environ.copy()
> - self.configlist.append(self.backupenv) # XXX Why though?
> - self.configdict["backupenv"]=self.configli
On Saturday 25 February 2006 10:40, Alec Warner wrote:
> Please review for badness, otherwise I'll commit this soon ;)
- self.backupenv = os.environ.copy()
- self.configlist.append(self.backupenv) # XXX Why though?
- self.configdict["backupenv"]=self.configlist[-1]
+ self.configdict["backupenv
On Saturday 25 February 2006 10:40, Alec Warner wrote:
> Please review for badness, otherwise I'll commit this soon ;)
$ grep "^\-" portage-config-cleanup.patch | wc -l
58
$ grep "^\+" portage-config-cleanup.patch | wc -l
41
The unrelated PORTAGE_BINHOST chunk is -15/+1 which makes the relevant
p
Please review for badness, otherwise I'll commit this soon ;)
--- portage.py 2006-01-15 00:08:06.170717008 -0500
+++ - 2006-01-15 00:22:00.597106000 -0500
@@ -931,17 +931,8 @@
self.use_defs = copy.deepcopy(clone.use_defs)
self.usemask = copy.deepc