Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-15 Thread Zac Medico
On 03/15/2016 12:38 PM, Zac Medico wrote: > On 03/15/2016 12:04 PM, Brian Dolbec wrote: >> On Mon, 14 Mar 2016 18:04:56 -0700 >> Zac Medico wrote: >> >> The only consumer for that allvalid variable is the metadata UnusedCheck class. So the allvalid

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-15 Thread Zac Medico
On 03/15/2016 12:04 PM, Brian Dolbec wrote: > On Mon, 14 Mar 2016 18:04:56 -0700 > Zac Medico wrote: > > >>> The only consumer for that allvalid variable is the metadata >>> UnusedCheck class. >>> >>> So the allvalid variable is True until found False >>> by whichever

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-15 Thread Brian Dolbec
On Mon, 14 Mar 2016 18:04:56 -0700 Zac Medico wrote: > > The only consumer for that allvalid variable is the metadata > > UnusedCheck class. > > > > So the allvalid variable is True until found False > > by whichever checks along the way find it to be False. Like a fuse,

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-15 Thread Zac Medico
On 03/14/2016 06:04 PM, Zac Medico wrote: >> The only consumer for that allvalid variable is the metadata >> UnusedCheck class. >> >> So the allvalid variable is True until found False >> by whichever checks along the way find it to be False. Like a fuse, >> it's good until it's blown, then it

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-14 Thread Zac Medico
On 03/14/2016 05:47 PM, Brian Dolbec wrote: > On Mon, 14 Mar 2016 17:18:27 -0700 > Zac Medico wrote: > >> On 03/14/2016 10:52 AM, Brian Dolbec wrote: >>> On Mon, 14 Mar 2016 10:22:11 -0700 >>> Zac Medico wrote: >>> On 03/14/2016 10:14 AM, Zac

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-14 Thread Brian Dolbec
On Mon, 14 Mar 2016 17:18:27 -0700 Zac Medico wrote: > On 03/14/2016 10:52 AM, Brian Dolbec wrote: > > On Mon, 14 Mar 2016 10:22:11 -0700 > > Zac Medico wrote: > > > >> On 03/14/2016 10:14 AM, Zac Medico wrote: > >>> On 03/05/2016 01:37 PM, Brian

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-14 Thread Brian Dolbec
On Mon, 14 Mar 2016 10:22:11 -0700 Zac Medico wrote: > On 03/14/2016 10:14 AM, Zac Medico wrote: > > On 03/05/2016 01:37 PM, Brian Dolbec wrote: > > > >> Zac, I'm done with code changes in the rewrite. Ready for a last > >> look before a merge. Can you have a look again?

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-03-14 Thread Zac Medico
On 03/14/2016 10:14 AM, Zac Medico wrote: > On 03/05/2016 01:37 PM, Brian Dolbec wrote: > >> Zac, I'm done with code changes in the rewrite. Ready for a last look >> before a merge. Can you have a look again? I did some changes/fixes >> and rebased them in. Floppym hasn't reported any more

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-01-11 Thread Brian Dolbec
On Sun, 10 Jan 2016 14:28:51 -0800 Brian Dolbec wrote: > On Sun, 10 Jan 2016 13:40:08 -0800 > Brian Dolbec wrote: > > >I have now pushed a fully rebased, properly sequenced commit > > history to the repoman branch. To be honest I think all the > >

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-01-11 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I read through these ages ago, and I think you've incorporated my feedback from back then. But like back then, I don't have too much feedback to offer as this is certainly not an area of Portage I'm nearly as familiar with as you are. It mostly just

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-01-10 Thread Brian Dolbec
On Sun, 10 Jan 2016 14:28:51 -0800 Brian Dolbec wrote: > On Sun, 10 Jan 2016 13:40:08 -0800 > Brian Dolbec wrote: > > >I have now pushed a fully rebased, properly sequenced commit > > history to the repoman branch. To be honest I think all the > >

Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete

2016-01-10 Thread Brian Dolbec
On Sun, 10 Jan 2016 13:40:08 -0800 Brian Dolbec wrote: >I have now pushed a fully rebased, properly sequenced commit > history to the repoman branch. To be honest I think all the rebasing, > re-testing took as much time as the initial conversion and testing. > Anyway, I