[gentoo-portage-dev] [PATCH] lib/portage/xml/metadata.py: fix ungrouped-imports w/refactor

2020-08-06 Thread Aaron Bauman
* This drops the import for cElementTree as it is deprecated. See: https://docs.python.org/3/library/xml.etree.elementtree.html * Drop the error checking as these modules are a part of stdlib. * Additionally, the pyexpat issue was fixed in 3.2. See: https://bugs.python.org/issue14988

[gentoo-portage-dev] [PATCH] lib/*: exempt two core files from ungrouped-imports check

2020-08-06 Thread Aaron Bauman
* These will take some time to refactor/address if at all possible. * Turn on ungrouped-imports check for entire repo Signed-off-by: Aaron Bauman --- lib/portage/__init__.py | 1 + lib/portage/checksum.py | 15 --- pylintrc| 1 + 3 files changed, 10 insertions(+),

[gentoo-portage-dev] [PATCH] *: drop all import __future__ statements

2020-08-06 Thread Aaron Bauman
* We only support Py3 now. Signed-off-by: Aaron Bauman --- bin/archive-conf | 4 +-- bin/check-implicit-pointer-usage.py | 2 -- bin/clean_locks | 4 +-- bin/dispatch-conf | 4 +-- bin/dohtml.py

[gentoo-portage-dev] [PATCH] lib/*: Fix ungrouped-imports

2020-08-06 Thread Aaron Bauman
* This fixes ungrouped imports for a portion of the repo. The remaining fixes will come in another batch of atomic commits as the imports are buried behind conditionals, are __futures__ that may be able to go away, etc * Per the above, check will not be enabled yet Signed-off-by: Aaron

Re: [gentoo-portage-dev] [PATCH] *: drop all import __future__ statements

2020-08-06 Thread Zac Medico
On 8/6/20 6:12 PM, Aaron Bauman wrote: > * We only support Py3 now. > > Signed-off-by: Aaron Bauman > --- > bin/archive-conf | 4 +-- > bin/check-implicit-pointer-usage.py | 2 -- > bin/clean_locks | 4 +-- >

Re: [gentoo-portage-dev] [PATCH] lib/*: exempt two core files from ungrouped-imports check

2020-08-06 Thread Zac Medico
On 8/6/20 5:03 PM, Aaron Bauman wrote: > * These will take some time to refactor/address if at all possible. > * Turn on ungrouped-imports check for entire repo > > Signed-off-by: Aaron Bauman > --- > lib/portage/__init__.py | 1 + > lib/portage/checksum.py | 15 --- > pylintrc

Re: [gentoo-portage-dev] [PATCH] lib/*: fix superfluous-parens and enable check

2020-08-06 Thread Zac Medico
On 8/5/20 9:05 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > lib/_emerge/actions.py | 14 +++--- > lib/_emerge/resolver/slot_collision.py | 4 ++-- > lib/_emerge/stdout_spinner.py| 2 +- > lib/_emerge/unmerge.py

Re: [gentoo-portage-dev] [PATCH 6/6] pylintrc: enable multiple-imports check

2020-08-06 Thread Zac Medico
On 8/5/20 4:51 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > pylintrc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pylintrc b/pylintrc > index b7091516c..5f4ec3278 100644 > --- a/pylintrc > +++ b/pylintrc > @@ -19,6 +19,7 @@ enable= > misplaced-future, >