Re: [gentoo-portage-dev] making dodoc and dohtml die when they fail and stricter is on
On Mon, Dec 26, 2005 at 12:54:04AM +0200, Petteri Räty wrote:
Currently there are quite a few ebuilds in the tree that execute dodoc
or dohtml for files that do not exist. I think it would be nice to have
ebuilds die if this is the case. To not break current ebuilds this would
only happen with FEATURES=stricter. This is what I currently do in my
bashrc. Obviously when integreted to portage one can use helper
functions like hasq which are not available in bashrc.
if [[ ${FEATURES/stricter} != ${FEATURES} ]]; then
_makefail() {
bin=/usr/lib/portage/bin/${1}
shift 1
${bin} [EMAIL PROTECTED] || die ${bin} [EMAIL PROTECTED] failed
}
dodoc() { _makefail ${FUNCNAME} [EMAIL PROTECTED]; }
dohtml() {_makefail ${FUNCNAME} [EMAIL PROTECTED]; }
Seems like more of a -dev discussion imo, since they're the ones
affected by it (for us it's just an api change).
~harring
pgpxdjyp8NzBA.pgp
Description: PGP signature
Re: [gentoo-portage-dev] per ebuild distdir symlinking
On Monday 26 December 2005 07:12, Brian Harring wrote: Hola. Continuing the tradition of being a lazy bugger and raiding from my previous work instead of doing something new, attached is a patch that forces unpack to go through a level of indirection. ... Either way, it's attached. Comments? No problems on my part. As Mike said, it'll only catch the standard unpack usage but that's not really an issue as far as I can see. By the way, now that we've got -commit mail, confirming with the ML isn't really necessary. Of course, if it's something you want to confirm... -- Jason Stubbs -- gentoo-portage-dev@gentoo.org mailing list
Re: [gentoo-portage-dev] per ebuild distdir symlinking
On Sun, Dec 25, 2005 at 06:48:02PM -0500, Mike Frysinger wrote:
On Sunday 25 December 2005 17:12, Brian Harring wrote:
Can be defeated by a unpack ${DISTDIR}/file call, but that's invalid
anyways.
and what about things that do `cp ${DISTDIR}/aadsfasdf ${S}/` ? those are
going to fail to wont they ?
Had originally thought about resetting DISTDIR to the symlink dir; it
would address this concern.
Yay/nay on that one?
~harring
pgpumVdqz5mCm.pgp
Description: PGP signature
