Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Mike Frysinger
On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote: > Mike Frysinger wrote: > > On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: > >> The immediate motivation of my examining this code was a request on > >> #gentoo-dev-help by lack for something which I could with my new code >

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Mike Frysinger
On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote: > Zlin found yet another bug. Since echo "" will output a newline my current > proposed implementation of useq won't be quiet. sounds like we should have a testsuite in portage to make sure the misc variants are operating as expected -m

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marijn Schouten (hkBst) wrote: Zlin found yet another bug. Since echo "" will output a newline my current proposed implementation of useq won't be quiet. > _use() { > local flag=$1 > local string_success=$2 > local string_failure=$3 >

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marijn Schouten (hkBst) wrote: > In gambit I used: > > econf $(if use static; then echo --disable-shared; else echo --enable-shared; > fi) \ > > could become: > > econf $(_use static --disable-shared --enable-shared) \ as zlin rightly pointed out o

Re: [gentoo-portage-dev] use* cleanup

2007-11-01 Thread Marijn Schouten (hkBst)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mike Frysinger wrote: > On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote: >> I hope this is just an artifact of the patch being a bit opaque. The >> inconsistent indentation in the patch is a consequence of emacs bash mode >> using a differe