Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wk...@tremily.us wrote: On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: I think the idea is that you shouldn't need to refer to an external resource like the mailing list to understand the idea behind the patch, Either someone

Re: [gentoo-portage-dev] GitHub presence

2014-01-18 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18/01/14 22:52, Robin H. Johnson wrote: You mean like... https://github.com/gentoo/portage This didn't exist back when. I should have done more research though. Thanks. - -- Alexander alexan...@plaimi.net http://plaimi.net/~alexander

[gentoo-portage-dev] [PATCH 3/3] emerge: Make --autounmask=y if --ask=y

2014-01-18 Thread Alexander Berntsen
--- man/emerge.1| 9 + pym/_emerge/depgraph.py | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/man/emerge.1 b/man/emerge.1 index e23d1b4..52f8ed7 100644 --- a/man/emerge.1 +++ b/man/emerge.1 @@ -331,10 +331,11 @@ Write required unmask changes to the

[gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-18 Thread Alexander Berntsen
Rename --autounmask-write to --autounmask. Please note that removing the option does not mean that the variable used for keeping track of autounmask writing is not removed from depgraph.py. --- man/emerge.1| 19 +++ pym/_emerge/depgraph.py | 4 ++--

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out explaining the consensus ;). That is a guess, you can look this up in past patches. You spend time if you want to spend time and add whoever you

[gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869.

2014-01-18 Thread Chris Reffett
v2: Reformat, add a function to return an appropriate read-only checker for the operating system, so that this can be extended to other OSes. v3: minor formatting tweaks from bernalex, including use os.path.join() instead of string concatenation --- pym/portage/dbapi/vartree.py | 32

Re: [gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-18 Thread Mike Gilbert
On Sat, Jan 18, 2014 at 7:21 PM, Alexander Berntsen alexan...@plaimi.net wrote: Rename --autounmask-write to --autounmask. Please note that removing the option does not mean that the variable used for keeping track of autounmask writing is not removed from depgraph.py. Ok, so how do I tell

[gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-18 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. --- pym/portage/package/ebuild/fetch.py | 50

[gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-18 Thread W. Trevor King
I felt like I should actually make a useful contribution to balance the less useful commit-message discussion ;). Browsing through the open Portage bugs, #175612 looked interesting. After I looked at pym/portage/package/ebuild/fetch.py, I decided to take a step back and just try and refactor

[gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-18 Thread W. Trevor King
The current fetch() function is quite long, which makes it hard to know what I can change without adverse side effects. By pulling this logic out of the main function, we get clearer logic in fetch() and more explicit input for the config extraction. This block was especially complicated, so I

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread W. Trevor King
On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out explaining the consensus ;). That is a guess, you can look this up in past