El dom, 19-01-2014 a las 01:21 +0100, Alexander Berntsen escribió:
Remove the --autounmask option from emerge. Please note that removing
the option does not mean that the variable used for keeping track of
autounmasking is not removed from depgraph.py.
If I understand the change correctly (I
On Saturday 18 January 2014 17:57:38 Tom Wijsman wrote:
On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wrote:
On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote:
I think the idea is that you shouldn't need to refer to an external
resource like the mailing list to understand the
On Tuesday 14 January 2014 21:58:38 Tom Wijsman wrote:
On Sun, 05 Jan 2014 15:42:48 -0800 Brian Dolbec wrote:
2) start working on a solution,
a) if you have significant progress, but need more time, mark it
accordingly, assign it to yourself, leave a comment, etc.
Assigning it
On Saturday 18 January 2014 21:00:48 Chris Reffett wrote:
--- /dev/null
+++ b/pym/portage/util/rochecker.py
@@ -0,0 +1,81 @@
+#-*- coding:utf-8 -*-
+# Copyright 2014 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+
+Methods to check whether Portage is
On Saturday 18 January 2014 19:21:11 Alexander Berntsen wrote:
Rename --autounmask-write to --autounmask.
typically when we delete/rename an option, we give users a heads up. that
means a cycle where the old option exists but emits a warning before switching
to the new one. then we can
Acked-by: Mike Frysinger vap...@gentoo.org
btw you should keep the patch summary short. if it goes long, better to move
it to the main body.
-mike
signature.asc
Description: This is a digitally signed message part.
On Wednesday 15 January 2014 19:07:20 Tom Wijsman wrote:
+class DeprecateG2CONF(LineCheck):
+ repoman_check_name = 'G2CONF.deprecated'
+ re = re.compile(r'.*G2CONF.*')
+
+ def check(self, num, line):
+ Run the check on line and return error if there is one
+
btw, suggestion for commit summary/message:
repoman: deprecate G2CONF
Deprecate the G2CONF variable as requested by the GNOME team.
URL: http://bugs.gentoo.org/482084
-mike
signature.asc
Description: This is a digitally signed message part.
On Friday 17 January 2014 18:03:57 Tom Wijsman wrote:
---
please shorten your commit summary and move more content to the body
+getNonSystemArchiveDepends.archivers = {
it is super weird to attach to the object like this. some might even say
wrong. move it into the class definition.
def
On Tuesday 14 January 2014 16:15:48 Tom Wijsman wrote:
On Mon, 13 Jan 2014 23:59:11 -0500 Mike Frysinger wrote:
we probably should just use dev branches in the main repo, at least
for people who have write access to the repo
dev/$USERNAME/whatever you want
To be more clear, which
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 11:23, Alexander Berntsen wrote:
emerge --ask foo # This won't -write emerge --autounmask --pretend
foo # Same as the above
Sorry, the comments here are imprecise. The first-mentioned will
*prompt* the user for writing the changes. The
El dom, 19-01-2014 a las 11:23 +0100, Alexander Berntsen escribió:
On 19/01/14 09:01, Pacho Ramos wrote:
If I understand the change correctly (I don't know much about
python but, but per the diff, looks like you are dropping the
option and making the code behave like it's always 'True'),
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 10:17, Mike Frysinger wrote:
prefer OSes - OS's
That's just not proper English. It makes no sense. Please don't prefer
that. If for nothing else, then to prevent me from sighing whenever I
have to read it.
not a new issue, but we
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 10:20, Mike Frysinger wrote:
typically when we delete/rename an option, we give users a heads
up. that means a cycle where the old option exists but emits a
warning before switching to the new one. then we can delete it.
We should
On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org wrote:
Chromium OS for a long time was restricted to EAPI 4 for two reasons -- it
had an old portage
version (and upgrading to a newer one regressed performance significantly, so
we held off until we could figure out why)
I am
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 17:49, Mike Gilbert wrote:
Please give me a way to shut off autounmask entirely no mater what
other options I pass to emerge. Tying it to --ask with no way to
disable it is not acceptable.
- --autounmask=n should do this. I messed
This was only implemented for the ebuild command before.
---
pym/_emerge/Scheduler.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/Scheduler.py b/pym/_emerge/Scheduler.py
index d663e97..2fd4d7e 100644
--- a/pym/_emerge/Scheduler.py
+++
The removed white space was unintentional. Please remove that change
before committing that patch.
Am 19.01.2014 04:07, schrieb W. Trevor King:
I felt like I should actually make a useful contribution to balance
the less useful commit-message discussion ;). Browsing through the
open Portage bugs, #175612 looked interesting. After I looked at
pym/portage/package/ebuild/fetch.py, I decided
On Sun, Jan 19, 2014 at 09:05:41PM +0100, Sebastian Luther wrote:
Am 19.01.2014 04:07, schrieb W. Trevor King:
The patches aren't particularly well tested yet. I ran the test
suite and got some errors, but they seemed to be related to my
non-root invocation, and not due to these changes
Am 19.01.2014 04:07, schrieb W. Trevor King:
+def _get_uris(uris, settings, custom_mirrors=(), locations=()):
missing doc string
Am 19.01.2014 04:07, schrieb W. Trevor King:
The patches aren't particularly well tested yet. I ran the test suite
and got some errors, but they seemed to be related to my non-root
invocation, and not due to these changes themselves. I thought I'd
post my work so far, before digging deeper
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of the main function, we get clearer logic in fetch() and
more explicit input for the config extraction.
---
pym/portage/package/ebuild/fetch.py | 50
Following Sebastian's pyflakes and testing suggestions turned up a few
bugs in the _get_uris patch. Changes since v1:
Patch #1:
* Fixed:
summary
to:
summary
and converted some from tabs to spaces where I'd missed them in v1.
Patch #3:
* Fixed docstrings as for patch
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of the main function, we get clearer logic in fetch() and
more explicit input for the config extraction.
This block was especially complicated, so I
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of the main function, we get clearer logic in fetch() and
more explicit input for the config extraction.
---
pym/portage/package/ebuild/fetch.py | 59
On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote:
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of the main function, we get clearer logic in fetch() and
more explicit
On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner anta...@gentoo.org wrote:
On Sun, Jan 19, 2014 at 2:14 PM, W. Trevor King wk...@tremily.us wrote:
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 22:22, Sebastian Luther wrote:
The usual doc string style used in portage is:
text
Please use that for new functions. Also make sure you don't use
spaces to indent the last .
As mentioned by Mike in another thread, we should
On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen alexan...@plaimi.netwrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 22:22, Sebastian Luther wrote:
The usual doc string style used in portage is:
text
Please use that for new functions. Also make sure you don't
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:46, Alec Warner wrote:
Does pylint or pyflakes point out if you mess it up?
Not very successfully in my experience.
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG
On Sun, Jan 19, 2014 at 02:45:24PM -0800, Alec Warner wrote:
On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner anta...@gentoo.org wrote:
This function and the next function you wrote are identical. How
about making a single function?
…
def getIntValueFromSettings(settings, key, default):
On Sun, Jan 19, 2014 at 2:50 PM, Alexander Berntsen alexan...@plaimi.netwrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:46, Alec Warner wrote:
Does pylint or pyflakes point out if you mess it up?
Not very successfully in my experience.
I'm very against add a bunch
On Sun, Jan 19, 2014 at 02:36:43PM -0800, Alec Warner wrote:
On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote:
+def _get_file_uri_tuples(uris):
+ Return a list of (filename, uri) tuples
+
As mike noted on another thread:
Return a list of (filename,
On Sun, Jan 19, 2014 at 03:06:29PM -0800, W. Trevor King wrote:
On Sun, Jan 19, 2014 at 02:36:43PM -0800, Alec Warner wrote:
On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wk...@tremily.us wrote:
+ # Order primaryuri_dict values to match that in SRC_URI.
+ for uris in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:54, Alec Warner wrote:
I'm very against add a bunch of extra rules that have to be
enforced by hand. I want to make it easy to contribute, not more
difficult. If bob can run a tool that tells him all the things
that are wrong
On Sun, Jan 19, 2014 at 3:51 PM, Alexander Berntsen alexan...@plaimi.netwrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:54, Alec Warner wrote:
I'm very against add a bunch of extra rules that have to be
enforced by hand. I want to make it easy to contribute, not more
On Sat, 18 Jan 2014 19:07:45 -0800
W. Trevor King wk...@tremily.us wrote:
[...SNIP...]
+ v =
int(settings.get(PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS,
+ default))
+ except (ValueError, OverflowError):
+ writemsg(_(!!! Variable
On Sat, 18 Jan 2014 19:07:46 -0800
W. Trevor King wk...@tremily.us wrote:
+def _get_fetch_resume_size(settings, default='350K'):
+ v = settings.get(PORTAGE_FETCH_RESUME_MIN_SIZE)
+ if v is not None:
+ v = .join(v.split())
+ if not v:
+ #
On Mon, Jan 20, 2014 at 02:26:59AM +0100, Tom Wijsman wrote:
On Sat, 18 Jan 2014 19:07:45 -0800
W. Trevor King wk...@tremily.us wrote:
[...SNIP...]
+ v =
int(settings.get(PORTAGE_FETCH_CHECKSUM_TRY_MIRRORS,
+ default))
…
The code screams
On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote:
There is some duplicate code here, I think the conditions can be
rewritten in such way that the duplicate code doesn't take place.
Do you want a rewrite squashed into this commit, or as a follow-on
commit after this one (which gets a
On Sat, 18 Jan 2014 20:15:57 -0800
W. Trevor King wk...@tremily.us wrote:
On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote:
On Sat, 18 Jan 2014 15:24:59 -0800
W. Trevor King wk...@tremily.us wrote:
If it doesn't need to get updated, then it probably already
started out
On Sun, 19 Jan 2014 18:01:23 -0800
W. Trevor King wk...@tremily.us wrote:
On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote:
There is some duplicate code here, I think the conditions can be
rewritten in such way that the duplicate code doesn't take place.
Do you want a rewrite
On Mon, Jan 20, 2014 at 03:09:14AM +0100, Tom Wijsman wrote:
On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wrote:
On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote:
On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wrote:
If it doesn't need to get updated, then it probably
On Sun, Jan 19, 2014 at 6:23 PM, Tom Wijsman tom...@gentoo.org wrote:
On Sun, 19 Jan 2014 04:38:31 -0500
Mike Frysinger vap...@gentoo.org wrote:
On Friday 17 January 2014 18:03:57 Tom Wijsman wrote:
---
please shorten your commit summary and move more content to the body
Right, I'm
The current fetch() function is quite long, which makes it hard to
know what I can change without adverse side effects. By pulling this
logic out of the main function, we get clearer logic in fetch() and
more explicit input for the config extraction.
Following a suggestion by Tom Wijsman, I put
Make this easier to read by avoiding nested conditionals [1].
[1]: http://article.gmane.org/gmane.linux.gentoo.portage.devel/4058
Reported-by: Tom Wijsman tom...@gentoo.org
---
pym/portage/package/ebuild/fetch.py | 30 ++
1 file changed, 14 insertions(+), 16
On Sunday 19 January 2014 05:48:33 Alexander Berntsen wrote:
On 19/01/14 10:20, Mike Frysinger wrote:
typically when we delete/rename an option, we give users a heads
up. that means a cycle where the old option exists but emits a
warning before switching to the new one. then we can delete
On Sunday 19 January 2014 11:59:36 Mike Gilbert wrote:
On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org wrote:
Chromium OS for a long time was restricted to EAPI 4 for two reasons --
it had an old portage version (and upgrading to a newer one regressed
performance
On Sun, Jan 19, 2014 at 9:47 PM, Mike Frysinger vap...@gentoo.org wrote:
On Sunday 19 January 2014 11:59:36 Mike Gilbert wrote:
On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger vap...@gentoo.org
wrote:
Chromium OS for a long time was restricted to EAPI 4 for two reasons --
it had an old
On Monday 20 January 2014 01:02:31 Alec Warner wrote:
Are you still doing crazy crap like disabling all of the portage locking?
;p
yes no. we make sure we hold the right locks and don't do operations that
otherwise cause problems. then we disable the core lock grabbing :P.
the current
51 matches
Mail list logo
