Re: [gentoo-portage-dev] [PATCH v2 2/2] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-03-30 Thread Brian Dolbec
On Sun, 30 Mar 2014 18:24:23 -0700 Pavel Kazakov wrote: > --- > pym/portage/emaint/main.py| 6 +- > pym/portage/emaint/modules/merges/__init__.py | 30 +++ > pym/portage/emaint/modules/merges/merges.py | 290 > ++ 3 files changed, 324 insertions(+)

Re: [gentoo-portage-dev] [PATCH v2 1/2] Move -MERGING- string to a constant.

2014-03-30 Thread Brian Dolbec
On Sun, 30 Mar 2014 18:24:22 -0700 Pavel Kazakov wrote: > Remove extra whitespace. > --- > pym/portage/const.py | 1 + > pym/portage/dbapi/__init__.py | 4 +++- > pym/portage/dbapi/vartree.py | 8 > 3 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/pym/portage

[gentoo-portage-dev] [PATCH v2 2/2] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-03-30 Thread Pavel Kazakov
--- pym/portage/emaint/main.py| 6 +- pym/portage/emaint/modules/merges/__init__.py | 30 +++ pym/portage/emaint/modules/merges/merges.py | 290 ++ 3 files changed, 324 insertions(+), 2 deletions(-) create mode 100644 pym/portage/emaint/modules/mer

[gentoo-portage-dev] [PATCH v2 1/2] Move -MERGING- string to a constant.

2014-03-30 Thread Pavel Kazakov
Remove extra whitespace. --- pym/portage/const.py | 1 + pym/portage/dbapi/__init__.py | 4 +++- pym/portage/dbapi/vartree.py | 8 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/pym/portage/const.py b/pym/portage/const.py index 1785bff..50f0719 100644 --- a/pym/p

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Alec Warner
On Sun, Mar 30, 2014 at 12:56 AM, Michał Górny wrote: > Dnia 2014-03-30, o godz. 00:03:02 > Alexander Berntsen napisał(a): > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Please use a max 50 char commit message headline, without the period. > > > > On 29/03/14 19:45, Michał Gór

Re: [gentoo-portage-dev] [PATCH] Sort repoman check results in output

2014-03-30 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Prefer "repoman: Sort check results in output" as a message, as per the new guidelines in DEVELOPING. The patch is simple enough. ACK. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: Gn

[gentoo-portage-dev] [PATCH] Sort repoman check results in output

2014-03-30 Thread Michał Górny
Currently, the check results are output in dict order which is implementation-defined. This makes it hard to compare results coming from two machines (Python versions). Instead, sort all the results lexically. --- pym/repoman/utilities.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Brian Dolbec
On Sun, 30 Mar 2014 09:56:11 +0200 Michał Górny wrote: > Dnia 2014-03-30, o godz. 00:03:02 > Alexander Berntsen napisał(a): > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Please use a max 50 char commit message headline, without the > > period. > > > > On 29/03/14 19:45, Mi

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Michał Górny
Dnia 2014-03-30, o godz. 00:03:02 Alexander Berntsen napisał(a): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Please use a max 50 char commit message headline, without the period. > > On 29/03/14 19:45, Michał Górny wrote: > > +import locale +import math > Why not explicitly import w

Re: [gentoo-portage-dev] [PATCH 2/2] emerge: call setlocale() to enable system locale.

2014-03-30 Thread Michał Górny
Dnia 2014-03-30, o godz. 00:04:17 Alexander Berntsen napisał(a): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Please remove the period from the commit message. I would prefer if > you used an explicit import here as well. Explicit as in: from locale import setlocale, LC_ALL ? --