Re: [gentoo-portage-dev] [PATCH] per package environment: generalize the mechanism to be profile specific

2014-09-18 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 For future reference, please use git's send-email option with - --in-reply-to, to send the patches inline. The way they are sent now, (I assume) most of us have to download your patches and open them in a text viewer to review it. If the patches

Re: [gentoo-portage-dev] [PATCH] per package environment: generalize the mechanism to be profile specific

2014-09-18 Thread Michał Górny
Dnia 2014-09-17, o godz. 14:57:10 Bertrand Simonnet bsimon...@google.com napisał(a): I'd rather use the env/ mechanism instead of the package.env one as it is more flexible. It depends on what you aim to do. As portage(5) points out, both have their advantages: - package.env is parsed early,

Re: [gentoo-portage-dev] [PATCH] per package environment: generalize the mechanism to be profile specific

2014-09-18 Thread Bertrand Simonnet
For my purpose, I think bash scripting would be more useful. I thought about package.env in the beginning (see first few messages on this thread) as it would help us reuse code but variable setting only will limit what we can do. If you want package.env, we can implement it too and have both

[gentoo-portage-dev] [PATCH] _backtrack_depgraph: fix bug #523048

2014-09-18 Thread Zac Medico
This fixes _backtrack_depgraph to immediately report necessary REQUIRED_USE changes instead of discarding the graph. This is accomplished by replacing the depgraph.success_without_autounmask method with a new need_config_change method that accounts for both autounmask and REQUIRED_USE changes.

[gentoo-portage-dev] Re: [PATCH] _backtrack_depgraph: fix bug #523048

2014-09-18 Thread Zac Medico
On 09/18/2014 11:46 AM, Zac Medico wrote: This fixes _backtrack_depgraph to immediately report necessary REQUIRED_USE changes instead of discarding the graph. This is accomplished by replacing the depgraph.success_without_autounmask method with a new need_config_change method that accounts for

Re: [gentoo-portage-dev] [PATCH] _backtrack_depgraph: fix bug #523048

2014-09-18 Thread Brian Dolbec
On Thu, 18 Sep 2014 11:46:55 -0700 Zac Medico zmed...@gentoo.org wrote: This fixes _backtrack_depgraph to immediately report necessary REQUIRED_USE changes instead of discarding the graph. This is accomplished by replacing the depgraph.success_without_autounmask method with a new

[gentoo-portage-dev] _solve_..slot_conflicts: fix bug #522084

2014-09-18 Thread Zac Medico
From 963efa6fcf1e61d836d5292c88500a7c032cf46e Mon Sep 17 00:00:00 2001 From: Zac Medico zmed...@gentoo.org Date: Thu, 18 Sep 2014 16:16:13 -0700 Subject: [PATCH] _solve_..slot_conflicts: fix bug #522084 Fix _solve_non_slot_operator_slot_conflicts to add all parents to the conflict_graph, even for