[gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries

[Michał Górny]

Remove the code skipping EAPI=0 output in cache entries. There is really
no reason to treat EAPI=0 specially here, and this makes the output more
consistent.
---
 bin/egencache | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bin/egencache b/bin/egencache
index 6075ccf..5c00248 100755
--- a/bin/egencache
+++ b/bin/egencache
@@ -297,8 +297,6 @@ class GenCache(object):
# EAPI from _parse_eapi_ebuild_head, we don't write cache
# entries for unsupported EAPIs.
if metadata is not None and eapi_supported:
-   if metadata.get('EAPI') == '0':
-   del metadata['EAPI']
for trg_cache in self._trg_caches:
self._write_cache(trg_cache,
cpv, repo_path, metadata, ebuild_hash)
-- 
2.5.0

Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries

[Zac Medico]

On 08/11/2015 10:38 AM, Michał Górny wrote:
 Remove the code skipping EAPI=0 output in cache entries. There is really
 no reason to treat EAPI=0 specially here, and this makes the output more
 consistent.
 ---
  bin/egencache | 2 --
  1 file changed, 2 deletions(-)
 
 diff --git a/bin/egencache b/bin/egencache
 index 6075ccf..5c00248 100755
 --- a/bin/egencache
 +++ b/bin/egencache
 @@ -297,8 +297,6 @@ class GenCache(object):
   # EAPI from _parse_eapi_ebuild_head, we don't write cache
   # entries for unsupported EAPIs.
   if metadata is not None and eapi_supported:
 - if metadata.get('EAPI') == '0':
 - del metadata['EAPI']
   for trg_cache in self._trg_caches:
   self._write_cache(trg_cache,
   cpv, repo_path, metadata, ebuild_hash)
 

LTGM.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] egencache: Always output EAPI=0 in cache entries

[Brian Dolbec]

On Tue, 11 Aug 2015 10:54:10 -0700
Zac Medico zmed...@gentoo.org wrote:

 On 08/11/2015 10:38 AM, Michał Górny wrote:
  Remove the code skipping EAPI=0 output in cache entries. There is
  really no reason to treat EAPI=0 specially here, and this makes the
  output more consistent.
  ---
   bin/egencache | 2 --
   1 file changed, 2 deletions(-)
  
  diff --git a/bin/egencache b/bin/egencache
  index 6075ccf..5c00248 100755
  --- a/bin/egencache
  +++ b/bin/egencache
  @@ -297,8 +297,6 @@ class GenCache(object):
  # EAPI from _parse_eapi_ebuild_head, we don't
  write cache # entries for unsupported EAPIs.
  if metadata is not None and eapi_supported:
  -   if metadata.get('EAPI') == '0':
  -   del metadata['EAPI']
  for trg_cache in self._trg_caches:
  self._write_cache(trg_cache,
  cpv, repo_path, metadata,
  ebuild_hash)
  
 
 LTGM.

yeah, merge please

-- 
Brian Dolbec dolsen