Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)

2016-04-18 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 18/04/16 22:14, Adam Mills wrote: > Thanks for all the feedback so far. I probably should have just > filed the bug and left it at that, but I'm committed now. It's great that you're trying to get a patch into the project! By incorporating Zac's f

Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)

2016-04-18 Thread Zac Medico
On 04/18/2016 01:14 PM, Adam Mills wrote: > Thanks for all the feedback so far. I probably should have just filed > the bug > and left it at that, but I'm committed now. > > I've done my best to incorporate all of the suggestions here, and > submitted a > new patch rev 3. I have a few questions ab

Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)

2016-04-18 Thread Adam Mills
Thanks for all the feedback so far. I probably should have just filed the bug and left it at that, but I'm committed now. I've done my best to incorporate all of the suggestions here, and submitted a new patch rev 3. I have a few questions about details I'm pretty sure still need improvement:

[gentoo-portage-dev] [PATCH v3] Colorize packages in user sets (bug 577720)

2016-04-18 Thread Adam Mills
Three new settings were added to /etc/portage/color.map: PKG_MERGE_USER_SET, PKG_BINARY_MERGE_USER_SET, and PKG_NOMERGE_USER_SET. These colors are applied when the package is selected from a set in /etc/portage/sets/ X-Gentoo-bug: 577720 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=57

Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)

2016-04-18 Thread Zac Medico
On 04/17/2016 11:24 PM, Alexander Berntsen wrote: > On 20/03/16 15:33, Adam Mills wrote: >> +def isUserSet(self): + return False + > Furthermore, this makes no sense and needs to go. Taking the world_candidate attribute as an example, this could be a boolean attribute that's set in th