-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 18/05/16 21:06, Zac Medico wrote:
> Because this code searches for items which do NOT match the
> pattern, which is why the existing code uses a != operator.
OFC. Maybe I should just do this tomorrow... Thank you for being
patient.
- --
Alexand
On 05/18/2016 11:57 AM, Doug Goldstein wrote:
> On 5/18/16 11:38 AM, Zac Medico wrote:
>> On Tue, May 17, 2016 at 11:43 PM, Alexander Berntsen
>> wrote:
>>> -BEGIN PGP SIGNED MESSAGE-
>>> Hash: SHA512
>>>
>>> On 17/05/16 15:36, Doug Goldstein wrote:
ping? I believe I covered all the r
On 05/18/2016 10:04 AM, Alexander Berntsen wrote:
> On 18/05/16 17:46, Zac Medico wrote:
>> not fnmatch.fnmatch(format_match.group(1), '1.*')):
> Wait, why "not"?
Because this code searches for items which do NOT match the pattern,
which is why the existing code uses a != operator.
--
Thanks,
Zac
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 18/05/16 17:46, Zac Medico wrote:
> not fnmatch.fnmatch(format_match.group(1), '1.*')):
Wait, why "not"?
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iQIcBAEBCgAGBQJXPKC
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 18/05/16 17:46, Zac Medico wrote:
> if (format_match is not None and not
> fnmatch.fnmatch(format_match.group(1), '1.*')):
Yes! Sorry! I had made that change, but then forgotten to stage it. So
sorry. It's been hell of a day, so it just slipped pa
On Tue, May 17, 2016 at 11:43 PM, Alexander Berntsen
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 17/05/16 15:36, Doug Goldstein wrote:
>> ping? I believe I covered all the review items but I see this is
>> not in master yet. Is there anything further you need me to do?
> It s
On 05/18/2016 01:36 AM, Alexander Berntsen wrote:
> Only check the major version of news items, as GLEP 42 specifies an
> upgrade path for them. Future revisions to news item formats may yield
> minor number increments. GLEP 42 further ensures that only
> forwards-compatible changes may incur, as i
On 5/18/16 10:51 AM, Anthony G. Basile wrote:
> On 5/18/16 10:26 AM, Brian Dolbec wrote:
>> On Wed, 18 May 2016 06:08:20 -0400
>> "Anthony G. Basile" wrote:
>>
>>> On 5/18/16 2:50 AM, Alexander Berntsen wrote:
On 17/05/16 14:47, Anthony G. Basile wrote:
> Since this is the first python
On 5/18/16 10:26 AM, Brian Dolbec wrote:
> On Wed, 18 May 2016 06:08:20 -0400
> "Anthony G. Basile" wrote:
>
>> On 5/18/16 2:50 AM, Alexander Berntsen wrote:
>>> On 17/05/16 14:47, Anthony G. Basile wrote:
Since this is the first python module written in C included in
portage, as a si
On 5/17/16 9:38 AM, Brian Dolbec wrote:
>
> Overall I like it, but I'll let others review the actual code
> implementation since I'm not an experienced "C" coder. In 30
> years, I never did more than hello world a few times in C. And the
> pascal coding I did in College is more like python than c
On Wed, 18 May 2016 06:08:20 -0400
"Anthony G. Basile" wrote:
> On 5/18/16 2:50 AM, Alexander Berntsen wrote:
> > On 17/05/16 14:47, Anthony G. Basile wrote:
> >> Since this is the first python module written in C included in
> >> portage, as a side effect, we introduce the machinary for future
On 5/18/16 2:50 AM, Alexander Berntsen wrote:
> On 17/05/16 14:47, Anthony G. Basile wrote:
>> Since this is the first python module written in C included in
>> portage, as a side effect, we introduce the machinary for future
>> modules in setup.py.
> Split it into two commits.
>
Read the code, yo
Only check the major version of news items, as GLEP 42 specifies an
upgrade path for them. Future revisions to news item formats may yield
minor number increments. GLEP 42 further ensures that only
forwards-compatible changes may incur, as incompatible changes demand a
major version increment.
Sug
13 matches
Mail list logo
