Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

[Michael Orlitzky]

On 02/01/2017 04:03 PM, Michał Górny wrote:
>>  SLOT="0"
>> -IUSE="build doc epydoc +ipc linguas_ru selinux xattr"
>> +IUSE="build doc epydoc +ipc linguas_ru native-extensions selinux
>> xattr"
> 
> Wouldn't it be better to enable it by default?
> 

Please don't enshrine personal preferences into IUSE defaults unless
they're critical to the package.

Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

[Zac Medico]

On 02/01/2017 01:03 PM, Michał Górny wrote:
> W dniu 01.02.2017, śro o godzinie 09∶06 -0800, użytkownik Zac Medico
> napisał:
>> The native-extensions USE flag will enable building of the
>> libc bindings. This is not enabled by default because it does
>> not support cross compilation.
>>
>> X-Gentoo-bug: 571444
>> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=571444
>> ---
>>  sys-apps/portage/metadata.xml| 1 +
>>  sys-apps/portage/portage-.ebuild | 7 ++-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/sys-apps/portage/metadata.xml b/sys-
>> apps/portage/metadata.xml
>> index e032ea5..882d3ba 100644
>> --- a/sys-apps/portage/metadata.xml
>> +++ b/sys-apps/portage/metadata.xml
>> @@ -12,6 +12,7 @@
>>
>>  Build html API documentation with
>> epydoc.
>>  Use inter-process communication between portage
>> and running ebuilds.
>> +Build native extensions. Cross-
>> compilation is not supported.
>>  Preserve extended attributes (filesystem-
>> stored metadata) when installing files. Usually only required for
>> hardened systems.
>>
>>  
>> diff --git a/sys-apps/portage/portage-.ebuild b/sys-
>> apps/portage/portage-.ebuild
>> index 6a6f515..981db26 100644
>> --- a/sys-apps/portage/portage-.ebuild
>> +++ b/sys-apps/portage/portage-.ebuild
>> @@ -19,7 +19,7 @@ HOMEPAGE="https://wiki.gentoo.org/wiki/Project:Porta
>> ge"
>>  LICENSE="GPL-2"
>>  KEYWORDS=""
>>  SLOT="0"
>> -IUSE="build doc epydoc +ipc linguas_ru selinux xattr"
>> +IUSE="build doc epydoc +ipc linguas_ru native-extensions selinux
>> xattr"
> 
> Wouldn't it be better to enable it by default?

Yeah, that should be fine. We may get a few duplicates of bug 594744
reported, but that's no reason not to enable it by default.
-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

[Michał Górny]

W dniu 01.02.2017, śro o godzinie 09∶06 -0800, użytkownik Zac Medico
napisał:
> The native-extensions USE flag will enable building of the
> libc bindings. This is not enabled by default because it does
> not support cross compilation.
> 
> X-Gentoo-bug: 571444
> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=571444
> ---
>  sys-apps/portage/metadata.xml| 1 +
>  sys-apps/portage/portage-.ebuild | 7 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/sys-apps/portage/metadata.xml b/sys-
> apps/portage/metadata.xml
> index e032ea5..882d3ba 100644
> --- a/sys-apps/portage/metadata.xml
> +++ b/sys-apps/portage/metadata.xml
> @@ -12,6 +12,7 @@
>    
>  Build html API documentation with
> epydoc.
>  Use inter-process communication between portage
> and running ebuilds.
> +Build native extensions. Cross-
> compilation is not supported.
>  Preserve extended attributes (filesystem-
> stored metadata) when installing files. Usually only required for
> hardened systems.
>    
>  
> diff --git a/sys-apps/portage/portage-.ebuild b/sys-
> apps/portage/portage-.ebuild
> index 6a6f515..981db26 100644
> --- a/sys-apps/portage/portage-.ebuild
> +++ b/sys-apps/portage/portage-.ebuild
> @@ -19,7 +19,7 @@ HOMEPAGE="https://wiki.gentoo.org/wiki/Project:Porta
> ge"
>  LICENSE="GPL-2"
>  KEYWORDS=""
>  SLOT="0"
> -IUSE="build doc epydoc +ipc linguas_ru selinux xattr"
> +IUSE="build doc epydoc +ipc linguas_ru native-extensions selinux
> xattr"

Wouldn't it be better to enable it by default?

>  
>  DEPEND="!build? ( $(python_gen_impl_dep 'ssl(+)') )
>   >=app-arch/tar-1.27
> @@ -85,6 +85,11 @@ pkg_setup() {
>  python_prepare_all() {
>   distutils-r1_python_prepare_all
>  
> + if use native-extensions; then
> + printf "[build_ext]\nportage-ext-modules=true" >> \
> + setup.cfg || die
> + fi
> +
>   if ! use ipc ; then
>   einfo "Disabling ipc..."
>   sed -e "s:_enable_ipc_daemon =
> True:_enable_ipc_daemon = False:" \

-- 
Best regards,
Michał Górny


signature.asc
Description: This is a digitally signed message part

Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

[Zac Medico]

On 02/01/2017 09:57 AM, Brian Dolbec wrote:
> On Wed,  1 Feb 2017 09:06:37 -0800
> Zac Medico  wrote:
> 
>> The native-extensions USE flag will enable building of the
>> libc bindings. This is not enabled by default because it does
>> not support cross compilation.
>>
>> X-Gentoo-bug: 571444
>> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=571444
>> ---
>>  sys-apps/portage/metadata.xml| 1 +
>>  sys-apps/portage/portage-.ebuild | 7 ++-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/sys-apps/portage/metadata.xml
>> b/sys-apps/portage/metadata.xml index e032ea5..882d3ba 100644
>> --- a/sys-apps/portage/metadata.xml
>> +++ b/sys-apps/portage/metadata.xml
>> @@ -12,6 +12,7 @@
>>
>>  Build html API documentation with
>> epydoc. Use inter-process communication
>> between portage and running ebuilds.
>> +Build native extensions.
>> Cross-compilation is not supported. > name="xattr">Preserve extended attributes (filesystem-stored
>> metadata) when installing files. Usually only required for hardened
>> systems.   diff --git
>> a/sys-apps/portage/portage-.ebuild
>> b/sys-apps/portage/portage-.ebuild index 6a6f515..981db26 100644
>> --- a/sys-apps/portage/portage-.ebuild +++
>> b/sys-apps/portage/portage-.ebuild @@ -19,7 +19,7 @@
>> HOMEPAGE="https://wiki.gentoo.org/wiki/Project:Portage;
>> LICENSE="GPL-2" KEYWORDS=""
>>  SLOT="0"
>> -IUSE="build doc epydoc +ipc linguas_ru selinux xattr"
>> +IUSE="build doc epydoc +ipc linguas_ru native-extensions selinux
>> xattr" 
>>  DEPEND="!build? ( $(python_gen_impl_dep 'ssl(+)') )
>>  >=app-arch/tar-1.27  
>> @@ -85,6 +85,11 @@ pkg_setup() {
>>  python_prepare_all() {
>>  distutils-r1_python_prepare_all
>>  
>> +if use native-extensions; then
>> +printf "[build_ext]\nportage-ext-modules=true" >> \
>> +setup.cfg || die
>> +fi
>> +
>>  if ! use ipc ; then
>>  einfo "Disabling ipc..."
>>  sed -e "s:_enable_ipc_daemon =
>> True:_enable_ipc_daemon = False:" \
> 
> looks good :)
> 

Thanks, pushed:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbe0bd44461aff3097fde6c64147f1a61e30816d
-- 
Thanks,
Zac