Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Ulrich Mueller
> On Wed, 19 Apr 2017, Michał Górny wrote: > On śro, 2017-04-19 at 18:21 +0200, Ulrich Mueller wrote: >> One more point, maybe output a QA warning here? > Not convinced about that. Two points: > 1. It will warn only people actually running Prefix. Sure, so having it won't harm on non-prefix

[gentoo-portage-dev] [PATCH v2] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Michał Górny
Add an additional conditional to the dosym Prefix hack to ensure that the symlink is not using double Prefix when the ebuild uses ${EPREFIX} explicitly. This ensures that Portage on Prefix systems is both compatible with the ebuilds relying on the hack, and using dosym in the PMS-defined manner. --

Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Michał Górny
On śro, 2017-04-19 at 18:21 +0200, Ulrich Mueller wrote: > > > > > > On Wed, 19 Apr 2017, Ulrich Mueller wrote: > > > +if [[ ${target:0:1} == "/" && ${target} != "${EPREFIX}"* ]]; then > > I think you want an additional slash in the second condition, in order > > to prevent /foo/barbaz from matchin

Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Michał Górny
On śro, 2017-04-19 at 18:06 +0200, Ulrich Mueller wrote: > > > > > > On Wed, 19 Apr 2017, Michał Górny wrote: > > Add an additional conditional to the dosym Prefix hack to ensure that > > the symlink is not using double Prefix when the ebuild uses ${EPREFIX} > > explicitly. This ensures that Portag

Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Ulrich Mueller
> On Wed, 19 Apr 2017, Ulrich Mueller wrote: >> +if [[ ${target:0:1} == "/" && ${target} != "${EPREFIX}"* ]]; then > I think you want an additional slash in the second condition, in order > to prevent /foo/barbaz from matching if EPREFIX is equal to /foo/bar: > if [[ ${target:0:1} == "/" &&

Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Ulrich Mueller
> On Wed, 19 Apr 2017, Michał Górny wrote: > Add an additional conditional to the dosym Prefix hack to ensure that > the symlink is not using double Prefix when the ebuild uses ${EPREFIX} > explicitly. This ensures that Portage on Prefix systems is both > compatible with the ebuilds relying on

[gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX

2017-04-19 Thread Michał Górny
Add an additional conditional to the dosym Prefix hack to ensure that the symlink is not using double Prefix when the ebuild uses ${EPREFIX} explicitly. This ensures that Portage on Prefix systems is both compatible with the ebuilds relying on the hack, and using dosym in the PMS-defined manner. --