On Sun, Jul 30, 2017 at 1:27 PM, Zac Medico wrote:
> On Sat, Jul 29, 2017 at 10:50 PM, Michał Górny wrote:
>> On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote:
>>> Pushed as:
>>> https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471
>>>
>>> Thanks for the patient reviews, Zac!
>>>
>>
>> I'm sorry for noticing this only now when I'm enabling it but we have
>> already:
>>
>> PORTAGE_COMPRESS
>> PORTAGE_COMPRESS_FLAGS
>> ^^
>>
>> and you've added:
>>
>> BINPKG_COMPRESSION
>>^^^
>> BINPKG_COMPRESSION_ARGS
>>
>>
>> Wouldn't it be better to at least try having consistent variable naming?
>
> Yeah, let's change it to BINPKG_COMPRESS and BINPKG_COMPRESS_FLAGS.
Pushed:
https://gitweb.gentoo.org/proj/portage.git/commit/?id=2c7d38b9512609f6828cbba1066f2b3b2d9144bf
--
Thanks,
Zac
