Re: [gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

[Michał Górny]

Dnia 13 stycznia 2018 11:40:09 CET, Zac Medico  napisał(a):
>On 01/13/2018 12:50 AM, Michał Górny wrote:
>> Switch the Portage defaults to the new Gentoo hash set. We're already
>> far past the initial testing and I have been approached by a few
>people
>> who were surprised that Portage does not use new hashes for overlays.
>> Switching the defaults will remove the need for custom hashes
>> in layout.conf.
>> ---
>>  pym/portage/const.py | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/pym/portage/const.py b/pym/portage/const.py
>> index ec877b841..e5fa4b67c 100644
>> --- a/pym/portage/const.py
>> +++ b/pym/portage/const.py
>> @@ -206,8 +206,8 @@ EAPI = 6
>>  
>>  HASHING_BLOCKSIZE= 32768
>>  
>> -MANIFEST2_HASH_DEFAULTS = frozenset(["SHA256", "SHA512",
>"WHIRLPOOL"])
>> -MANIFEST2_HASH_DEFAULT  = "SHA512"
>> +MANIFEST2_HASH_DEFAULTS = frozenset(["BLAKE2B", "SHA512"])
>> +MANIFEST2_HASH_DEFAULT  = "BLAKE2B"
>>  
>>  MANIFEST2_IDENTIFIERS= ("AUX", "MISC", "DIST", "EBUILD")
>>  
>> 
>For repos where layout.conf doesn't set "manifest-required-hashes =
>SHA512", repoman is suddenly going to force all DIST files to be
>fetched
>in order to generate the missing BLAKE2B entries. Is that intended?

Yes. I don't think we need a transition period for overlays.


-- 
Best regards,
Michał Górny (by phone)

Re: [gentoo-portage-dev] [PATCH v2 2/2] man/ebuild.5: document the rationale for using keepdir over dodir.

[Zac Medico]

On 01/12/2018 02:56 PM, Michael Orlitzky wrote:
> ---
>  man/ebuild.5 | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/man/ebuild.5 b/man/ebuild.5
> index 28e9582d1..8784a14ee 100644
> --- a/man/ebuild.5
> +++ b/man/ebuild.5
> @@ -1285,8 +1285,9 @@ Sets the root (\fIDESTTREE\fR) for other functions like 
> \fBdobin\fR,
>  The default root is /usr.
>  .TP
>  .B keepdir\fR \fI [more paths]
> -Tells portage to leave directories behind even if they're empty.  Functions
> -the same as \fBdodir\fR.
> +Similar to \fBdodir\fR, but used to create directories that would otherwise
> +be empty. The treatment of completely-empty directories is undefined by the
> +PMS, and using \fBkeepdir\fR ensures that they are tracked.
>  .TP
>  .B dobin\fR \fI [list of more binaries]
>  Installs a \fIbinary\fR or a list of binaries into \fIDESTTREE\fR/bin.
> 

Merged in 40c4cf6ec4cda1a05c4bf3a4a6e9ece4ca74f803, with backslash
escaped hyphen and without 'the' before PMS (for consistency with other
references to PMS). Thanks!
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH v2 1/2] man/ebuild.5: document that dodir is for nonempty directories.

[Zac Medico]

On 01/12/2018 02:56 PM, Michael Orlitzky wrote:
> ---
>  man/ebuild.5 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man/ebuild.5 b/man/ebuild.5
> index 42a0599fe..28e9582d1 100644
> --- a/man/ebuild.5
> +++ b/man/ebuild.5
> @@ -1271,7 +1271,8 @@ Creates directories inside of ${ED}.
>  .br
>  .BR 'dodir\ /usr/lib/apache'
>  creates ${ED}/usr/lib/apache.  Note that the do* functions will run
> -\fBdodir\fR for you.
> +\fBdodir\fR for you. If this directory will be empty when it is merged,
> +then please use \fBkeepdir\fR instead.
>  .TP
>  .B diropts\fR \fI[options for install(1)]
>  Can be used to define options for the install function used in
> 

Merged in 2d277427a32f09a27fabd6eec75dfaf51ed1d3f2. Thanks!
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

[Zac Medico]

On 01/13/2018 12:50 AM, Michał Górny wrote:
> Switch the Portage defaults to the new Gentoo hash set. We're already
> far past the initial testing and I have been approached by a few people
> who were surprised that Portage does not use new hashes for overlays.
> Switching the defaults will remove the need for custom hashes
> in layout.conf.
> ---
>  pym/portage/const.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pym/portage/const.py b/pym/portage/const.py
> index ec877b841..e5fa4b67c 100644
> --- a/pym/portage/const.py
> +++ b/pym/portage/const.py
> @@ -206,8 +206,8 @@ EAPI = 6
>  
>  HASHING_BLOCKSIZE= 32768
>  
> -MANIFEST2_HASH_DEFAULTS = frozenset(["SHA256", "SHA512", "WHIRLPOOL"])
> -MANIFEST2_HASH_DEFAULT  = "SHA512"
> +MANIFEST2_HASH_DEFAULTS = frozenset(["BLAKE2B", "SHA512"])
> +MANIFEST2_HASH_DEFAULT  = "BLAKE2B"
>  
>  MANIFEST2_IDENTIFIERS= ("AUX", "MISC", "DIST", "EBUILD")
>  
> 
For repos where layout.conf doesn't set "manifest-required-hashes =
SHA512", repoman is suddenly going to force all DIST files to be fetched
in order to generate the missing BLAKE2B entries. Is that intended?
-- 
Thanks,
Zac

[gentoo-portage-dev] [PATCH] const: Switch default hash set to BLAKE2B+SHA512

[Michał Górny]

Switch the Portage defaults to the new Gentoo hash set. We're already
far past the initial testing and I have been approached by a few people
who were surprised that Portage does not use new hashes for overlays.
Switching the defaults will remove the need for custom hashes
in layout.conf.
---
 pym/portage/const.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pym/portage/const.py b/pym/portage/const.py
index ec877b841..e5fa4b67c 100644
--- a/pym/portage/const.py
+++ b/pym/portage/const.py
@@ -206,8 +206,8 @@ EAPI = 6
 
 HASHING_BLOCKSIZE= 32768
 
-MANIFEST2_HASH_DEFAULTS = frozenset(["SHA256", "SHA512", "WHIRLPOOL"])
-MANIFEST2_HASH_DEFAULT  = "SHA512"
+MANIFEST2_HASH_DEFAULTS = frozenset(["BLAKE2B", "SHA512"])
+MANIFEST2_HASH_DEFAULT  = "BLAKE2B"
 
 MANIFEST2_IDENTIFIERS= ("AUX", "MISC", "DIST", "EBUILD")
 
-- 
2.16.0.rc1