Re: [gentoo-portage-dev] [PATCH v2 2/2] doebuild: Remove unnecessary restore of PORTAGE_ACTUAL_DISTDIR

2018-01-27 Thread Zac Medico
On 01/27/2018 02:02 AM, Michał Górny wrote: > Now that the DISTDIR override does not leak to global settings instance, > there is no need to restore it afterwards. Suggested by Zac Medico. > --- > pym/portage/package/ebuild/doebuild.py | 5 - > 1 file changed, 5 deletions(-) Both patches look

[gentoo-portage-dev] [PATCH v2 2/2] doebuild: Remove unnecessary restore of PORTAGE_ACTUAL_DISTDIR

2018-01-27 Thread Michał Górny
Now that the DISTDIR override does not leak to global settings instance, there is no need to restore it afterwards. Suggested by Zac Medico. --- pym/portage/package/ebuild/doebuild.py | 5 - 1 file changed, 5 deletions(-) diff --git a/pym/portage/package/ebuild/doebuild.py b/pym/portage/pack

[gentoo-portage-dev] [PATCH v2 1/2] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Michał Górny
Fix the duplicate override of DISTDIR that happens when using the 'ebuild' tool to run ebuilds. In this case, both the 'config' code and the 'prepare_build_dirs' code attempt to replace DISTDIR, and the shadow distdir symlinks end up pointing to themselves. As suggested by Zac Medico, after removi

Re: [gentoo-portage-dev] [PATCH] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Zac Medico
On 01/27/2018 01:38 AM, Zac Medico wrote: > On 01/27/2018 01:01 AM, Michał Górny wrote: >> Fix the duplicate override of DISTDIR that happens when using >> the 'ebuild' tool to run ebuilds. In this case, both the 'config' >> code and the 'prepare_build_dirs' code attempt to replace DISTDIR, >> and

Re: [gentoo-portage-dev] [PATCH] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Zac Medico
On 01/27/2018 01:01 AM, Michał Górny wrote: > Fix the duplicate override of DISTDIR that happens when using > the 'ebuild' tool to run ebuilds. In this case, both the 'config' > code and the 'prepare_build_dirs' code attempt to replace DISTDIR, > and the shadow distdir symlinks end up pointing to t

[gentoo-portage-dev] [PATCH] prepare_build_dirs: Fix duplicate override of DISTDIR for 'ebuild'

2018-01-27 Thread Michał Górny
Fix the duplicate override of DISTDIR that happens when using the 'ebuild' tool to run ebuilds. In this case, both the 'config' code and the 'prepare_build_dirs' code attempt to replace DISTDIR, and the shadow distdir symlinks end up pointing to themselves. Apparently the _prepare_fake_distdir() i