Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

On Tue, 2021-09-28 at 11:28 -0400, Mike Gilbert wrote: > On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > > > Hi, > > > > Ok, so it's more major than I originally intended but I think it's > > a good direction (once you get used to it). Roughly: > > > > 1. All bash color vars are now

Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > Hi, > > Ok, so it's more major than I originally intended but I think it's > a good direction (once you get used to it). Roughly: > > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid >accidental collisions with

[gentoo-portage-dev] [PATCH 3/4] Use verbose prefixes for output messages

Use verbose prefixes for output functions einfo, elog... in order to make the message types distinguishable on non-color terminals, and to enable the possibility of grepping them. The prefixes are roughly inspired by Xorg logs, and are: - `[--]` for einfo (and ebegin) - `[II]` for elog - `[WW]`

[gentoo-portage-dev] [PATCH 2/4] Use distinct colors for output msg types

Introduce distinct colors per output function. For elog and eerror the colors remain the same but the names change. For einfo and eqawarn, use darker colors to distinguish them. Signed-off-by: Michał Górny --- bin/isolated-functions.sh| 30 +++--- bin/save-ebuild-env.sh

[gentoo-portage-dev] [PATCH 1/4] Prefix color vars with "PORTAGE_COLOR_"

Rename color variables used by einfo etc. to use "PORTAGE_COLOR_" prefix. Currently these variables are prone to being accidentally ovewritten e.g. if an ebuild uses GOOD or BAD variables for some purpose. Using PORTAGE prefix should keep us safe. As an extra benefit, this makes it trivial to

[gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability

Hi, Ok, so it's more major than I originally intended but I think it's a good direction (once you get used to it). Roughly: 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid accidental collisions with ebuild vars (e.g. ebuild setting `GOOD=foo` broke `elog` before). 2.

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

On Tue, Sep 28, 2021 at 2:25 AM Michał Górny wrote: > > On Mon, 2021-09-27 at 21:09 -0400, Mike Gilbert wrote: > > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > > + eqawarn > > > + eqawarn "It is impossible to reliably guarantee that the > > > extended

[gentoo-portage-dev] [PATCH v2] install-qa-check.d: Add a QA check for installing xattrs

Warn the developers if ebuilds install files with xattrs to ${ED}. The xattrs may or may not be preserved when installing the package, making them unreliable on one hand, and somewhat suprising in other cases (e.g. when they unintentionally leak from developer's system). This is the first step

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

On Mon, 2021-09-27 at 21:09 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > + eqawarn > > + eqawarn "It is impossible to reliably guarantee that the > > extended attributes" > > + eqawarn "will be reliably preserved

Re: [gentoo-portage-dev] [PATCH] install-qa-check.d: Add a QA check for installing xattrs

On Mon, 2021-09-27 at 21:03 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny wrote: > > > > Warn the developers if ebuilds install files with xattrs to ${ED}. > > The xattrs may or may not be preserved when installing the package, > > making them unreliable on one hand,