> On 26 Jul 2022, at 04:00, Sam James wrote:
>
>
>
>> On 25 Jul 2022, at 16:28, Fabian Groffen wrote:
>>
>> bin/ebuild-helpers/emake: force SHELL to be set
>>
>> On Prefix systems /bin/sh can be anything, including very ancient. So
>> ensure we're running with bash, since that's what
> On 26 Jul 2022, at 00:33, Mike Gilbert wrote:
>
> On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen wrote:
>>
>> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects
>>
>> Check for dylib on Darwin, so on everything else.
>>
>> Signed-off-by: Fabian Groffen
>>
>> diff --git
> On 25 Jul 2022, at 16:28, Fabian Groffen wrote:
>
> bin/ebuild-helpers/emake: force SHELL to be set
>
> On Prefix systems /bin/sh can be anything, including very ancient. So
> ensure we're running with bash, since that's what Gentoo Linux is
> expecting /bin/sh to be (by default, at
On Mon, Jul 25, 2022 at 1:03 PM Fabian Groffen wrote:
>
> bin/phase-functions.sh: make ED and EROOT read-only too
>
> Like D, make ED and EROOT read-only vars.
Makes sense.
On Mon, Jul 25, 2022 at 12:47 PM Fabian Groffen wrote:
>
> bin/misc-functions.sh: some Prefix fixes
>
> - ED needs not to exist, whereas D does, so ensure we check for that,
> and create ED if absent, necessary for further checks to succeed
> - use EPREFIX in INSTALL_MASK
Seems good to me.
On Mon, Jul 25, 2022 at 12:41 PM Fabian Groffen wrote:
>
> bin/install-qa-check.d/90world-writable: include EPREFIX in reports
>
> It is much less confusing and consistent to report full paths including
> the leading EPREFIX.
Makes sense to me.
On Mon, Jul 25, 2022 at 12:26 PM Fabian Groffen wrote:
>
> bin/install-qa-check.d/80multilib-strict: use file/find from Prefix
>
> diff --git a/bin/install-qa-check.d/80multilib-strict
> b/bin/install-qa-check.d/80multilib-strict
> index afd223250..3db4ecce3 100644
> ---
On Mon, Jul 25, 2022 at 11:28 AM Fabian Groffen wrote:
>
> bin/ebuild-helpers/emake: force SHELL to be set
>
> On Prefix systems /bin/sh can be anything, including very ancient. So
> ensure we're running with bash, since that's what Gentoo Linux is
> expecting /bin/sh to be (by default, at
On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen wrote:
>
> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects
>
> Check for dylib on Darwin, so on everything else.
>
> Signed-off-by: Fabian Groffen
>
> diff --git a/bin/install-qa-check.d/80libraries
>
Could you please create a PR at https://github.com/gentoo/portage so
that the CI system can test the changes for this patch series?
> On Mon, 25 Jul 2022, Fabian Groffen wrote:
> @@ -50,6 +51,16 @@ if [[ ${_E_INSDESTTREE_#${ED}} != "${_E_INSDESTTREE_}" ]];
> then
> __helpers_die "${helper} used with \${D} or \${ED}"
> exit 1
> fi
> +if [[ -n ${EPREFIX} && \
> + ${_E_INSDESTTREE_#${EPREFIX}} !=
bin/phase-functions.sh: make ED and EROOT read-only too
Like D, make ED and EROOT read-only vars.
Signed-off-by: Fabian Groffen
diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
index ccf7eeea7..212b19fc1 100644
--- a/bin/phase-functions.sh
+++ b/bin/phase-functions.sh
@@ -12,7
bin/misc-functions.sh: some Prefix fixes
- ED needs not to exist, whereas D does, so ensure we check for that,
and create ED if absent, necessary for further checks to succeed
- use EPREFIX in INSTALL_MASK
Signed-off-by: Fabian Groffen
diff --git a/bin/misc-functions.sh
bin/install-qa-check.d/90world-writable: include EPREFIX in reports
It is much less confusing and consistent to report full paths including
the leading EPREFIX.
Signed-off-by: Fabian Groffen
diff --git a/bin/install-qa-check.d/90world-writable
b/bin/install-qa-check.d/90world-writable
index
bin/install-qa-check.d/80multilib-strict: use file/find from Prefix
diff --git a/bin/install-qa-check.d/80multilib-strict
b/bin/install-qa-check.d/80multilib-strict
index afd223250..3db4ecce3 100644
--- a/bin/install-qa-check.d/80multilib-strict
+++ b/bin/install-qa-check.d/80multilib-strict
@@
bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects
Check for dylib on Darwin, so on everything else.
Signed-off-by: Fabian Groffen
diff --git a/bin/install-qa-check.d/80libraries
b/bin/install-qa-check.d/80libraries
index 8dc35bb87..a477ec9cb 100644
---
bin/ebuild-helpers/emake: force SHELL to be set
On Prefix systems /bin/sh can be anything, including very ancient. So
ensure we're running with bash, since that's what Gentoo Linux is
expecting /bin/sh to be (by default, at least).
Provide a fallback for the (near impossible) case that we use a
On 25-07-2022 08:09:02 -0700, Zac Medico wrote:
> On 7/24/22 23:17, Fabian Groffen wrote:
> > On 24-07-2022 13:58:31 -0700, Zac Medico wrote:
> >> On 7/24/22 12:29, Fabian Groffen wrote:
> >>> Hi,
> >>>
> >>> Quick question, I noticed that portage uses /bin/bash hardcoded in
> >>> shebang of
bin/ebuild-helpers/doins: fix D check, add EPREFIX check
ED = D/EPREFIX, so checking for ED includes EPREFIX, which when this is
absent fails to check for D. Simply check for D instead, which catches
both the case for D and ED.
Add check for usage of EPREFIX, like for using D with helpers.
On 7/24/22 23:17, Fabian Groffen wrote:
On 24-07-2022 13:58:31 -0700, Zac Medico wrote:
On 7/24/22 12:29, Fabian Groffen wrote:
Hi,
Quick question, I noticed that portage uses /bin/bash hardcoded in
shebang of scripts, while it uses /usr/bin/env python for python
executable files.
Is there
On 24-07-2022 13:58:31 -0700, Zac Medico wrote:
> On 7/24/22 12:29, Fabian Groffen wrote:
> > Hi,
> >
> > Quick question, I noticed that portage uses /bin/bash hardcoded in
> > shebang of scripts, while it uses /usr/bin/env python for python
> > executable files.
> >
> > Is there anything
21 matches
Mail list logo
