Re: [gentoo-portage-dev] [PATCH 2/4] portage.eapi: use tuple instead of str for namedtuple definition

2022-03-08 Thread Alec Warner
Looks merge-able. On Wed, Feb 23, 2022 at 8:15 PM Matt Turner wrote: > > From: "Wolfgang E. Sanyer" > > Reviewed-by: Matt Turner > Signed-off-by: Wolfgang E. Sanyer > --- > lib/portage/eapi.py | 52 - > 1 file changed, 33 insertions(+), 19 deletions

Re: [gentoo-portage-dev] [PATCH 1/4] portage.dep.Atom: Clean up __new__ parameters

2022-03-08 Thread Alec Warner
maybe *unused_args, **unused_kwargs, unsure on the style guide for that (normally its _) But feel free to merge as-is. -A On Wed, Feb 23, 2022 at 8:15 PM Matt Turner wrote: > > From: "Wolfgang E. Sanyer" > > Reviewed-by: Matt Turner > Signed-off-by: Wolfgang E. Sanyer > --- > lib/portage/de

Re: [gentoo-portage-dev] [PATCH] estrip: rework hard link logic in save_elf_debug

2021-10-27 Thread Alec Warner
On Mon, Oct 25, 2021 at 10:10 AM Mike Gilbert wrote: > > GDB loads debug files based on the file name given in the .gnu_debuglink > section, prepended with /usr/lib/debug/${dirname}, where dirname is the > absolute path to the parent directory of the binary being executed. > > For each unique inod

Re: [gentoo-portage-dev] [RFC] LTS branch of Portage

2021-10-19 Thread Alec Warner
On Mon, Oct 18, 2021 at 4:25 PM Francesco Riosa wrote: > > > Il giorno mar 5 ott 2021 alle ore 10:31 Michał Górny ha > scritto: >> >> Hi, everyone. >> >> I've been thinking about this for some time already, and the recent >> FILESDIR mess seems to confirm it: I'd like to start a more stable LTS

Re: [gentoo-portage-dev] [PATCH] lib/_emerge/actions.py: warn on missing /run

2021-10-07 Thread Alec Warner
On Wed, Oct 6, 2021 at 8:20 PM Sam James wrote: > > Newer versions of build-docbook-catalog use > /run/lock. This exposed that we weren't > asking users to mount /run in the handbook. > > Check if it exists and warn if it doesn't. > > This should primarily (exclusively?) be a > problem in chroots

Re: [gentoo-portage-dev] [RFC] LTS branch of Portage

2021-10-05 Thread Alec Warner
On Tue, Oct 5, 2021 at 1:31 AM Michał Górny wrote: > > Hi, everyone. > > I've been thinking about this for some time already, and the recent > FILESDIR mess seems to confirm it: I'd like to start a more stable LTS > branch of Portage. > > Roughly, the idea is that: > > - master becomes 3.1.x, and

Re: [gentoo-portage-dev] [PATCH 2/2] Binpkg.py: check for inconsistent PROVIDES/image when unpacking binpkg

2021-10-04 Thread Alec Warner
On Sat, Oct 2, 2021 at 1:11 PM Sam James wrote: > > This is part of a series of fixes for the linked bug (failure > to preserve libraries in some situations). > > When unpacking a binpkg to be installed, we should check > for the existence of PROVIDES if we're installing any > dynamic libraries. I

Re: [gentoo-portage-dev] [PATCH 1/2] doebuild.py: check for inconsistent PROVIDES/image post-src_install

2021-10-04 Thread Alec Warner
On Sat, Oct 2, 2021 at 1:11 PM Sam James wrote: > > This is part of a series of fixes for the linked bug (failure > to preserve libraries in some situations). > > At the point of installation (even if not merging), we need > to detect inconsistent metadata: PROVIDES should be populated > if we're

Re: [gentoo-portage-dev] Performance tuning and parallelisation

2021-08-27 Thread Alec Warner
On Thu, Aug 26, 2021 at 4:03 AM Ed W wrote: > > Hi All > > Consider this a tentative first email to test the water, but I have started > to look at performance > of particularly the install phase of the emerge utility and I could use some > guidance on where to go > next To clarify; the 'instal

Re: [gentoo-portage-dev] In what phase are file "merged"?

2021-08-06 Thread Alec Warner
On Thu, Aug 5, 2021 at 9:23 PM Ulrich Mueller wrote: > > > On Fri, 06 Aug 2021, Joakim Tjernlund wrote: > > > On Wed, 2021-06-23 at 13:33 +0200, Michał Górny wrote: > >> On Wed, 2021-06-23 at 12:40 +0200, Ulrich Mueller wrote: > >> > I don't think that the ebuild can rely on any particular sta

Re: [gentoo-portage-dev] [PATCH] Add @changed-subslot package set

2021-01-18 Thread Alec Warner
On Mon, Jan 18, 2021 at 8:09 PM Zac Medico wrote: > > On 1/18/21 6:07 PM, Alec Warner wrote: > > On Fri, Jan 15, 2021 at 6:47 PM Matt Turner wrote: > >> > >> This set is the upgradable packages for which the highest visible > >> version has a differe

Re: [gentoo-portage-dev] [PATCH] Add @changed-subslot package set

2021-01-18 Thread Alec Warner
On Fri, Jan 15, 2021 at 6:47 PM Matt Turner wrote: > > This set is the upgradable packages for which the highest visible > version has a different subslot than the currently installed version. > > The primary purpose of this feature is for use in catalyst builds. We > update the "seed" stage3 befo

[gentoo-portage-dev] pylint progress

2020-07-29 Thread Alec Warner
Hi, Recently I've begun to run pylint on the portage codebase. You can see some recent PRs on this[0][1][2]. Most of the linter errors I've fixed are what I consider 'fairly trivial'. In general I'm happy to disable errors (or instances of errors) in addition to resolving them. You can see some of

Re: [gentoo-portage-dev] [PATCH 1/3] Add caching to catpkgsplit function

2020-07-09 Thread Alec Warner
" incorrectly) > Ahhh it's visible there; I'll blame gMail ;) -A > > On Thu, Jul 9, 2020 at 2:04 PM Alec Warner wrote: > >> >> >> On Thu, Jul 9, 2020 at 12:03 AM Chun-Yu Shei wrote: >> >>> Awesome! Here's a patch that adds @lru_c

Re: [gentoo-portage-dev] [PATCH 1/3] Add caching to catpkgsplit function

2020-07-09 Thread Alec Warner
On Thu, Jul 9, 2020 at 12:03 AM Chun-Yu Shei wrote: > Awesome! Here's a patch that adds @lru_cache to use_reduce, vercmp, and > catpkgsplit. use_reduce was split into 2 functions, with the outer one > converting lists/sets to tuples so they can be hashed and creating a > copy of the returned li

Re: [gentoo-portage-dev] [PATCH] config.environ: delay export of A and AA (bug 720180)

2020-05-26 Thread Alec Warner
On Tue, May 26, 2020 at 9:46 AM Zac Medico wrote: > On 5/26/20 1:43 AM, Alec Warner wrote: > > On Mon, May 25, 2020 at 9:34 PM Zac Medico > <mailto:zmed...@gentoo.org>> wrote: > > > > Since variables like A and AA can contain extremely large values > wh

Re: [gentoo-portage-dev] [PATCH] config.environ: delay export of A and AA (bug 720180)

2020-05-26 Thread Alec Warner
On Mon, May 25, 2020 at 9:34 PM Zac Medico wrote: > Since variables like A and AA can contain extremely large values which > may trigger E2BIG errors during attempts to execute subprocesses, delay > export until the last moment, and unexport when appropriate. > So I think if you want to do this

Re: [gentoo-portage-dev] Need backup mentor for FUSE-based sandbox project

2020-04-25 Thread Alec Warner
On Thu, Apr 23, 2020 at 12:09 PM Michał Górny wrote: > Hi, everyone. > > It seems that we *urgently* (read: in 6 days) need to find backup > mentors for this year's GSoC projects. I'm mentoring the project to > develop a FUSE-based sandbox alternative that's going to work reliably > with more pa

Re: [gentoo-portage-dev] precisions on installed packages' dependencies

2020-03-27 Thread Alec Warner
On Fri, Mar 27, 2020 at 7:00 AM wrote: > > - Alec Warner a écrit : > > On Tue, Mar 24, 2020 at 11:31 AM wrote: > > > However, I still doubt that only storing the soname dependencies is > enough. > > > Consider package A (that cannot be recompiled) that d

Re: [gentoo-portage-dev] precisions on installed packages' dependencies

2020-03-26 Thread Alec Warner
On Tue, Mar 24, 2020 at 11:31 AM wrote: > > - Zac Medico a écrit : > > > > The goal of my tool is to have correct manipulation of package > dependencies, and in particular here, I focus on the packages that are > installed but not in the portage tree/a local overlay anymore (the problem > do

Re: [gentoo-portage-dev] [PATCH] repoman.modules.vcs.git.changes: reindex (bug 712106)

2020-03-11 Thread Alec Warner
On Wed, Mar 11, 2020 at 12:16 AM Zac Medico wrote: > For files returned by git diff-index, call git update-index in order > to ensure that the index reflects the state on disk. This will prevent > incorrect assumptions in cases where the index is missing or stale for > some reason. Since repoman

Re: [gentoo-portage-dev] [PATCH v2] fetch: Support GLEP 75 mirror structure

2019-10-03 Thread Alec Warner
On Thu, Oct 3, 2019 at 9:37 AM Michał Górny wrote: > Add a support for the subset of GLEP 75 needed by Gentoo Infra. This > includes fetching and parsing layout.conf, and support for flat layout > and filename-hash layout with cutoffs being multiplies of 4. > > Bug: https://bugs.gentoo.org/64689

Re: [gentoo-portage-dev] [PATCH] fetch: Support GLEP 75 mirror structure

2019-10-03 Thread Alec Warner
On Thu, Oct 3, 2019 at 7:52 AM Michał Górny wrote: > Add a support for the subset of GLEP 75 needed by Gentoo Infra. This > includes fetching and parsing layout.conf, and support for flat layout > and filename-hash layout with cutoffs being multiplies of 4. > > Bug: https://bugs.gentoo.org/64689

Re: [gentoo-portage-dev] [PATCH] Use RTNETLINK to configure the loopback interface

2019-08-27 Thread Alec Warner
unit tests? -A On Mon, Aug 26, 2019 at 8:03 PM Mike Gilbert wrote: > This eliminates the dependency on iproute2 on Linux. > > Signed-off-by: Mike Gilbert > --- > lib/portage/process.py | 25 -- > lib/portage/util/netlink.py | 91 + > 2 files ch

Re: [gentoo-portage-dev] [PATCH] bindbapi: add reentrant lock method (bug 685236)

2019-05-08 Thread Alec Warner
On Wed, May 8, 2019 at 2:05 PM Zac Medico wrote: > On 5/7/19 1:01 PM, Zac Medico wrote: > > On 5/7/19 7:55 AM, Alec Warner wrote: > > > >> Also curious why we are not implementing enter and exit so we can avoid > >> unbalanced pairs by using context managers. &g

Re: [gentoo-portage-dev] [PATCH] bindbapi: add reentrant lock method (bug 685236)

2019-05-07 Thread Alec Warner
On Mon, May 6, 2019 at 8:15 PM Zac Medico wrote: > Add a reentrant lock/unlock method which is useful for things like > emaint binhost and eclean-pkg. The vardbapi class already provides > lock/unlock methods that behave the same way. > Curious why we are not doing more encapsulation here. I'd

Re: [gentoo-portage-dev] [PATCH 0/4] Rename PORT_LOGDIR{,_CLEAN} variables to PORTAGE_LOGDIR{,_CLEAN} Bug 668538

2018-12-17 Thread Alec Warner
On Mon, Dec 17, 2018 at 10:51 AM Michał Górny wrote: > On Mon, 2018-12-17 at 15:44 +, M. J. Everitt wrote: > > On 17/12/18 12:54, Michał Górny wrote: > > > > Not only this, but as noted, unless you know the man pages for > portage and > > > > make.conf in order to recite them in your sleep, t

Re: [gentoo-portage-dev] Re: [RFC] gpkg format proposal v2

2018-11-12 Thread Alec Warner
On Mon, Nov 12, 2018 at 3:24 PM Ulrich Mueller wrote: > > On Mon, 12 Nov 2018, Michał Górny wrote: > > >> Also, what would be wrong with ar? It's a standard POSIX tool, and > >> should be available everywhere. > > > The original post says what's wrong with ar. Please be more specific > > if

Re: [gentoo-portage-dev] Re: [RFC] Improving Gentoo package format

2018-11-11 Thread Alec Warner
On Sun, Nov 11, 2018 at 2:21 PM Rich Freeman wrote: > On Sun, Nov 11, 2018 at 1:02 PM M. J. Everitt wrote: > > > > If you can really present a decent argument for replicating the > > functionality of other distros like Debian, Arch, Ubuntu etc then let's > > here it. For now, the strength of Gen

Re: [gentoo-portage-dev] [RFC] Improving Gentoo package format

2018-11-11 Thread Alec Warner
On Sun, Nov 11, 2018 at 3:29 AM Michał Górny wrote: > On Sat, 2018-11-10 at 09:37 -0500, Alec Warner wrote: > > On Sat, Nov 10, 2018 at 8:09 AM Michał Górny wrote: > > > > > Hi, everyone. > > > > > > The Gentoo's tbz2/xpak package format is

Re: [gentoo-portage-dev] [RFC] Improving Gentoo package format

2018-11-10 Thread Alec Warner
On Sat, Nov 10, 2018 at 8:09 AM Michał Górny wrote: > Hi, everyone. > > The Gentoo's tbz2/xpak package format is quite old. We've made a few > incompatible changes in the past (most notably, allowing non-bzip2 > compression and multi-instance naming) but the core design stayed > the same. I thi

Re: [gentoo-portage-dev] Objections to renaming pym directory to lib?

2018-07-18 Thread Alec Warner
On Wed, Jul 18, 2018 at 4:36 PM, Michał Górny wrote: > W dniu śro, 18.07.2018 o godzinie 13∶51 -0400, użytkownik Alec Warner > napisał: > > On Wed, Jul 18, 2018 at 2:54 AM, Brian Dolbec wrote: > > > > > On Tue, 17 Jul 2018 13:28:05 -0700 > > > Zac Medico

Re: [gentoo-portage-dev] Objections to renaming pym directory to lib?

2018-07-18 Thread Alec Warner
On Wed, Jul 18, 2018 at 2:54 AM, Brian Dolbec wrote: > On Tue, 17 Jul 2018 13:28:05 -0700 > Zac Medico wrote: > > > Are there any objections to renaming the pym directory to lib [1]? > > Note that the git log --follow option makes this kind of rename > > fairly painless. > > > > [1] https://gith

Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390)

2018-05-08 Thread Alec Warner
lgtm. -A On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec wrote: > On Mon, 7 May 2018 03:18:32 -0700 > Zac Medico wrote: > > > + # This attribute it used by _wrap_loop to detect if > > the > > typo, s/it/is > > this asynio stuff is mostly beyond my familiarity... but all looks ok, >

Re: [gentoo-portage-dev] [PATCH 0/4] rsync: add key refresh retry (bug 649276)

2018-04-01 Thread Alec Warner
On Sun, Apr 1, 2018 at 2:29 PM, Michał Górny wrote: > W dniu nie, 01.04.2018 o godzinie 08∶59 -0700, użytkownik Zac Medico > napisał: > > On 04/01/2018 03:57 AM, Michał Górny wrote: > > > W dniu sob, 31.03.2018 o godzinie 19∶46 -0700, użytkownik Zac Medico > > > napisał: > > > > Since key refresh

Re: [gentoo-portage-dev] [PATCH 3/4] Add retry decorator (API inspired by tenacity)

2018-04-01 Thread Alec Warner
also lgtm. On Sat, Mar 31, 2018 at 10:46 PM, Zac Medico wrote: > This decorator will be useful for retrying asynchronous > operations, such as gpg key refresh (bug 649276). The > API is inspired by tenacity, but is simpler. Only > asynchronous functions (like @asyncio.coroutine functions) > are

Re: [gentoo-portage-dev] [PATCH 1/4] Add ForkExecutor (bug 649588)

2018-04-01 Thread Alec Warner
lgtm. On Sat, Mar 31, 2018 at 10:46 PM, Zac Medico wrote: > This is useful for asynchronous operations that we might > need to cancel if they take too long, since (concurrent. > futures.ProcessPoolExecutor tasks are not cancellable). > This ability to cancel tasks makes this executor useful > as

Re: [gentoo-portage-dev] [PATCH 3/3] portage.dbapi.vartree: Support exclusions in INSTALL_MASK

2018-03-15 Thread Alec Warner
On Thu, Mar 15, 2018 at 3:22 PM, Michał Górny wrote: > Allow INSTALL_MASK patterns to start with '-' to indicate that > a specific match is to be excluded from being masked. In this case, > the last matching pattern determines whether the file is actually > filtered out or kept. > --- > pym/port

Re: [gentoo-portage-dev] [PATCH 1/2] portdbapi: add async_aux_get method (bug 648790)

2018-02-26 Thread Alec Warner
On Mon, Feb 26, 2018 at 1:09 PM, Zac Medico wrote: > On 02/26/2018 04:29 AM, Michał Górny wrote: > > W dniu nie, 25.02.2018 o godzinie 17∶50 -0800, użytkownik Zac Medico > > napisał: > >> Add async_aux_get method that returns a Future and otherwise > >> behaves identically to aux_get. Use async_a

Re: [gentoo-portage-dev] [PATCH 2/2] Add iter_completed convenience function (bug 648790)

2018-02-25 Thread Alec Warner
On Sun, Feb 25, 2018 at 8:50 PM, Zac Medico wrote: > The iter_completed function is similar to asyncio.as_completed, but > takes an iterator of futures as input, and includes support for > max_jobs and max_load parameters. The default values for max_jobs > and max_load correspond to multiprocessi

Re: [gentoo-portage-dev] [PATCH v2] filter-bash-environment.py: use buffered input, raw bytes (bug 647654)

2018-02-15 Thread Alec Warner
On Thu, Feb 15, 2018 at 12:49 AM, Zac Medico wrote: > Use sys.stdin.buffer instead of sys.stdin.buffer.raw, for buffered input. > Also use raw bytes instead of unicode strings, in order to avoid making > assumptions about character encodings, and also to avoid overhead from > unicode decoding/enc

Re: [gentoo-portage-dev] [PATCH] filter-bash-environment.py: use buffered input, raw bytes (bug 647654)

2018-02-14 Thread Alec Warner
On Wed, Feb 14, 2018 at 3:38 PM, Zac Medico wrote: > Use sys.stdin.buffer instead of sys.stdin.buffer.raw, for buffered input. > Also use raw bytes instead of unicode strings, in order to avoid making > assumptions about character encodings, and also to avoid overhead from > unicode decoding/enco

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Alec Warner
On Sun, Jan 28, 2018 at 8:10 PM, Zac Medico wrote: > On 01/28/2018 04:17 PM, Michael Orlitzky wrote: > > Since ::gentoo is the only repository governed by the PMS, can't we make > > repoman do this? The problem with requiring "repoman --force" for an > > in-place dependency change is that repoman

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Alec Warner
On Sun, Jan 28, 2018 at 1:09 PM, Zac Medico wrote: > On 01/28/2018 09:35 AM, Alec Warner wrote: > > > > > > On Sun, Jan 28, 2018 at 9:51 AM, Zac Medico > <mailto:zmed...@gentoo.org>> wrote: > > > > The --dynamic-deps=n default causes confu

Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)

2018-01-28 Thread Alec Warner
On Sun, Jan 28, 2018 at 9:51 AM, Zac Medico wrote: > The --dynamic-deps=n default causes confusion for users that are > accustomed to dynamic deps, therefore add a --changed-deps-report > option that is enabled by default (if --usepkgonly is not enabled). > > The --quiet option will suppress the

Re: [gentoo-portage-dev] Plan for initial integration of gemato with portage

2018-01-24 Thread Alec Warner
On Wed, Jan 24, 2018 at 2:58 PM, Michał Górny wrote: > W dniu śro, 24.01.2018 o godzinie 12∶54 -0500, użytkownik Alec Warner > napisał: > > On Wed, Jan 24, 2018 at 3:56 AM, Michał Górny wrote: > > > > > Hi, everyone. > > > > > > Since the init

Re: [gentoo-portage-dev] Plan for initial integration of gemato with portage

2018-01-24 Thread Alec Warner
On Wed, Jan 24, 2018 at 3:56 AM, Michał Górny wrote: > Hi, everyone. > > Since the initial review of my patch lost focus, and lacked sufficient > context, here's the plan that I'd like to follow in order to initially > integrate gemato with portage and give our users secure checkouts by > default

Re: [gentoo-portage-dev] [PATCH 8/8] eshowkw: Always group Prefix keywords last

2018-01-23 Thread Alec Warner
On Tue, Jan 23, 2018 at 4:48 PM, Michał Górny wrote: > Always group all Prefix keywords after other types of keywords. This > not only ensures that fbsd sorts first but more importantly stabilizes > the LHS output between regular and -P variant -- that is, -P always adds > additional keywords at

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: fix virtual/rust handling (bug 645416)

2018-01-23 Thread Alec Warner
I'm starting to be a bit sad about this for a couple of reasons. 1) dep_zapdeps is pretty big at this point, and every tweak for || () just grows it. Do we have any idea: a) When dep_zapdeps will be 'done'? b) Plans for splitting it into more manageable pieces? 2) In general I worry that the l

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: exclude virtuals from new_slot_count (bug 645190)

2018-01-20 Thread Alec Warner
On Sat, Jan 20, 2018 at 7:41 PM, Zac Medico wrote: > On 01/20/2018 04:23 PM, Alec Warner wrote: > > On Sat, Jan 20, 2018 at 7:10 PM, Zac Medico > <mailto:zmed...@gentoo.org>> wrote: > > > > diff --git a/pym/portage/dep/dep_check.py > b/pym/portage/dep/

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: exclude virtuals from new_slot_count (bug 645190)

2018-01-20 Thread Alec Warner
On Sat, Jan 20, 2018 at 7:10 PM, Zac Medico wrote: > Fix new_slot_count to exclude virtual packages, since they are considered > to have zero-cost. This solves an issue where the catalyst stage1 build > would unexpectedly pull in static-dev to satisfy virtual/dev-manager, > but eudev is the prefe

Re: [gentoo-portage-dev] [PATCH] ebuild: allow RESTRICT=network-sandbox in ebuilds

2018-01-17 Thread Alec Warner
On Wed, Jan 17, 2018 at 1:33 PM, Mike Frysinger wrote: > On 16 Jan 2018 23:32, Mike Gilbert wrote: > > On Tue, Jan 16, 2018 at 4:46 PM, Mike Frysinger wrote: > > > Some ebuilds are a bit hard to fix their use of the network in src > > > phases, so allow them to disable things. This allows us to

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-17 Thread Alec Warner
On Wed, Jan 17, 2018 at 10:25 AM, Michał Górny wrote: > W dniu wto, 16.01.2018 o godzinie 11∶32 -0800, użytkownik Zac Medico > napisał: > > On 01/16/2018 10:39 AM, Michał Górny wrote: > > > W dniu wto, 16.01.2018 o godzinie 12∶44 -0500, użytkownik Alec Warner > > >

Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification

2018-01-16 Thread Alec Warner
On Tue, Jan 16, 2018 at 11:43 AM, Michał Górny wrote: > Include a repo.postsync.d hook to verify the rsync checkout using > gemato. Given that not all people will want to have it enabled > unconditionally, no setup.py rules are included -- instead, the file > would be installed conditionally by t

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-10 Thread Alec Warner
The code lgtm. Slightly unsure if we need an entirely new test, as opposed to just generalizing the test cases (like you did the code). But either way is probably fine. -A On Tue, Jan 9, 2018 at 2:55 PM, Zac Medico wrote: > Prefer to install a new package in order to allow upgrade of an > inst

Re: [gentoo-portage-dev] [PATCH] install-qa-check: Do not install empty directories

2018-01-10 Thread Alec Warner
Please link to documentation on keepdir (e.g. https://devmanual.gentoo.org/function-reference/install-functions/index.html) in the helper? I'm not sure there is better keepdir document? Also looking at https://devmanual.gentoo.org/eclass-reference/ebuild/ It says "keepdir functions the same as d

Re: [gentoo-portage-dev] [PATCH v2] bin/doins.py: implement install -p option (bug 642632)

2017-12-31 Thread Alec Warner
On Fri, Dec 29, 2017 at 7:19 PM, Zac Medico wrote: > Bug: https://bugs.gentoo.org/642632 > --- > [PATCH v2] fix to copy atime, and split out _set_timestamps function > > bin/doins.py| 28 +--- > pym/portage/tests/bin/test_doins.py | 6 -- > 2

Re: [gentoo-portage-dev] [PATCH] dep_check: use DNF to optimize overlapping virtual || deps (bug 632026)

2017-11-13 Thread Alec Warner
On Sun, Nov 12, 2017 at 6:48 AM, Zac Medico wrote: > Deps like these: > > || ( foo bar ) || ( bar baz ) > > Translate to disjunctive normal form (DNF): > > || ( ( foo bar ) ( foo baz ) ( bar bar ) ( bar baz ) ) > > Using DNF, if none of the packages are currently installed, > then the ( bar b

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-09-08 Thread Alec Warner
Must be old age setting in :( Thanks, -A On Fri, Sep 8, 2017 at 2:54 PM, Michał Górny wrote: > W dniu pią, 08.09.2017 o godzinie 14∶48 -0400, użytkownik Alec Warner > napisał: > > Why PATH=/dev/null vs export PATH="" > > + # note: we can't use empty bec

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-09-08 Thread Alec Warner
Why PATH=/dev/null vs export PATH="" On Thu, Sep 7, 2017 at 3:36 AM, Michał Górny wrote: > Dnia 31 sierpnia 2017 22:45:42 CEST, "Michał Górny" > napisał(a): > >Set PATH to /dev/null when sourcing the ebuild for dependency > >resolution > >in order to prevent shell from finding external commands

Re: [gentoo-portage-dev] [PATCH v2] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-05 Thread Alec Warner
On Fri, Aug 4, 2017 at 6:37 PM, Michał Górny wrote: > Support two new options: --bug (-b) and --closes (-c) to add a plain > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both > options can be specified multiple times, resulting in multiple footer > tags being written. > > The

Re: [gentoo-portage-dev] [PATCH] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-03 Thread Alec Warner
On Thu, Aug 3, 2017 at 12:15 PM, Michał Górny wrote: > On czw, 2017-08-03 at 11:18 -0400, Alec Warner wrote: > > On Thu, Aug 3, 2017 at 10:18 AM, Michał Górny wrote: > > > > > Support two new options: --bug (-b) and --closes (-c) to add a plain > > > 'Bug&

Re: [gentoo-portage-dev] [PATCH] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-03 Thread Alec Warner
On Thu, Aug 3, 2017 at 10:18 AM, Michał Górny wrote: > Support two new options: --bug (-b) and --closes (-c) to add a plain > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both > options can be specified multiple times, resulting in multiple footer > tags being written. > > The

Re: [gentoo-portage-dev] Re: running ebuild in src tree

2015-03-14 Thread Alec Warner
On Thu, Mar 12, 2015 at 10:26 AM, Joakim Tjernlund < joakim.tjernl...@transmode.se> wrote: > On Thu, 2015-03-12 at 01:27 +, Duncan wrote: > > Zac Medico posted on Wed, 11 Mar 2015 12:03:10 -0700 as excerpted: > > > > > On 03/11/2015 11:56 AM, Joakim Tjernlund wrote: > > > > On Wed, 2015-03-11

Re: [gentoo-portage-dev] Portage and Update Security

2015-03-14 Thread Alec Warner
On Tue, Mar 10, 2015 at 2:15 PM, Vladimir Diaz wrote: > Hi, > > I am a developer in the Secure Systems Lab at NYU. Our lab has > collaborated with popular software update systems in the open-source > community, including APT, yum, and YaST, to address security problems. > More recently, we have

Re: [gentoo-portage-dev] [PATCH] emerge: Don't die when the user has an invalid locale setting

2014-08-05 Thread Alec Warner
On Mon, Aug 4, 2014 at 12:45 PM, Mike Gilbert wrote: > --- > pym/_emerge/main.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py > index 1a920f7..722da84 100644 > --- a/pym/_emerge/main.py > +++ b/pym/_emerge/main.py > @@ -99

Re: [gentoo-portage-dev] [PATCH] ebuild-helpers/xattr/install: use install-xattr

2014-06-02 Thread Alec Warner
On Sat, May 31, 2014 at 4:36 PM, wrote: > From: "Anthony G. Basile" > > Currently bin/ebuild-helpers/xattr/install uses > ${PORTAGE_BIN_PATH}/install.py > as a wrapper to coreutils' install to preserve a file's extended > attributes when > installing, usually during src_install(). This is neede

Re: [gentoo-portage-dev] [PATCH] Support the 'packages' profile file as a directory.

2014-05-12 Thread Alec Warner
And the manpages..? -A On Mon, May 12, 2014 at 3:14 AM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Thanks! Committed as b4d8e300c04b768be7cd5c64116d6cc0453219b4. > > - -- > Alexander > berna...@gentoo.org > https://secure.plaimi.net/~alexander > -BEGIN

Re: [gentoo-portage-dev] [PATCH 1/2] Use a localized size formatting function and ISO/IEC prefixes.

2014-03-30 Thread Alec Warner
On Sun, Mar 30, 2014 at 12:56 AM, Michał Górny wrote: > Dnia 2014-03-30, o godz. 00:03:02 > Alexander Berntsen napisał(a): > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA256 > > > > Please use a max 50 char commit message headline, without the period. > > > > On 29/03/14 19:45, Michał Gór

Re: [gentoo-portage-dev] plugin-sync progress report

2014-03-15 Thread Alec Warner
On Sat, Mar 15, 2014 at 1:32 PM, Brian Dolbec wrote: > I've started working on the repository/config.py changes needed for the > plugin-sync system. > > First: > The following class performed checks on the > repos.conf entries for the sync variables regardless if they were being > used or not.

Re: [gentoo-portage-dev] [PATCH 3/3] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-03-15 Thread Alec Warner
On Fri, Mar 14, 2014 at 10:35 PM, Pavel Kazakov wrote: > On 03/13/14 15:09, Alec Warner wrote: > > > > > > > > On Wed, Mar 12, 2014 at 11:10 PM, Pavel Kazakov > > mailto:nullishz...@gentoo.org>> wrote: > > > > --- > >

Re: [gentoo-portage-dev] [PATCH 3/3] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-03-13 Thread Alec Warner
On Thu, Mar 13, 2014 at 3:09 PM, Alec Warner wrote: > > > > On Wed, Mar 12, 2014 at 11:10 PM, Pavel Kazakov wrote: > >> --- >> pym/portage/emaint/main.py| 6 +- >> pym/portage/emaint/modules/merges/__init__.py | 30 +++ >> pym/

Re: [gentoo-portage-dev] [PATCH 3/3] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-03-13 Thread Alec Warner
On Wed, Mar 12, 2014 at 11:10 PM, Pavel Kazakov wrote: > --- > pym/portage/emaint/main.py| 6 +- > pym/portage/emaint/modules/merges/__init__.py | 30 +++ > pym/portage/emaint/modules/merges/merges.py | 281 > ++ > 3 files changed, 315 insertions(+

Re: [gentoo-portage-dev] [PATCH] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-02-19 Thread Alec Warner
On Wed, Feb 19, 2014 at 2:50 PM, Brian Dolbec wrote: > On Wed, 19 Feb 2014 12:31:44 -0800 > Pavel Kazakov wrote: > > > --- > > pym/portage/emaint/modules/merges/__init__.py | 20 > > pym/portage/emaint/modules/merges/merges.py | 70 > +++ > > 2 files changed,

Re: [gentoo-portage-dev] [PATCH] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-02-19 Thread Alec Warner
On Wed, Feb 19, 2014 at 3:20 PM, Brian Dolbec wrote: > On Wed, 19 Feb 2014 14:32:02 -0800 > Alec Warner wrote: > > > On Wed, Feb 19, 2014 at 12:31 PM, Pavel Kazakov >wrote: > > > > > --- > > > pym/portage/emaint/modules/merges/__init__.py | 20 +++

Re: [gentoo-portage-dev] [PATCH] Add an emaint module that can scan for failed merges and that can fix failed merges.

2014-02-19 Thread Alec Warner
On Wed, Feb 19, 2014 at 12:31 PM, Pavel Kazakov wrote: > --- > pym/portage/emaint/modules/merges/__init__.py | 20 > pym/portage/emaint/modules/merges/merges.py | 70 > +++ > 2 files changed, 90 insertions(+) > create mode 100644 pym/portage/emaint/modules/merg

Re: [gentoo-portage-dev] [PATCH v2] Add --output-style option to repoman

2014-02-13 Thread Alec Warner
On Thu, Feb 13, 2014 at 7:42 AM, Brian Dolbec wrote: > On Thu, 13 Feb 2014 03:19:35 -0500 > Mike Frysinger wrote: > > > On Monday, February 10, 2014 20:22:36 Chris Reffett wrote: > > > This patch adds a --output-style option to repoman, which gives the > > > user a choice of output formats for t

Re: [gentoo-portage-dev] [PATCH v2] Add --output-style option to repoman

2014-02-13 Thread Alec Warner
On Thu, Feb 13, 2014 at 12:19 AM, Mike Frysinger wrote: > On Monday, February 10, 2014 20:22:36 Chris Reffett wrote: > > This patch adds a --output-style option to repoman, which gives the user > > a choice of output formats for the repoman checks. Choices are "default" > > (current style) and "c

Re: [gentoo-portage-dev] [PATCH] Add --output-style option to repoman

2014-02-10 Thread Alec Warner
On Mon, Feb 10, 2014 at 2:57 PM, Chris Reffett wrote: > This patch adds a --output-style option to repoman, which gives the user > a choice of output formats for the repoman checks. Choices are "default" > (current style) and "column" (a greppable format), but it should be easy > to add more. Fix

Re: [gentoo-portage-dev] [RFC] Location of Portage bash API (outside of ebuilds)

2014-02-01 Thread Alec Warner
On Sat, Feb 1, 2014 at 12:08 PM, Arfrever Frehtes Taifersar Arahesis < arfrever@gmail.com> wrote: > bin/isolated-functions.sh contains at least 1 useful function, which could > be exposed for external consumers > (without __ prefix), but must have private name (with __ prefix) when > bin/isola

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 9:47 PM, Mike Frysinger wrote: > On Sunday 19 January 2014 11:59:36 Mike Gilbert wrote: > > On Sun, Jan 19, 2014 at 4:44 AM, Mike Frysinger > wrote: > > > Chromium OS for a long time was restricted to EAPI 4 for two reasons -- > > > it had an old portage version (and upgr

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 6:23 PM, Tom Wijsman wrote: > On Sun, 19 Jan 2014 04:38:31 -0500 > Mike Frysinger wrote: > > > On Friday 17 January 2014 18:03:57 Tom Wijsman wrote: > > > --- > > > > please shorten your commit summary and move more content to the body > > Right, I'm used to writing this

[gentoo-portage-dev] Patchworks test: ignore [eom]

2014-01-19 Thread Alec Warner

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 3:51 PM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 19/01/14 23:54, Alec Warner wrote: > > I'm very against add a bunch of extra rules that have to be > > enforced by hand. I want to make it

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:50 PM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 19/01/14 23:46, Alec Warner wrote: > > Does pylint or pyflakes point out if you mess it up? > Not very successfully in my experience. > I'm very

Re: [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:51 PM, W. Trevor King wrote: > On Sun, Jan 19, 2014 at 02:45:24PM -0800, Alec Warner wrote: > > On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner wrote: > > > This function and the next function you wrote are identical. How > > > abo

Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 19/01/14 22:22, Sebastian Luther wrote: > > The usual doc string style used in portage is: > > > > """ text """ > > > > Please use that for new functions. Also make sure you don't

Re: [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:14 PM, W. Trevor King wrote: > The current fetch() function is quite long, which makes it hard to > know what I can change without adverse side effects. By pulling this > logic out of the main function, we get clearer logic in fetch() and > more explicit input for the c

Re: [gentoo-portage-dev] [PATCH v2 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:44 PM, Alec Warner wrote: > On Sun, Jan 19, 2014 at 2:14 PM, W. Trevor King wrote: > >> The current fetch() function is quite long, which makes it hard to >> know what I can change without adverse side effects. By pulling this >> logic out of t

Re: [gentoo-portage-dev] [PATCH 3/3] pym/portage/package/ebuild/fetch.py: Factor out _get_uris

2014-01-19 Thread Alec Warner
On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King wrote: > The current fetch() function is quite long, which makes it hard to > know what I can change without adverse side effects. By pulling this > logic out of the main function, we get clearer logic in fetch() and > more explicit input for the c

Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869.

2014-01-19 Thread Alec Warner
On Sun, Jan 19, 2014 at 2:39 AM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 19/01/14 10:17, Mike Frysinger wrote: > > prefer OSes -> OS's > That's just not proper English. It makes no sense. Please don't prefer > that. If for nothing else, then to prevent

Re: [gentoo-portage-dev] [PATCH 2/3] emerge: Rename --autounmask-write to --autounmask

2014-01-18 Thread Alec Warner
It should be emerge --pretend --autounmask, but I'm not sure he implemented that bit. -A On Sat, Jan 18, 2014 at 6:14 PM, Mike Gilbert wrote: > On Sat, Jan 18, 2014 at 7:21 PM, Alexander Berntsen > wrote: > > Rename --autounmask-write to --autounmask. Please note that removing the > > option

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-16 Thread Alec Warner
On Thu, Jan 16, 2014 at 3:02 PM, Tom Wijsman wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I want to summarize our IRC conversation on the list. > On Thu, 16 Jan 2014 23:22:44 +0100 > Alexander Berntsen wrote: > > > Your ill-placed attempts at being clever are missing the point

Re: [gentoo-portage-dev] Signing off patches

2014-01-16 Thread Alec Warner
On Thu, Jan 16, 2014 at 5:20 AM, Alexander Berntsen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > We have quite a few dedicated developers now. To ensure that good > taste is exercised, and that best practices are followed, patches > should be signed. > I'm confused, are you prop

Re: [gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305).

2014-01-15 Thread Alec Warner
On Wed, Jan 15, 2014 at 5:07 PM, Jesus Rivero (Neurogeek) < neurog...@gentoo.org> wrote: > > On Jan 15, 2014 7:09 PM, "Tom Wijsman" wrote: > > > > --- > > bin/repoman | 8 > > man/repoman.1 | 3 +++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/bin/repoman b/bin/repoman >

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-15 Thread Alec Warner
On Wed, Jan 15, 2014 at 4:07 PM, Tom Wijsman wrote: > --- > bin/repoman | 53 + > man/repoman.1 | 4 > 2 files changed, 57 insertions(+) > > I urge you to not author new checks like this. /usr/bin/repoman is already a mess. Write these

Re: [gentoo-portage-dev] New proposed modular sync system

2014-01-09 Thread Alec Warner
On Thu, Jan 9, 2014 at 9:33 AM, Brian Dolbec wrote: > First off, I know many of you think portage needs to do everything on > it's own. NO outside dependencies. > > BUT! Please hear me out. > > While working on many of gentoo's tools gentoolkit's equery, eclean, > enalyze, Layman, mirrorselect,

Re: [gentoo-portage-dev] [PATCH] econf: update configure/config.{sub,guess} atomically to avoid races

2013-12-17 Thread Alec Warner
On Tue, Dec 17, 2013 at 6:53 PM, Greg Turner wrote: > On Tue, Dec 17, 2013 at 5:58 PM, Alec Warner wrote: > > Sed is already atomic > > > > antarus@goats5 /tmp/test $ cat foo > > Debian Rocks! > > antarus@goats5 /tmp/test $ strace -e trace=file sed -i -e &g

Re: [gentoo-portage-dev] [PATCH] econf: update configure/config.{sub,guess} atomically to avoid races

2013-12-17 Thread Alec Warner
On Tue, Dec 17, 2013 at 5:41 PM, Greg Turner wrote: > On Tue, Dec 17, 2013 at 3:28 PM, Mike Frysinger wrote: > > + sed -i \ > > + -e > "1s:^#![[:space:]]*/bin/sh:#!$CONFIG_SHELL:" \ > > + "${ECONF_SOURCE}/configure

Re: [gentoo-portage-dev] [PATCH] econf: update configure/config.{sub,guess} atomically to avoid races

2013-12-17 Thread Alec Warner
LGTM On Tue, Dec 17, 2013 at 4:26 PM, Brian Dolbec wrote: > On Tue, 2013-12-17 at 18:28 -0500, Mike Frysinger wrote: > > Use $BASHPID which will be unique even in subshells. > > > > URL: https://bugs.gentoo.org/487478 > > --- > > bin/phase-helpers.sh | 17 +++-- > > 1 file changed,

  1   2   3   >