dbs = [vardb]
> if "--usepkgonly" not in
> self._frozen_config.myopts:
> - dbs.append(portdb)
> +
> dbs.append(IndexedPortdb(portdb) if search_index else portdb) if
> "--usepkg" in self._frozen_config.myopts:
> + # bindbapi is indexed
> dbs.append(bindb)
>
> matches = similar_name_search(dbs,
> atom)
looks good
--
Brian Dolbec
abled. Since extract_affecting_use doesn't distinguish between
> positive and negative effects (flag? vs. combinations, then don't
> bother to explore any of them.
>
> X-Gentoo-Bug: 555698
> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=555698
> ---
>
T
? At least
it wouldn't be adding directly to something that already could use a
little refactoring. /me cringes at what repoman is...
> #We iterate over all possible settings of
> these use flags and gather #a set of possible changes
> #TODO: Use the information encoded in
> REQUIRED_USE
--
Brian Dolbec
rt = True
> return 0, myfavorites
>
> - pkg = self._pkg(mykey, "binary",
> root_config,
> - onlydeps=onlydeps)
> args.append(PackageArg(arg=x,
> package=pkg, root_config=root_config))
> elif ext==".ebuild":
looks fine :)
--
Brian Dolbec
nd we will
> provide binary pkgs.
>
> Any ideas welcome :)
>
> Jocke
I see you've been getting good responses to your gentoo-dev copy of
this email... :)
We have nothing extra to offer. As was stated, portage was not
designed for speciality config management.
--
Brian Dolbec
, 11 deletions(-)
>
Merged, thanks :)
--
Brian Dolbec
> +++ b/bin/isolated-functions.sh
> @@ -121,6 +121,7 @@ __helpers_die() {
> }
>
> die() {
> + set +x # tracing only produces useless noise here
> local IFS=$' \t\n'
>
> if ___eapi_die_can_respect_nonfatal; then
Looks good
--
Brian Dolbec
to add (default is 1)
> + @type n: int
> + @rtype: int or _UNREACHABLE_DEPTH
> + @return: depth + 1 or _UNREACHABLE_DEPTH
> + """
> + return depth + n if isinstance(depth, int) else depth
>
> def _equiv_ebuild_visible(self, pkg, autounmask_level=None):
> try:
looks good.
When you first submitted that earlier patch that this fixes. I
scratched my head about the mismatched types which seemed to work
anyway.
--
Brian Dolbec
On Tue, 14 Jul 2015 13:04:00 -0700
Brian Dolbec wrote:
> On Tue, 14 Jul 2015 12:56:34 -0700
> Zac Medico wrote:
>
> > On Tue, Jul 14, 2015 at 12:52 PM, Zac Medico
> > wrote:
> > > This fixes an issue with SyncLocalTestCase hanging on my system.
> > > --
; --
> > 2.3.6
> >
>
> I'm not sure if this is really the correct fix. Is there supposed to
> be a None 'sync-rsync-extra-opts' value in module_specific_options?
>
I don't think so, that may have been my fault when I sent Etiene my
partial rework on his patches.
--
Brian Dolbec
artree.dbapi.match_pkgs("=%s" % (pkg.cpv,)):
> + for cpv_match in
> self._fake_vartree.dbapi.match_pkgs(Atom("=%s" % (pkg.cpv,))): if
> cpv_match.cp == pkg.cp: self._fake_vartree.cpv_discard(cpv_match)
> for slot_match in
> self._fake_vartree.dbapi.match_pkgs(pkg.slot_atom):
LGTM
--
Brian Dolbec
preserved.
> - find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
> - ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
> + find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
> + -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
> }
>
> econf() {
Merged, Thanks
--
Brian Dolbec
l)
>
> + if self.cgroup is not None:
> + try:
> + shutil.rmtree(self.cgroup)
> + except EnvironmentError as e:
> + if e.errno != errno.ENOENT:
> + raise
> +
> if self._exit_timeout_id is not None:
> self.scheduler.source_remove(self._exit_timeout_id)
> self._exit_timeout_id = None
Looks good, merge away :)
--
Brian Dolbec
On Mon, 6 Jul 2015 11:28:36 -0700
Brian Dolbec wrote:
> hmm, this is the cvs module's module_spec, I was thinking we might be
> able to add the module_specific_opts there after the validate_config
> definition, like so:
>
> module_spec = {
> 'name':
On Thu, 18 Jun 2015 23:32:27 +0200
Étienne Buira wrote:
> Hi, thank you for reviewing
>
> On Wed, Jun 17, 2015 at 01:32:17PM -0700, Brian Dolbec wrote:
> > Be aware that I have not read over the diff very much yet.
> >
> > On Wed, 17 Jun 2015 20:40:30 +02
e required options) can be added for any module without the
need to change this. Those options are not used anywhere else other
than the sync module.
One method might be to replace the copying of the configparser options
into python variables. Instead change it to look for the option in the
configparser instance. And only maintain some base options or
functions which pull from the config instance.
--
Brian Dolbec
f this one? I don't recall many responses to
the -dev thread.
--
Brian Dolbec
modules[name],
> attr_name) +
> object.__setattr__(self, '_target', target)
> object.__getattribute__(self, '_scope')[
> object.__getattribute__(self, '_alias')] =
> target
confirmation of approval... already pushed.
--
Brian Dolbec
re__ import unicode_literals
> +from __future__ import absolute_import, unicode_literals
>
> __all__ = ['movefile']
>
confirmation of approval... already pushed ;)
--
Brian Dolbec
; https://secure.plaimi.net/~alexander
That's fine, commit the simple port, make other changes in later
commits.
--
Brian Dolbec
r convert
all leading spaces to tabs. I don't look for odd cases like the above.
But I will usually take note of them in the commit diff while making the
commit.
Personally, I'd prefer you stay with tabs, even if it does not
line up exactly with the ( ignoring personal preferences for
ta
ymore already.
> >
> > If it turns out we want to support this scenario, we can do it via a
> > bunch of bootstrapping (and symlinked) files.
> > ---
>
> LGTM
Yeah, it's good.
Sorry it's taken so long for me to review...
--
Brian Dolbec
viRSY6xNsSvYHcf4ur
> AWA+iabRFSU84L/4eA2S
> =bMAj
> -END PGP SIGNATURE-
>
sorry, my bad :/
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJVbOMBXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1h
with this change, it'd be:
> $ runtests --python-version 'python2.7 python3.3'
>
> we could add some logic so that if the arg is composed of dots &
> digits, we'd blindly prefix it with "python".
> -mike
Well, that get's back to almost the same kind of
get_python_executable(). But I think it would be a little better than
the existing.
We could instead do a string search and include any
member with that substring. That would include python3.3 and
foo-bar-3.3 for a 3.3 cli entry. It could make for a more flexible cli
versions = []
for y in args.python_versions:
versions.extend([x for x in all_pythons if y in x])
--
Brian Dolbec
THON_SUPPORTED_VERSIONS = [
'python2.7',
'python3.3',
'python3.4',
]
# The rest are just "nice to have".
PYTHON_NICE_VERSIONS = [
'pypy',
'python3.5',
'foo-bar-7.6',
]
Then all that is needed in get_python_executable() is the final path.
No other future code changes are likely to be needed.
Also easier to override from the environment without editing code.
PYTHON_NICE_VERSIONS="exp-py" runtests...
otherwise looks good.
--
Brian Dolbec
nt package, you could make a pkgcore sync module
for it as well and add IUSE flags for each package manager.
--
Brian Dolbec
Portage, Layman, Gentoo-keys Lead developer
gt; \fB-q\fR, \fB--quiet\fR
> Be less verbose about extraneous info
> .TP
Thanks, both commits look good.
I'll push them in a little while.
--
Brian Dolbec
X-Gentoo-Bug: 549826
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=549826
X-Gentoo-forums: https://forums.gentoo.org/viewtopic-t-1017380.html
---
pym/portage/sync/modules/rsync/rsync.py | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/pym/portage/sync/modules
Check if self.location is writable, or permissions
> are sufficient
> + to create it if it does not exist yet.
> + @rtype: bool
> + @return: True if self.location is writable or can be
> created,
> + False otherwise
> + """
> + return os.access(first_existing(self.location),
> os.W_OK) +
> @staticmethod
> def _read_valid_repo_name(repo_path):
> name, missing = RepoConfig._read_repo_name(repo_path)
Yeah, looks good
--
Brian Dolbec
self.missing_repo_name = False
>
> for value in ('allow-missing-manifest',
> 'allow-provide-virtual',
> 'cache-formats',
Yeah, merge please
Wasn't there a bug for this? If there is pleas add the bug # to the
commit message
--
Brian Dolbec
wconf,
> mrgconf): stat.S_ISLNK(mystat.st_mode)):
> # Save off new config file in the archive dir
> with .dist.new suffix newconf_archive = archive + '.dist.new'
> + if os.path.isdir(newconf_archive
> + ) and not os.path.islink(newconf_archive):
> + _file_archive_rotate(newconf_archive)
> _archive_copy(mystat, newconf, newconf_archive)
>
> ret = 0
> @@ -325,4 +391,7 @@ def rcs_archive_post_process(archive):
> def file_archive_post_process(archive):
> """Rename the archive file with the .dist.new suffix to
> a .dist suffix""" if os.path.lexists(archive + '.dist.new'):
> - os.rename(archive + '.dist.new', archive + '.dist')
> + dest = "%s.dist" % archive
> + if os.path.isdir(dest) and not os.path.islink(dest):
> + _file_archive_rotate(dest)
> + os.rename(archive + '.dist.new', dest)
looks good
--
Brian Dolbec
if
> (cached_cpv.startswith(delta["package"]) and
> + metadata.get("SLOT")
> == delta["slot"] and
> +
> cpv_getkey(cached_cpv) == delta["package"]):
> + removed = True
> + break
> +
> + if removed:
> + del packages[cached_cpv]
> + del deltas[cpv]
> + if not deltas:
> + break
looks good
--
Brian Dolbec
On Wed, 06 May 2015 10:39:26 -0700
Zac Medico wrote:
> On 04/28/15 18:48, Zac Medico wrote:
> > On 04/28/2015 05:07 PM, Brian Dolbec wrote:
> >> On Sat, 25 Apr 2015 13:37:10 -0700
> >> Zac Medico wrote:
> >>
> >>> Python's formatter mo
On Sun, 03 May 2015 23:37:52 -0700
Zac Medico wrote:
> On 05/03/2015 11:25 PM, Brian Dolbec wrote:
> > Isn't this backwards from what was reported. It generated a
> > UnicodeDecodeError when using additional args to unicode().
>
> It was actually a TypeError.
>
if proc is not None:
Isn't this backwards from what was reported. It generated a
UnicodeDecodeError when using additional args to unicode(). It needed
to convert it to string so errors= needed to not be passed in.
--
Brian Dolbec
msg =
> error_leader() + msg
> + writemsg(msg + "\n",
> noiselevel=-1)
> + return ""
> +
> braced = True
> else:
> braced = False
Yeah, good idea, looks good.
--
Brian Dolbec
x in
> portage.util.shlex_split(self.env.get("PORTAGE_XATTR_EXCLUDE", "")):
> +
> tar_options.append(portage._shell_quote("--xattrs-exclude=%s" % x))
> + tar_options = " ".join(tar_options)
>
> decomp_cmd = _decompressors.get(
> compression_probe(self.pkg_path))
Merge please :)
--
Brian Dolbec
6 files changed, 42 insertions(+), 7 deletions(-)
>
patch looks good :)
--
Brian Dolbec
r(a)+"\n",
> - level=logging.ERROR, noiselevel=-1)
> + self._elog("eerror", "postinst", [
> + _("FAILED postinst: %s") % (a,),
> + ])
>
> #update environment settings, library paths. DO NOT
> change symlinks. env_update(
looks fine :)
--
Brian Dolbec
msg.append(_("Searching all installed"
> " packages for files installed via above
> symlink(s)...")) msg.append("")
Merge it please :)
--
Brian Dolbec
> pym/portage/util/formatter.py
>
>
Is this really the best way to deal with the deprecation for py3.6+ ???
I have been getting these for some time, but I have not looked at the
way to change it yet.
--
Brian Dolbec
gt; addCP_matches = []
> - for mytype, match in self.matches.items():
> - addCP_matches.append(mytype, match)
> + for mytype, matches in self.matches.items():
> + for match in matches:
> +
> addCP_matches.append((mytype, match)) iterator = iter(addCP_matches)
>
> else:
Looks good
--
Brian Dolbec
E_IUSE} ]] && \
> - ! has test ${USE} ; then
> - export USE="${USE} test"
> - fi
> -
> local save_sp=${SANDBOX_PREDICT}
> addpredict /
> __ebuild_phase pre_src_test
Looks good
--
Brian Dolbec
ction(ro_filesystems, set(dir_list))
> + ro_devs = {}
> + for x in ro_filesystems:
> + try:
> + ro_devs[os.stat(x).st_dev] = x
> + except OSError:
> + pass
> +
> + ro_filesystems.clear()
> + for x in set(dir_list):
> + try:
> + dev = os.stat(x).st_dev
> + except OSError:
> + pass
> + else:
> + try:
> + ro_filesystems.add(ro_devs[dev])
> + except KeyError:
> + pass
> +
> + return ro_filesystems
>
>
> def empty_ro_checker(dir_list):
looks fine
--
Brian Dolbec
fi
> fi
>
> +# Filter internal portage paths from PATH, in order to avoid
> +# a possible exec loop or fork bomb (see bug 547086).
> +IFS=':'
> +set -f
> +path=
> +for x in ${PATH}; do
> + [[ ${x} == ${PORTAGE_OVERRIDE_EPREFIX}/usr/lib*/portage/* ]]
> && continue
> + [[ ${x} == */._portage_reinstall_.* ]] && continue
> + path+=":${x}"
> +done
> +PATH=${path#:}
> +
> if [[ "${implementation}" == "c" ]]; then
> exec "${INSTALL_XATTR}" "$@"
> elif [[ "${implementation}" == "python" ]]; then
looks good
--
Brian Dolbec
On Thu, 23 Apr 2015 10:38:24 -0700
Zac Medico wrote:
> On 04/23/2015 09:01 AM, Brian Dolbec wrote:
> > This bug caused great difficulty in determining the cause of the
> > error message. This adds identifying code which states where the
> > error message is coming from. It
This bug caused great difficulty in determining the cause of the error message.
This adds identifying code which states where the error message is coming from.
It also adds the actual source which caused the error message in the first
place.
X-Gentoo-Bug: 542796
X-Gentoo-Bug-url: https://bugs.gent
erify_eapi=False, eapi=None, eapi_default="0"):
> """ Does the same thing as grabdict except it validates keys
> @@ -438,7 +442,7 @@ def grabdict_package(myfilename, juststrings=0,
> recursive=0, atoms = {}
> for filename in file_list:
> d = grabdict(filename, juststrings=False,
> - empty=True, recursive=False,
> incremental=True)
> + empty=True, recursive=False,
> incremental=True, newlines=newlines) if not d:
> continue
> if verify_eapi and eapi is None:
yeah, LGTM
--
Brian Dolbec
bin_path,
> "ebuild-helpers", "bsd"))
> + for x in portage_bin_path:
> + path.append(os.path.join(x,
> "ebuild-helpers", "bsd"))
> - path.append(os.path.join(portage_bin_path, "ebuild-helpers"))
> + for x in portage_bin_path:
> + path.append(os.path.join(x, "ebuild-helpers"))
> path.extend(prerootpath)
>
> for prefix in prefixes:
LGTM
--
Brian Dolbec
R {} \; >/dev/null 2>&1
> > + -print0 2> /dev/null \
> > + | sort \
>
> sort -z
>
> Maybe also set LANG=C for locale independence?
>
Looks good, Zac can you just edit those changes in while you merge it
please.
--
Brian Dolbec
try:
> + os.makedirs(self.repo.location)
> + except OSError as e:
> + if e.errno != errno.EEXIST:
> + raise
> +
> + if can_mount:
> + ret = portage.process.spawn(mount_cmd)
> + if ret != os.EX_OK:
> + logging.warning('Unable to
> (re-)mount SquashFS after update') +
> + return (0, True)
Overall the code itself looks decent. Aside from the small mistake
mentioned inline, my only concern is the sheer size of the sync(). It
is 162 lines and embeds 2 private functions. This code could easily be
broken up into several smaller task functions. It would make reading
the main sync() logic easier as well as the smaller task sections. I
am not a fan of the long winded functions and scripts present in
portage (this by no means is in the same category as many of those).
But I certainly don't want to let more of that in if I can help it. And
aim to reduce it while I'm the lead.
Ok, so the only data variable you wanted to add to the repos.conf was
the cache location?
I'll work on adding the gkeys integration in the gkeys branch I started
for the gpg verification. I see no point in porting the code from
emerge-webrsync's bash to python only to be replaced by gkeys in the
very near future. Please stub out a function & call for it when you
address the above issues. I'll fill in the code for it.
--
Brian Dolbec
n this
> metadata_dtd_ctime_interval = 60 * 60 * 24 * 7 # 7 days
>
Hmm, I thought that was being moved to api.gentoo.org. I just checked
and it isn't there...
I want to verify that it isn't destined there in the very near future.
--
Brian Dolbec
") is not None
> + and
> mystat.st_size < mydigests[myfile]["size"]
> + and
> not restrict_fetch): fetched = 1 # Try to resume this download.
> elif
> parallel_fetchonly and \ mystat.st_size == mydigests[myfile]["size"]:
OK :) merge please
--
Brian Dolbec
nt directories of the
> prefix (see bug 544624).
> +
> dirlist.append(os.path.join(destroot, relative_path))
> for fname in files:
> try:
LGTM
--
Brian Dolbec
On Fri, 3 Apr 2015 11:52:39 + (UTC)
Duncan <1i5t5.dun...@cox.net> wrote:
> Brian Dolbec posted on Thu, 02 Apr 2015 23:59:06 -0700 as excerpted:
>
> > This is a reminder to you all... since enalyze is little known to
> > users.
>
> Thanks for the hint. I'
rebuild module can create new pkg.* files for
you to maintain the installed state. Allowing you to easily make
make.conf USE= changes or profile changes and have your pkg.* files
fixed to match. Of course detailed comments it does not do ;)
plus it saves the new file to your user space, you can do what you like
with them from there. Editing your detail commented files to match,
etc.. stright swap,...
--
Brian Dolbec
i._instance_key(mynewcpv)]
> = new_path[len(self.pkgdir)+1:] if new_path != mytbz2:
> self._ensure_dir(os.path.dirname(new_path))
> _movefile(tbz2path, new_path,
> mysettings=self.settings)
merge it please :)
--
Brian Dolbec
yword)
> + if stable_keywords:
> + if ebuild_path in new_ebuilds and
> catdir != "virtual":
> + stable_keywords.sort()
> + stats["KEYWORDS.stable"] += 1
> +
> fails["KEYWORDS.stable"].append(
> + relative_path + "
> added with stable keywords: %s" % \
> + "
> ".join(stable_keywords))
> ebuild_archs = set(kw.lstrip("~") for kw in keywords
> \ if not kw.startswith("-"))
LGTM thanks
--
Brian Dolbec
sions of the tree which are signed in total
(emerge-webrsync) and verify-able.
As has been pointed out the other thread [3] which was started just
before this one. We are in a different place than what the binary
distributions are in terms of repositories. Not all attack vectors
your code is meant to address applies to our situation.
I do think your repository manifest was something that robbat2 had
talked about implementing for overlay maintainers as an option for
layman to be able to verify updates to the overlay repos. It would
likely have to be generated from a VCS hook which runs when commits are
made/pushed.
I'd love to hear how your code can fit in to the Gentoo system.
links:
[1] http://gitweb.gentoo.org/proj/gentoo-keys.git/
gkeys article in LWN: http://lwn.net/Articles/634777/
[3]
http://archives.gentoo.org/gentoo-portage-dev/message/bda425ee6c676ec7a6b3c9500a9b00bf
--
Brian Dolbec
blems,... There were a few
individuals that raised such a stink about it, they even brought it to
council to have us STOPPED.
So, as a result much of the portage team don't feel like working on
portage. Heaven forbid we actually make a change!
>
> Will --depclean with --dynamic-deps=n always succeed? I realize that
> it could be dangerous but sometimes would like to have the option.
>
>
> BTW, this text is hard to parse:
> --binpkg-changed-deps [ y | n ]
> Tells emerge to ignore binary packages for which the
> corresponding ebuild depen‐ dencies have changed since the packages
> were built. In order to help avoid issues with resolving
> inconsistent dependencies, this option is automatically enabled
> unless the --usepkgonly option is enabled. Behavior with
> respect to changed build-time dependencies is controlled by the
> --with-bdeps option.
>
> --binpkg-changed-deps=y -> Ignore bin pkgs with changed deps?
--
Brian Dolbec
> proposal that requires more administrative work on the repository,
> > but provides more security protections, is also available
> > <https://www.python.org/dev/peps/pep-0480/>.
> >
> > Thanks,
> > Vlad
> >
> > P.S.
> > There is an informational Gentoo Linux Enhancement Proposal that
> > references the security issues that our project addresses, but
> > there hasn't been much recent activity.
> >
> >
> > --
> > vladimir.v.d...@gmail.com
> > PGP fingerprint = ACCF 9DCA 73B9 862F 93C5 6608 63F8 90AA 1D25 3935
> > --
> >
>
>
--
Brian Dolbec
/dispatch-conf.conf
> +++ b/cnf/dispatch-conf.conf
> @@ -31,7 +31,7 @@ diff="diff -Nu '%s' '%s'"
> pager=""
>
> # Default options used if less is the pager
> -less-opts="--no-init --QUIT-AT-EOF"
> +less-opts="--no-init --q
lf._pkgset, self._setset))
>
> def lock(self):
LGTM, don't know if it fixes it, but you are the expert there ;)
--
Brian Dolbec
On Sat, 07 Mar 2015 18:31:44 -0800
Zac Medico wrote:
> On 03/07/2015 05:24 PM, Brian Dolbec wrote:
> > On Sat, 07 Mar 2015 15:26:26 -0800
> > Zac Medico wrote:
> >
> >> On 03/06/2015 09:50 AM, Mark Kubacki wrote:
> >>> We're on the same side h
for portage very soon which uses gkeys libs
to verify the Manifests. gkeys- is able to verify the Manifest
files now if the gentoo-devs keys are installed.
Main questions for now is. Do we want to have a post sync hook that
checks the tree for invalid Manifest sigs? Or do we just have it
verify the manifest for the pkg at build/merge time? Or both?
--
Brian Dolbec
nc method. There will still be an
alternate authentication method on the package level. There are other
steps being taken as well in other areas of the tree handling and
building as well, but portage verifying the Manifest file is the next
step being taken with gentoo-keys.
What Zero did not mention was that a user can independently verify the
gpg signature of each Manifest file now. The developer gpg keys are
listed and available. The gentoo-keys project is just automating the
whole process.
--
Brian Dolbec
pgptE3LOBsDPs.pgp
Description: OpenPGP digital signature
t; pym/portage/tests/resolver/binpkg_multi_instance/__test__.py create
> mode 100644
> pym/portage/tests/resolver/binpkg_multi_instance/test_build_id_profile_format.py
> create mode 100644
> pym/portage/tests/resolver/binpkg_multi_instance/test_rebuilt_binaries.py
>
This 7 series looks fine. With 2.2 18 released, cleared to merge :)
Thanks
--
Brian Dolbec
# function creates a private PORTAGE_TMPDIR.
> try:
> proxy = get_socks5_proxy(mysettings)
> except NotImplementedError:
LGTM ... now for me to finish some things so I can actually get the the
release done...
--
Brian Dolbec
if portage._not_installed:
> make_globals_path =
> os.path.join(PORTAGE_BASE_PATH, "cnf", "make.globals")
LGTM, merge please :)
--
Brian Dolbec
On Sat, 28 Feb 2015 16:11:56 -0800
Brian Dolbec wrote:
> As recommended by Duncan on the gentoo-portage-dev list.
> Clarify the all command.
> Add OPTIONS to all commands, so a user can determine which modules
> may run when the 'all' command is used.
> Remove repetitiv
As recommended by Duncan on the gentoo-portage-dev list.
Clarify the all command.
Add OPTIONS to all commands, so a user can determine which modules
may run when the 'all' command is used.
Remove repetitive '(* command only)' text by adding it to the section header.
---
man/emaint.1 | 43
mtime = vcs in ('cvs', None)
vcs_local_opts = repoman_settings.get("REPOMAN_VCS_LOCAL_OPTS", "").split()
vcs_global_opts = repoman_settings.get("REPOMAN_VCS_GLOBAL_OPTS")
--
Brian Dolbec
ed in
> \fBPKGDIR\fR. .TP
> @@ -82,6 +85,7 @@ than rsync.
> Please report bugs via http://bugs.gentoo.org/
> .SH AUTHORS
> .nf
> +Pavel Kazakov
> Mike Frysinger
> Brian Dolbec
> .fi
You forgot to add the merges tracking file to the FILES section
--
Brian Dolbec
,
> "--pretend")) and \
> + ("--fetchonly", "--fetch-all-uri",
> + "--pretend", "--usepkgonly")) and \
> (any("buildpkg" in
> trees[eroot]["root_config"]. settings.features for eroot in trees) or
> any("buildsyspkg" in
> trees[eroot]["root_config"].
LGTM
--
Brian Dolbec
"?":
That was fast. I didn't think you were even online last
night ;) I was going to look at it closer this morning, figured it
would be something like this to fix.
LGTM, merge please
--
Brian Dolbec
ge/sets.conf\fR, both
> of +which override values set here. Default set configurations are
> installed +in \fB/usr/share/portage/config/sets/portage.conf\fR.
> +.RE
> +.TP
> .BR /var/cache/edb/
> .RS
> This directory is used to store internal portage cache files. The
> names and
looks good :) Thank you
--
Brian Dolbec
= cvstree.findchanged(mycvstree, recursive=1,
> basedir="./") mynew = cvstree.findnew(mycvstree, recursive=1,
> basedir="./")
Looks good, merge please :)
--
Brian Dolbec
'--ask',
> '--quiet',
> '--oneshot',
> '--complete-graph=y'
LGTM, merge please :)
--
Brian Dolbec
On Tue, 17 Feb 2015 11:37:44 -0800
Zac Medico wrote:
> On 02/17/2015 10:58 AM, Brian Dolbec wrote:
> >
> > class Atom()
> >
> > if allow_repo is None:
> > allow_repo = True
> > +
On Tue, 17 Feb 2015 11:26:27 -0800
Zac Medico wrote:
> On 02/17/2015 10:42 AM, Brian Dolbec wrote:
> >
> > overall, there is no way I know the code well enough to know if you
> > screwed up. But the code looks decent, so...
> >
> > My only questions are:
>
de 100644
> pym/portage/tests/resolver/binpkg_multi_instance/test_build_id_profile_format.py
>
class Atom()
if allow_repo is None:
allow_repo = True
+ if allow_build_id is None:
+ allow_build_id = True
these can be written as
allow_repo = allow_repo or True
allow_build_id = allow_build_id or True
Otherwise looks decent.
--
Brian Dolbec
else:
mtime = None
I hate repeating code. This can be done using one universal small
function and will clean up the __init__()
@static_method
def _long(var, default):
if var is not None:
try:
var = long(var)
except ValueError:
if var:
var = -1
else:
var = default
return var
--
Brian Dolbec
net/~alexander
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v2
>
> iF4EAREIAAYFAlTjWBYACgkQRtClrXBQc7V3CgEAjREJrZasgGrfP0fIdo7/oKZ7
> /dMazIA2rnu6+CfeLlABAI9kc06NR2msTo4a1XTq6dxzSIrgqXIYxBfy/oDNY+rh
> =Fl7x
> -END PGP SIGNATURE-----
>
SURE! just reply to the EAS
for atom in atoms:
> + atom_not_selected = False
>
> if not atom.package:
> unevaluated_atom = None
LGTM
--
Brian Dolbec
("%s" % number)
> formatter.pop_style()
> - if category not in qawarnings:
> - formatter.add_literal_data(" [fatal]")
> formatter.add_line_break()
> if not dofull:
> if not full and dofail and category in
> qawarnings:
Works for me. merge approved
--
Brian Dolbec
On Sat, 7 Feb 2015 17:30:42 +
Joakim Tjernlund wrote:
> On Sat, 2015-02-07 at 09:17 -0800, Brian Dolbec wrote:
> > Joakim, email pam-bugs directly. Not the portage-dev list please.
>
> I think you are misunderstanding me. The PAM problem is just an
> example which ma
utomatically when cross building. Comments?
>
> Jocke
Sorry, but this list is for portage, the package manager development,
not portage tree ebuilds. I have been trying to get people to refer to
the tree as the gentoo tree (same as the repo name) to help avoid this
confusion.
This should be submitted to bugzilla, where it will be assigned to the
pam maintainer.
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Thu, 05 Feb 2015 15:51:34 +0100
Alexander Berntsen wrote:
> On 18/01/15 17:33, Brian Dolbec wrote:
> > Yeah, just move this to sorted order like Arfrever said. Otherwise
> > it looks good, ready to merge.
> Friends,
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
sys-apps/portage-2.2.16 is ready for release and is just waiting for the
news announcement about the new plug-in sync system being used and the
changes in it's operation.
Attached is the news announcement for review.
- --
Brian D
d connection. Relay incoming data
> + to the client.
> + """
> +
Just missing the function @params
otherwise is good to go
--
Brian Dolbec
attempt.
> - locking_method = _default_lock_fn
> + locking_method =
> portage._eintr_func_wrapper(_default_lock_fn) try:
> if "__PORTAGE_TEST_HARDLINK_LOCKS" in os.environ:
> raise IOError(errno.ENOSYS, "Function not
> implemented")
Looks good
--
Brian Dolbec
y/redundant feeling.
> >
> > Perhaps better would be "'eselect news read' to view new items"? ie.
> > view instead of the second read.
>
> Yeah, that's much better.
Committed and pushed this last version.
Thank you Toralf
--
Brian Dolbec
On Thu, 29 Jan 2015 11:45:18 -0800
Brian Dolbec wrote:
>
> From mgorny's recent suggestions and bug report...
> Plus a final pyflakes cleanup.
>
>
pushed with suggested change for has_bin
--
Brian Dolbec
gt; How about using the struct module instead of reinventing the wheel?
>
> Well the versions that I wrote seem a lot more readable to me than
> they would be if written using things like struct.unpack_from(" data)[0]. Either way is fine with me, though. Google seems to show
> some issues with struct import failing for broken python
> installations, but that should not be an issue in practice.
broken python is not reliable then anyway...
I think I like the struct idea better.
--
Brian Dolbec
---
pym/portage/sync/modules/cvs/cvs.py | 1 -
pym/portage/sync/modules/git/git.py | 6 --
pym/portage/sync/modules/svn/svn.py | 5 ++---
pym/portage/sync/modules/websync/websync.py | 4
4 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/pym/portage/sy
>From mgorny's suggestion, rename _sync() to update().
Raise NotImplementedError in base classes.
Directly override sync() in websync module.
Fix up line spacing to be consistent.
---
pym/portage/sync/modules/cvs/cvs.py | 10 +++---
pym/portage/sync/modules/git/git.py | 8 ++---
p
This avoids that self.logger is None error in the __init__().
---
pym/portage/sync/syncbase.py | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/pym/portage/sync/syncbase.py b/pym/portage/sync/syncbase.py
index c820bcf..973d545 100644
--- a/pym/portage/s
>From mgorny's recent suggestions and bug report...
Plus a final pyflakes cleanup.
ss variables should also be changed to instance variables.
Yeah, I meant to ask you the same... Do they need to be class wide
(multiple instances refer to the same exact variables) or just instance
wide ones. But I hadn't looked it over in enough detail yet.
And LOOSE the _my prefix.
--
Brian Dolbec
+1,4 @@
> -TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
> +.TH "PORTAGE" "5" "Jan 2015" "Portage VERSION" "Portage"
> .SH NAME
> portage \- the heart of Gentoo
> .SH "DESCRIPTION"
yes, fix it please :)
--
Brian Dolbec
301 - 400 of 1006 matches
Mail list logo
