From 6ead9b76de648747ae72ac572768ca1f464ff23e Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Sat, 30 Apr 2016 08:55:41 -0700
Subject: [PATCH] repoman: Fix unsupported eapi continuing with remaining
checks. bug 581600
Tighten up the xpkg loop and the use of the xpkg_continue bolean for
On Sun, 24 Apr 2016 15:04:57 -0700
Zac Medico wrote:
> On 04/24/2016 02:45 PM, Zac Medico wrote:
> > On 04/24/2016 01:00 AM, Brian Dolbec wrote:
> >> On Sun, 24 Apr 2016 08:15:56 +0200
> >> Michał Górny wrote:
> >>
> >>> On Sat, 23
But this step did prove the basic tightened up modules data interface.
And debugged the initial conversion, so I'll be coding the rest of the
conversion in the morning. Then I'll apply your xml patches.
--
Brian Dolbec
pgpXCUQyyOHUM.pgp
Description: OpenPGP digital signature
t; pym/repoman/scanner.py | 8 +- 12 files
> changed, 591 insertions(+), 172 deletions(-) delete mode 100644
> cnf/metadata.dtd create mode 100644 cnf/metadata.xsd
>
Thank you
--
Brian Dolbec
class UnusedCheck(object):
> @param xpkg: the pacakge being checked
> @param muselist: use flag list
> @param used_useflags: use flag list
> - @param validity_fuse: Fuse instance
> + @param validity_future: Future instance
> '''
> xpkg = kwargs.get('xpkg')
> muselist = kwargs.get('muselist')
> used_useflags = kwargs.get('used_useflags')
> + try:
> + valid_state =
> kwargs['validity_future'].result()
> + except InvalidStateError:
> + valid_state = True
> # check if there are unused local USE-descriptions
> in metadata.xml # (unless there are any invalids, to avoid noise)
> - if kwargs.get('validity_fuse'):
> + if valid_state:
> for myflag in
> muselist.difference(used_useflags): self.qatracker.add_error(
> "metadata.warning",
> diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py
> index a9f56e9..e9a8e20 100644
> --- a/pym/repoman/scanner.py
> +++ b/pym/repoman/scanner.py
> @@ -9,7 +9,7 @@ import portage
> from portage import normalize_path
> from portage import os
> from portage.output import green
> -from repoman.fuse import Fuse
> +from portage.util.futures import Future
> from repoman.modules.commit import repochecks
> from repoman.profile import check_profiles, dev_profile_keywords,
> setup_profile from repoman.repos import repo_metadata
> @@ -232,7 +232,7 @@ class Scanner(object):
> 'repolevel': self.repolevel,
> 'catdir': catdir,
> 'pkgdir': pkgdir,
> - 'validity_fuse': Fuse()
> + 'validity_future': Future()
> }
> # need to set it up for ==> self.modules or
> some other ordered list for mod in ['Manifests', 'IsEbuild',
> 'KeywordChecks', 'FileChecks',
Yeah, it's sat long enough with me to be fine with it this way, it is
more flexible to handle both default states but only in the code it is
used in. It also can work for strings and any other data that isn't
normally an instance pointer.
Push it and I'll use Future() for those where it is needed in the
module_spec func_kwargs.
--
Brian Dolbec
8 @@ class GenChangeLogs(object):
> # -r (recursive) to get per-file changes
> # then the commit-id and path.
>
> - cinfo = self.grab(['git', self._work_tree,
> 'diff-tree',
> + cinfo = self.grab(['git', self._work_tree,
> 'diff-tree']
> + + list(self._GIT_LOG_OPTS) +
> [ '--name-status',
> '--no-renames',
> '--format=%ct %cN <%cE>%n%B',
It looks good to me, but I'd like to hear from Doug first, just to be
sure...
--
Brian Dolbec
On Fri, 8 Apr 2016 00:29:40 -0700
Zac Medico wrote:
> On 04/07/2016 11:51 PM, Brian Dolbec wrote:
> > the above looks good, but what about:
> >
> >
> > [19:01] just use --first-parent
> > [19:01] also take into account merge commits
> > [19:03] git
-format=%ct -1 .
[19:06] so just add the --first-parent option?
[19:07] you want -m toolmod = self.grab(['git',
self._work_tree, 'log', '--format=%ct', '-1', '.'])
[19:06] git log -m --first-parent --format=%ct -1 .
[19:06] so just add the --first-parent option?
[19:07] you want -m too
Don't we need to add the -m --first-parent ???
--
Brian Dolbec
x27;stdio']) + ' KiB')
looks good. Also if you haven't looked at the forum thread again.
Portage did not fail when he set python 2.7 as the active one. So it
is 3.4 only that is failing for him (just those 2 installed).
--
Brian Dolbec
On Tue, 15 Mar 2016 14:03:41 -0700
Zac Medico wrote:
> On 03/15/2016 01:57 PM, Brian Dolbec wrote:
> > On Tue, 15 Mar 2016 13:31:24 -0700
> > Zac Medico wrote:
> >
> >>>
> >>> Also, now that we are using Fuse, can't we stop returning t
or patch. It looks like it is
not valid for the cvs and svn modules now that they are separate
modules.
--
Brian Dolbec
On Mon, 14 Mar 2016 17:18:27 -0700
Zac Medico wrote:
> On 03/14/2016 10:52 AM, Brian Dolbec wrote:
> > On Mon, 14 Mar 2016 10:22:11 -0700
> > Zac Medico wrote:
> >
> >> On 03/14/2016 10:14 AM, Zac Medico wrote:
> >>> On 03/05/2016 01:37 PM, Bria
On Mon, 14 Mar 2016 10:35:26 -0700
Brian Dolbec wrote:
> On Mon, 14 Mar 2016 10:14:15 -0700
> Zac Medico wrote:
>
> > On 03/05/2016 01:37 PM, Brian Dolbec wrote:
> >
> > Also, I see that the number of sys.exit calls in pym/repoman is up
> > from 37 to
at any bugs
submitted for .29 that re not repoman specific, apply to .28 as well.
But more that if no non-repoman bugs were filed, then that clears .28
for stabilization.
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
On Mon, 14 Mar 2016 10:22:11 -0700
Zac Medico wrote:
> On 03/14/2016 10:14 AM, Zac Medico wrote:
> > On 03/05/2016 01:37 PM, Brian Dolbec wrote:
> >
> >> Zac, I'm done with code changes in the rewrite. Ready for a last
> >> look before a merge.
On Mon, 14 Mar 2016 10:14:15 -0700
Zac Medico wrote:
> On 03/05/2016 01:37 PM, Brian Dolbec wrote:
>
> > Zac, I'm done with code changes in the rewrite. Ready for a last
> > look before a merge. Can you have a look again? I did some
> > changes/fixes and reb
time.strftime('%s\n' %
> TIMESTAMP_FORMAT, time.gmtime()))
> + except (EnvironmentError,
> portage.exception.PortageException): ret.append(os.EX_IOERR)
> else:
> ret.append(os.EX_OK)
looks fine to me.
--
Brian Dolbec
to add these things.
>
> - --
> Alexander
> berna...@gentoo.org
commit message fixed and merged...
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJW4fxxXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRB
On Wed, 9 Mar 2016 12:07:13 -0800
Brian Dolbec wrote:
> I've scheduled a meeting for tomorrow, March 10, 2016 at 20:30 UTC
> (8:30PM UTC)
>
> topics:
>
> 1) next release
> 2) repoman stage2 rewrite merge status
> 3) repoman stage3 rewrite discussion for
From e13e87a38f404a95ec7705f9fd8920201b632f42 Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Thu, 10 Mar 2016 08:11:51 -0800
Subject: [PATCH] repoman: Make the output qiuet when options.quiet=True (bug
576958)
In some cases do not output anything.
In some cases, output a simplified error
I've scheduled a meeting for tomorrow, March 10, 2016 at 20:30 UTC
(8:30PM UTC)
topics:
1) next release
2) repoman stage2 rewrite merge status
3) repoman stage3 rewrite discussion for moving data
to the tree/api.gentoo.org
4) open discussion
--
Brian Dolbec
IRC channel...
And I had him change this first patch for the patch v2 which is the one
I merged.
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJW3uXKXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5
quot;help": "comma-separated
> list of maintainer email regexes to search for"
> + },
> + {
> + "longopt": "--orphaned",
> + "action": "store_true",
> + "help": "match only orphaned
> (maintainer-needed) packages" }
> )
> ),
reviewed and dealt with this on IRC.
final v2 patch merged...
--
Brian Dolbec
aux_cache[x] = mydata.get(x, "")
> @@ -817,6 +817,7 @@ class portdbapi(dbapi):
>
> def melt(self):
> self.xcache = {}
> + self._aux_cache = {}
> self.frozen = 0
>
> def
> xmatch(self,level,origdep,mydep=None,mykey=None,mylist=None):
I reviewed & approved on the bug. merged into master.
--
Brian Dolbec
hanges in the rewrite. Ready for a last look
before a merge. Can you have a look again? I did some changes/fixes
and rebased them in. Floppym hasn't reported any more bugs, so I think
it's ready for broader testing in a release. Then we can work on
moving all the test data to a
ts=False, digests=dist_digests):
> spawn_nofetch(mydbapi, myebuild,
> settings=mysettings, fd_pipes=fd_pipes)
Makes sense to be consistent to me :)
--
Brian Dolbec
"distutils": "distutils-r1",
> + "games": False,
> "gems": "ruby-fakegem",
> "mono": "mono-env",
> "python": "python-r1 / python-single-r1 /
> python-any-r1",
Yeah, merge it, it won't be a rebase issue.
--
Brian Dolbec
repoman...
this member page is for portage itself.
tools-portage is a subproject of portage and has it's own wiki page,
etc..
You missed "Core" for the core package manager code, resolver, etc...
I added that and set Z
cluding directories). Useful if
> +you wish to filter out files like HACKING.gz and TODO.gz.
>
> Patterns are matched against both the absolute path and the bare
> filename of each file (or directory) to be installed.
looks good. also you don't need an ack to push missed copyright
changes...
we all forget them at times.
--
Brian Dolbec
ion of the") + " " +
> bold("emerge"))
> - print(" " + yellow("*") + " " +
> + colorize("INFORM", _("CONFIGURATION FILES"))
> + " and " +
> + colorize("INFORM", _("CONFIGURATION FILES
> UPDATE TOOLS")))
> + print(" " + yellow("*") + " sections of the " +
> bold("emerge") + " " + _("man page to learn how to update config
> files."))
Looks great :)
--
Brian Dolbec
=
> _unicode_decode(response)
> + if response or (not enter_invalid
> and response == ''): for key in responses:
> # An empty response
> will match the # first value in responses.
this looks good to me :)
Thank you
--
Brian Dolbec
[[ $# -gt 0 ]] && eerror "$*"
> + return 1
> fi
> fi
>
looks good, you can push it I think can't you?
--
Brian Dolbec
ot;--usepkgonly", "y")
> == True
> + else "ebuilds") + green(xinfo) + ".\n",
> noiselevel=-1) if isinstance(myparent, AtomArg) and \
> not cp_exists and \
> self._frozen_config.myopts.get(
works for me
--
Brian Dolbec
if
self.repo.module_specific_options.get('sync-git-pull-extra-opts'):
+ git_cmd_opts += " %s" %
self.repo.module_specific_options['sync-git-pull-extra-opts']
git_cmd = "%s pull%s" % (self.bin_command, git_cmd_opts)
writemsg_level(git_cmd + "\n")
--
Brian Dolbec
with the tree becoming EAPI 5, even though not all the EAPI checks in
there were not banned.
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJWnoPwXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ
scovered a lockfile.
Ran lsof and found an orphaned emerge. Killed it and emerges started running
properly again.
Just happened to me. Thanks for the writeup!
_
No sig yet, sig ebuild up soon :-)
--
Brian Dolbec
On Sun, 10 Jan 2016 14:28:51 -0800
Brian Dolbec wrote:
> On Sun, 10 Jan 2016 13:40:08 -0800
> Brian Dolbec wrote:
>
> >I have now pushed a fully rebased, properly sequenced commit
> > history to the repoman branch. To be honest I think all the
> > rebasing, re-t
On Sun, 10 Jan 2016 14:28:51 -0800
Brian Dolbec wrote:
> On Sun, 10 Jan 2016 13:40:08 -0800
> Brian Dolbec wrote:
>
> >I have now pushed a fully rebased, properly sequenced commit
> > history to the repoman branch. To be honest I think all the
> > rebasing, re-t
On Sun, 10 Jan 2016 13:40:08 -0800
Brian Dolbec wrote:
>I have now pushed a fully rebased, properly sequenced commit
> history to the repoman branch. To be honest I think all the rebasing,
> re-testing took as much time as the initial conversion and testing.
> Anyway, I conside
and execution.
--
Brian Dolbec
On Mon, 4 Jan 2016 19:17:41 -0800
Brian Dolbec wrote:
> On Mon, 4 Jan 2016 16:30:30 -0500
> Mike Frysinger wrote:
>
> > Some packages list the same atom multiple times (e.g. behind diff
> > USE flags). If one of them throws an error, we end up listing it
> > mor
_data used and updated by the modules varies as it progresses
through the sequence. I have yet to document the data changed/required
by each of the modules. But they are quite clear looking at the code.
--
Brian Dolbec
S",
> "repository", "SLOT"])
> self.reposplit = myreporoot.split(os.path.sep)
> self.repolevel = len(self.reposplit)
Tested and confirmed working correctly now :)
Thanks. looks good
--
Brian Dolbec
t; "help": "write autounmask changes with
> >= atoms if possible", "choices" : true_y_or_n
> @@ -745,6 +751,11 @@ def parse_opts(tmpcmdline, silent=False):
> if myoptions.autounmask in true_y:
> myoptions.autounmask = True
>
> + if myoptions.autounmask_only in true_y:
> + myoptions.autounmask_only = True
> + else:
> + myoptions.autounmask_only = None
> +
> if myoptions.autounmask_unrestricted_atoms in true_y:
> myoptions.autounmask_unrestricted_atoms = True
>
yeah, this will be a good complement toe the autounmask options
--
Brian Dolbec
result, people using rsync are in trouble.
> > And this has been reported too by overlay owners.
>
> We should get our facts straight. It's not possible for the updated
> Manifest to have an older mtime than the old manifest, because the
> mtime of the old Manfiest is included in the max mtime calculation.
I'm generally in favour of this one, infra is changing how they
generate the Changelogs, etc. So, making this an option makes sense
to me.
--
Brian Dolbec
On Mon, 14 Dec 2015 08:54:27 -0800
Brian Dolbec wrote:
> On Mon, 14 Dec 2015 10:52:50 -0500
> NP-Hardass wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA256
> >
> > My apologies for the ambiguity. I didn't realize there was a bug on
> &
reference too, so it should be
> > explained better.
> >
> > I have no real objects on the patch, but defer the ACK to Brian.
> > Could you have a look, please?
> > - --
> > Alexander
> > berna...@gentoo.org
> > https://secure.plaimi.net/~alexander
>
Yeah, this is fine, it was handled user side, but it is good to make
this default. I'll merge it in a bit.
--
Brian Dolbec
# so they are available if needed.
> @@ -157,7 +158,6 @@ class SyncManager(object):
> taskmaster = TaskHandler(callback=self.do_callback)
> taskmaster.run_tasks(tasks, func, status,
> options=task_opts)
> - hooks_enabled = False
> if (master_hooks or self.updatecache_flg or
> not repo.sync_hooks_only_on_change):
> hooks_enabled = True
yeah, looks good
--
Brian Dolbec
eration.
actually, looks like Robin made a bug for this after you submitted this
patch.
Can you edit the commit message, add the bug please. Bug 565626
--
Brian Dolbec
sync_callback=self._sync_callback)
>
> - def sync(self, emerge_config=None, repo=None):
> + def sync(self, emerge_config=None, repo=None,
> master_hooks=True): self.callback = None
> self.repo = repo
> self.exitcode = 1
> @@ -156,9 +157,13 @@ class SyncManager(object):
> taskmaster = TaskHandler(callback=self.do_callback)
> taskmaster.run_tasks(tasks, func, status,
> options=task_opts)
> - self.perform_post_sync_hook(repo.name,
> repo.sync_uri, repo.location)
> + hooks_enabled = False
> + if master_hooks or not repo.sync_hooks_lazy or
> self.updatecache_flg:
> + hooks_enabled = True
> + self.perform_post_sync_hook(
> + repo.name, repo.sync_uri,
> repo.location)
> - return self.exitcode, None, self.updatecache_flg
> + return self.exitcode, None, self.updatecache_flg,
> hooks_enabled
>
> def do_callback(self, result):
> @@ -328,7 +333,7 @@ class SyncManager(object):
> exitcode = proc.returncode
> updatecache_flg = False
> if proc.returncode == os.EX_OK:
> - exitcode, message, updatecache_flg =
> proc.result
> + exitcode, message, updatecache_flg,
> hooks_enabled = proc.result
> if updatecache_flg and "metadata-transfer" not in
> self.settings.features: updatecache_flg = False
The code changes look good to me :)
--
Brian Dolbec
self.logger(self.xterm_titles, msg)
> writemsg_level(msg + "\n",
> level=logging.ERROR, noiselevel=-1) return (exitcode, False)
> - return (os.EX_OK, True)
> +
> + current_rev = subprocess.check_output(rev_cmd,
> +
> cwd=portage._unicode_encode(self.repo.location)) +
> + return (os.EX_OK, current_rev != previous_rev)
looks good
--
Brian Dolbec
if exitcode in [0,1,3,4,11,14,20,21]:
> is_synced = True
> @@ -554,4 +557,4 @@ class RsyncSync(NewBase):
> # --prune-empty-directories. Retry for a
> server that supports # at least rsync protocol version 29
> (>=rsync-2.6.4). pass
> - return is_synced, exitcode
> + return is_synced, exitcode, updatecache_flg
it'll work for me ;)
--
Brian Dolbec
On Fri, 6 Nov 2015 18:35:54 -0500
Mike Gilbert wrote:
> On Fri, Oct 30, 2015 at 1:39 AM, Michał Górny
> wrote:
> > On Thu, 29 Oct 2015 21:06:33 -0700
> > Brian Dolbec wrote:
> >
> >> On Thu, 29 Oct 2015 17:37:26 -0400
> >> Mike Frysinger wrote
's tested the code ;)
But I thought I saw a typo when you used BOOLEAN1 |= BOOLEAN2. I'd
never seen the | used like that. It is nearly impossible to find any
docs/examples of it. But I did find it as a bitwise or on integers
which boolean is a special form of. Interesting that it is equivalent
to a = max(a,b)
--
Brian Dolbec
ease_agent, 'w') as f:
> +
> f.write(os.path.join(
> +
> self.settings['PORTAGE_BIN_PATH'],
> +
> 'cgroup-release-agent'))
>
> cgroup_path =
> tempfile.mkdtemp(dir=cgroup_portage, prefix='%s:%s.' %
> (self.settings["CATEGORY"],
yeah, looks good :)
--
Brian Dolbec
tall a pkg from sources
only from the pkg's files directory. Provided the sources are within
the size limits for the files directory. Although an overlay may be
allowed to go past that for a non-gentoo tree pkg & ebuild.
--
Brian Dolbec
esent in portage. Layman's code has changed it's default to
generate a repos.conf file. But there has been no talk amongst
ourselves about fully deprecating the PORTDIR_OVERLAY variable yet.
--
Brian Dolbec
care of merging in say ekeyword.
> -mike
Have a look at layman's setup.py. It parses IUSE to set the installed
files via setup.py. It may not be the best method, but it does work.
The layman ebuild sets deps acording to the ISUE flags and setup.py
sets the installed modules on the python side.
--
Brian Dolbec
"EROOT" : settings["EROOT"],
> + "PORTAGE_CONFIGROOT" :
> settings["PORTAGE_CONFIGROOT"],
> + "ROOT" : settings["ROOT"],
> + }
>
> if "PORTAGE_REPOSITORIES" in settings:
> portdir = ""
This looks good to me.
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Thu, 1 Oct 2015 16:24:20 +0200
Alexander Berntsen wrote:
>> On 01/10/15 16:19, Brian Dolbec wrote:
> > Now for my re-election platform / campaign speech ;)
> Mine is far more modest:
> -improving the UI & fixing UI bugs
;] = os.path.join(os.sep,
eprefix_lstrip,
+ "usr", 'libexec', "icecc", "bin") + ":"
+ mysettings["PATH"]
+
if ccache:
mysettings["PATH"] = os.path.join(os.sep,
eprefix_lstrip,
"usr", libdir, "ccache", "bin") + ":"
+ mysettings["PATH"]
--
2.5.3
--
Brian Dolbec
elf._sync_task_exit) +
> + def _sync_task_exit(self, sync_task):
> + self._current_task = None
> + self.returncode = sync_task.returncode
> + self.sync_callback(self.sync_task)
> + self._async_wait()
> +
Looks fine. hopefully this is the last one in the sync code.
--
Brian Dolbec
portage/dbapi/porttree.py | 18 +++---
> pym/repoman/scanner.py| 2 +-
> 3 files changed, 24 insertions(+), 19 deletions(-)
>
>
Looks good, merge please
--
Brian Dolbec
oc_prefix = argv[x]
> if options.doc_prefix:
> options.doc_prefix =
> normalize_path(options.doc_prefix) else:
> - values = sys.argv[x].split(",")
> + values = argv[x].split(",")
> if arg == "-A":
> options.allowed_exts.extend(values)
> elif arg == "-a":
> @@ -189,7 +212,7 @@ def parse_args():
> elif arg == "-x":
> options.disallowed_dirs =
> values else:
> - args.append(sys.argv[x])
> + args.append(argv[x])
> x += 1
>
> return (options, args)
Looks good
--
Brian Dolbec
On Sat, 3 Oct 2015 10:19:41 -0700
Zac Medico wrote:
> On 10/03/2015 09:08 AM, Brian Dolbec wrote:
> > From 841660a8064012b734b5c62e1c1e3e1132403d5c Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec
> > Date: Sat, 3 Oct 2015 08:57:55 -0700
> > Subject: [PATCH] repoman
From 87ff1532e65e64c86fa80437944bda223aff3d93 Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Sat, 3 Oct 2015 10:14:11 -0700
Subject: [PATCH] repoman/argparser.py: _unicode_decode the commitmsg (bug
562108)
Force utf-8 for the comit message to prevent a possible traceback.
X-Gentoo-bug
t; if stat_cached is None:
> - try:
> - if follow_links:
> - stat_cached = os.stat(filename)
> - else:
> - stat_cached = os.lstat(filename)
> - except OSError as oe:
> - func_call = "stat('%s')" % filename
> - if oe.errno == errno.EPERM:
> - raise
> OperationNotPermitted(func_call)
> - elif oe.errno == errno.EACCES:
> - raise PermissionDenied(func_call)
> - elif oe.errno == errno.ENOENT:
> - raise FileNotFound(filename)
> - else:
> - raise
> + stat_cached = _do_stat(filename,
> follow_links=follow_links)
> all_applied = True
>
LGTM
--
Brian Dolbec
From 841660a8064012b734b5c62e1c1e3e1132403d5c Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Sat, 3 Oct 2015 08:57:55 -0700
Subject: [PATCH] repoman: Add file encoding sheband for py-2.7 compatibility
(bug 562108)
This makes python treat all string declarations as unicode strings.
This
lename
> + func_call = "open('%s')" % _unicode_decode(filename)
> if e.errno == errno.EPERM:
> raise
> portage.exception.OperationNotPermitted(func_call) elif e.errno ==
> errno.EACCES:
yeah,looks good.
Also for trivial patches like this, there is no need for review.
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Mon, 28 Sep 2015 14:08:26 +0200
Alexander Berntsen wrote:
> On 28/09/15 14:05, Brian Dolbec wrote:
> > So, why don't we set Sat. Oct. 3 as the deadline for nominations
> > and acceptance, and new (voting) members to
-0 chmod -fR a+rX,u+w,g-w,o-w
> > }
> >
> > econf() {
> >
>
> LGTM.
>
> Unfortunately, the find call in the 'optimized' version is useless,
> because it fails like this:
>
> $ find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w
> find: `./mod_auth_token': Permission denied
>
> Meanwhile, chmod -R works fine.
Applied and pushed,
Thanks
--
Brian Dolbec
On Sat, 26 Sep 2015 19:59:05 +0200
Michał Górny wrote:
> Dnia 2015-09-26, o godz. 10:54:08
> Brian Dolbec napisał(a):
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA512
> >
> > On Tue, 22 Sep 2015 12:12:57 +0200
> > Alexander Berntsen wrote:
>
e/results/y8rwaw9
And try to adjust your available times so that we can hold a meeting
with as many of us as possible.
Promising times UTC are: Mon. 3pm, Fri 5pm
I know Zac and myself have other meetings scheduled for 5:45pm Mon and
6pm on Wed.
# NOTE: Cache can be safely shared with the match
> cache, since the
Thanks Zac. push please.
--
Brian Dolbec
On Wed, 23 Sep 2015 15:48:42 -0700
Zac Medico wrote:
> On 09/23/2015 02:58 PM, Brian Dolbec wrote:
> > OK, looks good
>
> Thanks.
>
> >
> > I suppose we'll need to do another release soon, but how long
> > should we wait...(new repoman code) or shoul
27;..." \ % (repo.name, repo.location)
> self.logger(self.xterm_titles, msg)
> writemsg_level(msg + "\n")
> - self.portdb =
> self.trees[self.settings['EROOT']]['porttree'].dbapi try:
> st = os.stat(repo.location)
> except OSError:
OK, looks good
I suppose we'll need to do another release soon, but how long should we
wait...(new repoman code) or should we just patch 2.2.21
--
Brian Dolbec
On Wed, 23 Sep 2015 05:04:57 + (UTC)
Duncan <1i5t5.dun...@cox.net> wrote:
> Brian Dolbec posted on Tue, 22 Sep 2015 08:09:06 -0700 as excerpted:
>
> > On Tue, 22 Sep 2015 16:45:38 +0200 Alexander Berntsen
> > wrote:
> >
> >> On 22/09/15 16:27, Bria
On Tue, 22 Sep 2015 16:45:38 +0200
Alexander Berntsen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 22/09/15 16:27, Brian Dolbec wrote:
> > But, I wonder if the change had a bug side effect...causing him
> > the grief
> It appears the "prob
;2*' is allowed and '2.*' is
> > not.
> >
>
> Looks good.
yes, looks good other than the flak that has already started in
#gentoo-portage last night over the change...
It seems zero_chaos relied on the old behaviour, and at least one other
dev was upset over it.
almost sounded like it was going to be a pitch-forks, torches
mob was going to form ;)
But, I wonder if the change had a bug side effect...causing him the
grief
--
Brian Dolbec
be created that
returns the results to the pages as proper python data or
json converted data rather than parsing stdout which can be
buggy and need constant updates if the format changes.
Thank you :)
--
Brian Dolbec
-1_alpha* cat/foo-1_alpha1
> >
> > (The boundary of the version components is after _alpha and _alpha1,
> > respectively.)
> >
> > Ulrich
> >
>
>
Ok, merged approved, we can tighten it up more later easier than going
too tight now and causing some tree havoc.
--
Brian Dolbec
WORDS
> .TP
> .B CVS/Entries.IO_error
Both patches applied, thanks
--
Brian Dolbec
On Sat, 5 Sep 2015 14:24:37 -0700
Brian Dolbec wrote:
> On Sat, 5 Sep 2015 15:47:50 -0400
> Mike Gilbert wrote:
>
> > On Sat, Sep 5, 2015 at 12:16 PM, Brian Dolbec
> > wrote:
> > > On Sat, 5 Sep 2015 07:31:27 -0700
> > > Zac Medico wrote:
> >
On Sat, 5 Sep 2015 15:47:50 -0400
Mike Gilbert wrote:
> On Sat, Sep 5, 2015 at 12:16 PM, Brian Dolbec
> wrote:
> > On Sat, 5 Sep 2015 07:31:27 -0700
> > Zac Medico wrote:
> >
> >> Unadded files that are excluded from the Manifest are safe to
> >> ign
On Sat, 5 Sep 2015 12:50:22 -0700
Zac Medico wrote:
> On 09/05/2015 09:18 AM, Zac Medico wrote:
> > On 09/05/2015 09:16 AM, Brian Dolbec wrote:
> >> On Sat, 5 Sep 2015 07:31:27 -0700
> >> Zac Medico wrote:
> >>
> >>> Unadded files that are exc
On Sat, 5 Sep 2015 15:47:50 -0400
Mike Gilbert wrote:
> On Sat, Sep 5, 2015 at 12:16 PM, Brian Dolbec
> wrote:
> > On Sat, 5 Sep 2015 07:31:27 -0700
> > Zac Medico wrote:
> >
> >> Unadded files that are excluded from the Manifest are safe to
> >> ign
t; Please correct this.") sys.exit(-1)
> elif xs[-1] == "Manifest":
uhg :( not another patch to "old" repoman code.
I really want to get the rewrite code into portage master BEFORE any
more patches, or changes are applied. There has been enough
exec
> %s" % ( @@ -72,7 +75,10 @@ class GitSync(NewBase):
> git directly.
> '''
>
> - git_cmd = "%s pull" % self.bin_command
> + git_cmd_opts = ""
> + if self.settings.get("PORTAGE_QUIET") == "1":
> + git_cmd_opts += " --quiet"
> + git_cmd = "%s pull%s" % (self.bin_command,
> git_cmd_opts) writemsg_level(git_cmd + "\n")
>
> exitcode = portage.process.spawn_bash("cd %s ; exec
> %s" % (
merged and pushed to master
Thank you
--
Brian Dolbec
100644
> --- a/pym/portage/sync/syncbase.py
> +++ b/pym/portage/sync/syncbase.py
> @@ -99,7 +99,7 @@ class SyncBase(object):
> emerge_config = self.options.get('emerge_config')
> if emerge_config is not None:
> for name in
> emerge_config.opts.get('--sync-submodule', []):
> -
> paths.append(_SUBMODULE_PATH_MAP[name])
> +
> paths.extend(_SUBMODULE_PATH_MAP[name]) return tuple(paths)
>
>
also looks good :)
--
Brian Dolbec
t; pym/portage/sync/modules/rsync/rsync.py| 11 ---
> 4 files changed, 20 insertions(+), 5 deletions(-)
>
>
Looks good
--
Brian Dolbec
dexedVardb.py | 6 +++---
> pym/portage/dbapi/__init__.py | 4 ++--
> pym/portage/dbapi/bintree.py | 4 ++--
> pym/portage/dbapi/porttree.py | 6 --
> pym/portage/dbapi/vartree.py | 4 ++--
> pym/portage/dbapi/virtual.py | 4 ++--
> 9 files changed, 21 i
mtime = prev_mtime
> + else:
> + # For portability, and consistency with the
> mtime preservation
> + # code, set mtime to an exact integer value.
> + mtime = int(time.time())
> +
> + os.utime(desc_path, (mtime, mtime))
> +
>
> if sys.hexversion < 0x300:
> _filename_base = unicode
Looks Good :)
--
Brian Dolbec
(self._check_updates())
> +
> display_news_notification(self.emerge_config.target_config,
> + self.emerge_config.opts)
> +
> if return_messages:
> return msgs
> return
looks good :)
--
Brian Dolbec
gt; os.path.join(self.pkgdir, entry.name))
> + mtime = os.stat(abs_path)[stat.ST_MTIME]
> + if max_mtime is None or mtime > max_mtime:
> + max_mtime = mtime
> +
> + if max_mtime is not None:
> + os.utime(self.getFullname(), (max_mtime,
> max_mtime)) +
> def sign(self):
> """ Sign the Manifest """
> raise NotImplementedError()
looks fine :)
--
Brian Dolbec
ster
> +
> self._sync_graph.add(master.name, repo.name) self._update_leaf_nodes()
>
> def _task_exit(self, task):
looks fine
--
Brian Dolbec
Scheduler):
> > + '''
> > + Sync repos in parallel, but don't sync a given repo until
> > all
> > + of it's masters have synced.
> > s/it's/its/
>
> Thanks, fixed.
>
> >
> > I tried applying it and testing it, and it seems to work for me.
> >
>
> Excellent!
That looks good to me :)
merge away :)
--
Brian Dolbec
Hell with it, top posting this one ;)
Thanks, questions answered :)
On Thu, 13 Aug 2015 12:00:46 -0700
Zac Medico wrote:
> On 08/13/2015 07:29 AM, Brian Dolbec wrote:
> > On Thu, 13 Aug 2015 01:34:36 -0700
> > Zac Medico wrote:
> >> + d
pw = os.pipe()
> + self.fd_pipes = {}
> + self.fd_pipes[pw] = pw
> + self._async_func_reader_pw = pw
> + self._async_func_reader = PipeReader(
> + input_files={"input":pr},
> + scheduler=self.scheduler)
> +
> self._async_func_reader.addExitListener(self._async_func_reader_exit)
> + self._async_func_reader.start()
> + ForkProcess._start(self)
> + os.close(pw)
> +
> + def _run(self):
> + try:
> + result = self.target(*(self.args or []),
> **(self.kwargs or {}))
> + os.write(self._async_func_reader_pw,
> pickle.dumps(result))
> + except Exception:
> + traceback.print_exc()
> + return 1
> +
> + return os.EX_OK
> +
> + def _pipe_logger_exit(self, pipe_logger):
> + # Ignore this event, since we want to ensure that we
> exit
> + # only after _async_func_reader_exit has reached EOF.
> + self._pipe_logger = None
> +
> + def _async_func_reader_exit(self, pipe_reader):
> + self.result = pickle.loads(pipe_reader.getvalue())
> + self._async_func_reader = None
> + self._unregister()
> + self.wait()
> +
> + def _unregister(self):
> + ForkProcess._unregister(self)
> +
> + pipe_reader = self._async_func_reader
> + if pipe_reader is not None:
> + self._async_func_reader = None
> +
> pipe_reader.removeExitListener(self._async_func_reader_exit)
> + pipe_reader.cancel()
--
Brian Dolbec
ortage/const.py
> +++ b/pym/portage/const.py
> @@ -264,6 +264,7 @@ LIVE_ECLASSES = frozenset([
> "git",
> "git-2",
> "git-r3",
> + "golang-vcs",
> "mercurial",
> "subversion",
> "tla",
Thanks Mike, it's in both master and 2.2.20.1
--
Brian Dolbec
del metadata['EAPI']
> > for trg_cache in self._trg_caches:
> > self._write_cache(trg_cache,
> > cpv, repo_path, metadata,
> > ebuild_hash)
> >
>
> LTGM.
yeah, merge please
--
Brian Dolbec
201 - 300 of 634 matches
Mail list logo
