On Wed, Dec 4, 2019 at 9:17 PM Zac Medico wrote:
>
> On 12/4/19 6:12 PM, Matt Turner wrote:
> > The boilerplate for calling this method was larger than what it actually
> > contained. Additionally I think this change will allow the loop to run
> > on a generator
The boilerplate for calling this method was larger than what it actually
contained. Additionally I think this change will allow the loop to run
on a generator rather than a full list.
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/clean.py | 21 ++---
1 file changed, 6
Closes: https://bugs.gentoo.org/671592
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/clean.py | 4
1 file changed, 4 insertions(+)
diff --git a/pym/gentoolkit/eclean/clean.py b/pym/gentoolkit/eclean/clean.py
index b790de0..89300ce 100644
--- a/pym/gentoolkit/eclean/clean.py
+++ b
On Sun, Mar 1, 2020 at 10:39 PM Zac Medico wrote:
>
> On 2/20/20 9:29 PM, Matt Turner wrote:
> > @@ -564,7 +577,22 @@ def findPackages(
> >
> > # Exclude if binpkg exists in the porttree and not --deep
> > if not destructive
On Sun, Mar 1, 2020 at 10:32 PM Zac Medico wrote:
>
> On 2/20/20 9:29 PM, Matt Turner wrote:
> > +
> > def findPackages(
> > options,
> > exclude=None,
> > @@ -564,7 +577,22 @@ def findPackages(
> >
> > # Exclude
On Mon, Mar 2, 2020 at 12:40 PM Matt Turner wrote:
>
> On Sun, Mar 1, 2020 at 10:32 PM Zac Medico wrote:
> >
> > On 2/20/20 9:29 PM, Matt Turner wrote:
> > > +
> > > def findPackages(
> > > options,
> > > exc
On Thu, Feb 20, 2020 at 9:29 PM Matt Turner wrote:
>
> I found the original code to be nearly incomprehensible. Instead of
> populating a dict of potential binpkgs to remove and then removing from
> the to-be-removed list, just selectively add to-be-removed packages.
>
> S
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/cli.py| 7 ++-
pym/gentoolkit/eclean/search.py | 30 +-
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py
index 1a99b3e..39aafd3
I found the original code to be nearly incomprehensible. Instead of
populating a dict of potential binpkgs to remove and then removing from
the to-be-removed list, just selectively add to-be-removed packages.
Signed-off-by: Matt Turner
---
I switched from tabs to spaces in the process. I can
Also print categories on the line with the package name for much simpler
consumption by external tools.
Signed-off-by: Matt Turner
---
pym/gentoolkit/imlate/imlate.py | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/pym/gentoolkit/imlate/imlate.py b/pym
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/cli.py| 4 ++--
pym/gentoolkit/eclean/search.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py
index 1d2f52b..1a99b3e 100644
--- a/pym/gentoolkit/eclean
On Thu, Jan 2, 2020 at 12:41 PM Zac Medico wrote:
>
> On 1/2/20 10:58 AM, Matt Turner wrote:
> > Also print categories on the line with the package name for much simpler
> > consumption by external tools.
> >
> > Signed-off-by: Matt Turner
> > ---
>
On Wed, Mar 11, 2020 at 9:36 PM Matt Turner wrote:
>
> On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote:
> >
> > On 3/6/20 10:11 PM, Matt Turner wrote:
> > > Signed-off-by: Matt Turner
> > > ---
> > > pym/gentoolkit/eclean/cli.py| 7 ++
On Wed, Mar 11, 2020 at 10:23 PM Zac Medico wrote:
> The coupling with --destructive logic complicates matters. It raises the
> question, why isn't --time-limit logic also coupled with --destructive
> logic? I think "in order to preserve the status quo" is a reasonable
> answer to this question.
On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote:
>
> On 3/6/20 10:11 PM, Matt Turner wrote:
> > Signed-off-by: Matt Turner
> > ---
> > pym/gentoolkit/eclean/cli.py| 7 ++-
> > pym/gentoolkit/eclean/search.py | 24 +++-
> >
On Mon, Mar 2, 2020 at 9:15 PM Zac Medico wrote:
>
> On 3/2/20 1:11 PM, Matt Turner wrote:
> > On Sun, Mar 1, 2020 at 10:39 PM Zac Medico wrote:
> >>
> >> On 2/20/20 9:29 PM, Matt Turner wrote:
> >>> @@ -564,7 +577,22 @@ def findPackages(
>
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/cli.py| 7 ++-
pym/gentoolkit/eclean/search.py | 24 +++-
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/pym/gentoolkit/eclean/cli.py b/pym/gentoolkit/eclean/cli.py
index 1a99b3e..39aafd3 100644
I found the original code to be nearly incomprehensible. Instead of
populating a dict of potential binpkgs to remove and then removing from
the to-be-removed list, just selectively add to-be-removed packages.
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/search.py | 113
On Tue, Mar 10, 2020 at 8:30 PM Zac Medico wrote:
>
> On 3/6/20 10:11 PM, Matt Turner wrote:
> > +def _deps_equal(deps_a, deps_b, eapi, uselist=None):
> > + """Compare two dependency lists given a set of USE flags"""
> > + i
Bug: https://bugs.gentoo.org/715108
Signed-off-by: Matt Turner
---
Strawman patch. Bikeshed away.
bin/quickpkg | 2 +-
lib/portage/package/ebuild/doebuild.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bin/quickpkg b/bin/quickpkg
index
And remove obsolete text from binpkg-multi-instance. I believe this was
obsolete even before my gentoolkit patches that add the --changed-deps
flag to eclean packages.
Signed-off-by: Matt Turner
---
man/make.conf.5 | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/man
On Sun, Apr 26, 2020 at 12:29 PM Michał Górny wrote:
>
> On Sun, 2020-04-26 at 09:55 -0700, Matt Turner wrote:
> > Bug: https://bugs.gentoo.org/715108
> > Signed-off-by: Matt Turner
> > ---
> > Strawman patch. Bikeshed away.
> >
>
> xz is generally slow
On Sat, Aug 15, 2020 at 12:27 PM Zac Medico wrote:
>
> Add a short -l option for --load-average just like make(1) has.
That's awesome, thank you. That'll make some catalyst work easier for me.
On Wed, Dec 23, 2020 at 2:46 PM Junio C Hamano wrote:
>
> Matt Turner writes:
>
> > I want to handle conflicts automatically on lines like
> >
> >> KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~riscv
> >> ~s390 ~sparc ~x8
Typo in commit title: comatibility
Reported by flake8.
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/exclude.py | 1 -
pym/gentoolkit/enalyze/rebuild.py| 1 -
pym/gentoolkit/helpers.py| 1 -
pym/gentoolkit/revdep_rebuild/analyse.py | 1 -
pym/gentoolkit/revdep_rebuild/cache.py | 1 -
pym
arch_status changed from a Dict[str] to Dict[Tuple[str, str]], but these
bits of test data were not updated. Update the examples while we're here
(e.g. arm64 is stable with stable profiles now).
Fixes: 459cfba47d25 (ekeyword: Use now-common load_profile_data() from eshowkw)
Signed-off-by: Matt
Prevented the unit test from running:
pym/gentoolkit/test/eclean/distsupport.py:435: PytestCollectionWarning:
cannot collect test class 'TestDisfiles' because it has a __init__
constructor (from: pym/gentoolkit/test/eclean/test_search.py)
Signed-off-by: Matt Turner
---
pym/gentoolkit/test
unittests should be named test_*.py so that they are discoverable.
Signed-off-by: Matt Turner
---
pym/gentoolkit/ekeyword/pytest.ini | 2 +-
.../ekeyword/{ekeyword_unittest.py => test_ekeyword.py} | 2 +-
2 files changed, 2 insertions(+), 2 deleti
ibutesfile = ~/.gitattributes
[merge "keywords"]
name = KEYWORDS merge driver
driver = merge-driver-ekeyword %O %A %B
~/.gitattributes:
*.ebuild merge=keywords
Signed-off-by: Matt Turner
---
One annoying wart in the program is due to th
e driver, it automatically resolves the conflict.
>
> gentoo.git/.git/config:
>
> [core]
> ...
> attributesfile = ~/.gitattributes
> [merge "keywords"]
> name = KEYWORDS merge driver
>
Signed-off-by: Matt Turner
---
bin/ekeyword | 2 --
bin/enalyze | 2 --
bin/epkginfo | 2 --
bin/equery| 2 --
bin/euse | 2 --
bin/imlate
Signed-off-by: Matt Turner
---
pym/gentoolkit/eclean/exclude.py | 2 --
pym/gentoolkit/enalyze/rebuild.py | 2 --
pym/gentoolkit/equery/uses.py | 2 --
pym/gentoolkit/equery/which.py| 2 --
pym/gentoolkit/helpers.py | 2 --
pym
Signed-off-by: Matt Turner
---
pym/gentoolkit/cpv.py | 2 +-
pym/gentoolkit/eclean/clean.py| 2 +-
pym/gentoolkit/eclean/output.py | 2 +-
pym/gentoolkit/eclean/pkgindex.py | 2 +-
pym/gentoolkit/eclean/search.py | 2 +-
pym/gentoolkit
gentoolkit supports only Python 3.6+ now, so these are not used.
Signed-off-by: Matt Turner
---
bin/eclean | 3 ---
bin/eclean-dist | 3 ---
bin/eclean-pkg | 3 ---
bin/ekeyword
gentoo.git as such:
gentoo.git/.git/config:
[merge "keywords"]
name = KEYWORDS merge driver
driver = merge-driver-ekeyword %O %A %B %P
gentoo.git/.git/info/attributes:
*.ebuild merge=keywords
Signed-off-by: Matt Turner
---
bin/merge-d
Signed-off-by: Matt Turner
---
Seems to only be used by duplicated unit tests? I guess this might have
been useful when Python 2 was still supported?
pym/gentoolkit/test/__init__.py | 23 ---
pym/gentoolkit/test/test_atom.py | 15 ---
pym/gentoolkit/test
Allows binpkgs to be deleted if they are not usable due to IUSE changes.
---
Just kind of spitballing. I'm not sure about what USE flags we should
ignore or whether it should be configurable, etc. On one hand, deleting
binpkgs that don't have a newly added PYTHON_TARGET option might make
sense if
gentoo.git as such:
gentoo.git/.git/config:
[merge "keywords"]
name = KEYWORDS merge driver
driver = merge-driver-ekeyword %O %A %B %P
gentoo.git/.git/info/attributes:
*.ebuild merge=keywords
Signed-off-by: Matt Turner
---
v3: Address
On Mon, Dec 28, 2020 at 8:09 PM Zac Medico wrote:
>
> On 12/28/20 3:15 PM, Matt Turner wrote:
> > +def apply_keyword_changes(ebuild: str, pathname: str,
> > + changes: List[Tuple[Optional[str],
> > +
Signed-off-by: Matt Turner
---
I've asked Arfrever multiple times if these are still used anywhere, and
he seemingly has not responded intentionally.
According to https://bugs.gentoo.org/174536#c27 these EAPIs were only
used in Arfrever's personal overlay, and even in 2012 there were
questions
With no need to support Python 2, we can remove our private
implementation.
Signed-off-by: Matt Turner
---
I don't know how to test this. I intentionally broke the return value of
create_subprocess_exec and didn't see any bad results.
lib/portage/util/futures/_asyncio/__init__.py | 8 +-
lib
Signed-off-by: Matt Turner
---
lib/portage/__init__.py | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/portage/__init__.py b/lib/portage/__init__.py
index 184db6ae2..1d202f557 100644
--- a/lib/portage/__init__.py
+++ b/lib/portage/__init__.py
@@ -484,11 +484,7 @@ def
Fixes: 5e9fe0f2a ("Eliminate basestring/long/_unicode py3 compat")
Signed-off-by: Matt Turner
---
lib/portage/versions.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/portage/versions.py b/lib/portage/versions.py
index 317683b17..1dc942124 100644
Fixes: 788c0e8bb ("Remove from __future__ import unicode_literals")
Signed-off-by: Matt Turner
---
bin/egencache | 2 --
lib/_emerge/Package.py | 9 -
lib/_emerge/Scheduler.py| 2 --
l
The VDB uses a one-file-per-variable format. This has some
inefficiencies, with many file systems. For example the 'EAPI' file
that contains a single character will consume a 4K block on disk.
$ cd /var/db/pkg/sys-apps/portage-3.0.30-r1/
$ ls -lh --block-size=1 | awk 'BEGIN { sum = 0; } { sum +=
From: "Wolfgang E. Sanyer"
Reviewed-by: Matt Turner
Signed-off-by: Wolfgang E. Sanyer
---
lib/portage/eapi.py | 162 +---
1 file changed, 121 insertions(+), 41 deletions(-)
diff --git a/lib/portage/eapi.py b/lib/portage/eapi.py
index
From: "Wolfgang E. Sanyer"
Reviewed-by: Matt Turner
Signed-off-by: Wolfgang E. Sanyer
---
lib/portage/eapi.py | 155
1 file changed, 72 insertions(+), 83 deletions(-)
diff --git a/lib/portage/eapi.py b/lib/portage/eapi.py
index
From: "Wolfgang E. Sanyer"
Reviewed-by: Matt Turner
Signed-off-by: Wolfgang E. Sanyer
---
lib/portage/dep/__init__.py | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/lib/portage/dep/__init__.py b/lib/portage/dep/__init__.py
index 3b3577025..13c0f4
From: "Wolfgang E. Sanyer"
Reviewed-by: Matt Turner
Signed-off-by: Wolfgang E. Sanyer
---
lib/portage/eapi.py | 52 -
1 file changed, 33 insertions(+), 19 deletions(-)
diff --git a/lib/portage/eapi.py b/lib/portage/eapi.py
index
Signed-off-by: Matt Turner
---
GitHub PR: https://github.com/gentoo/portage/pull/789
bin/dohtml.py | 2 -
bin/eapi.sh | 116
bin/phase-functions.sh| 4 +-
bin/phase-helpers.sh
Signed-off-by: Matt Turner
---
bin/eapi.sh | 32
bin/ebuild.sh | 9 -
bin/phase-helpers.sh | 166 --
bin/portageq | 5 +-
bin/save-ebuild-env.sh
On Thu, Nov 24, 2022 at 10:36 PM Pin-yen Lin wrote:
>
> Add lru_cache to speed up the running time of "Calculating
> dependencies".
>
> In a ChromeOS use case, this patch decreases the running time from
> 311s to 197s with almost no memory usage increase.
>
> Signed-off-by: Pin-yen Lin
Thank
53 matches
Mail list logo
