[gentoo-portage-dev] [PATCH] emerge: use asyncio interfaces for spinner during owner lookup (bug 591760)

2017-03-26 Thread Zac Medico
X-Gentoo-bug: 591760 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=591760 --- pym/_emerge/depgraph.py | 13 - pym/portage/dbapi/vartree.py | 22 +- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/pym/_emerge/depgraph.py

Re: [gentoo-portage-dev] [PATCH] Future: implement add_done_callback for asyncio compat (bug 591760)

2017-03-26 Thread Zac Medico
On Sun, Mar 26, 2017 at 12:07 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 26 Mar 2017 03:13:11 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Implement the add_done_callback and remove_done_callback methods, >> since they are required in orde

[gentoo-portage-dev] [PATCH] Future: implement add_done_callback for asyncio compat (bug 591760)

2017-03-26 Thread Zac Medico
Implement the add_done_callback and remove_done_callback methods, since they are required in order to make further progress toward asyncio compatibility. Also implement the AbstractEventLoop create_future method for the EventLoop class, so that it returns an instance of _EventLoopFuture.

Re: [gentoo-portage-dev] [PATCH] phase-functions: Fix cleaning fake FILESDIR, reported by Arfrever

2017-03-26 Thread Zac Medico
On Sun, Mar 26, 2017 at 12:30 AM, Michał Górny wrote: > --- > bin/phase-functions.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh > index 50f0fdb9b..dfd8733c8 100644 > --- a/bin/phase-functions.sh > +++

Re: [gentoo-portage-dev] [PATCH 5/5] FetchIterator: add terminate method

2017-03-24 Thread Zac Medico
On Fri, Mar 24, 2017 at 1:05 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Thu, 23 Mar 2017 19:55:00 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Add a terminate method to FetchIterator so that it doesn't >> delay termination of emirrordist via SIGIN

[gentoo-portage-dev] [PATCH 4/5] emirrordist: add debug SIGUSR1 handler

2017-03-23 Thread Zac Medico
This is handy for debugging issues with SIGTERM/SIGINT handling. --- bin/emirrordist | 8 1 file changed, 8 insertions(+) diff --git a/bin/emirrordist b/bin/emirrordist index 0368eee..17f99f5 100755 --- a/bin/emirrordist +++ b/bin/emirrordist @@ -2,6 +2,7 @@ # Copyright 2013-2014

[gentoo-portage-dev] [PATCH 5/5] FetchIterator: add terminate method

2017-03-23 Thread Zac Medico
Add a terminate method to FetchIterator so that it doesn't delay termination of emirrordist via SIGINT. Otherwise it it is possible for the __iter__ method to loop for a very long time after SIGINT has been delivered. For example, this could happen if there are many ebuilds with stale cache and

[gentoo-portage-dev] [PATCH 2/5] PollScheduler: terminate via call_soon for asyncio compat

2017-03-23 Thread Zac Medico
Use call_soon to schedule the _termination_check callback when needed. The previous idle_add usage was relatively inefficient, because it scheduled the _termination_check callback to be called in every iteration of the event loop. Add a _cleanup method to handle cleanup of callbacks registered

Re: [gentoo-portage-dev] [PATCH] phase-helpers.sh: Loop over A rather than SRC_URI in __eapi0_pkg_nofetch.

2017-03-23 Thread Zac Medico
On Thu, Mar 23, 2017 at 2:55 AM, Ulrich Müller wrote: > Looping over SRC_URI also outputs non-filename elements (e.g, use > conditionals) which is avoided when looping over A. > > Gentoo-Bug: 613132 > --- > bin/phase-helpers.sh | 8 > 1 file changed, 4 insertions(+), 4

[gentoo-portage-dev] [PATCH] pkg_use_display: show masked/forced state of USE_EXPAND flags (bug 490562)

2017-03-22 Thread Zac Medico
Fix pkg_use_display to test if the prefixed flag is in use.force or use.mask, rather than the unprefixed flag. X-Gentoo-bug: 490562 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=490562 --- pym/_emerge/UseFlagDisplay.py | 19 +-- 1 file changed, 13 insertions(+), 6

Re: [gentoo-portage-dev] [PATCH v2] emerge: fix --usepkg when ebuild is not available (bug 613360)

2017-03-22 Thread Zac Medico
On Tue, Mar 21, 2017 at 4:21 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 20 Mar 2017 18:22:40 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix emerge --usepkg to use a binary package when the corresponding >> ebuild is not available (and --use

Re: [gentoo-portage-dev] [PATCH v3] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-21 Thread Zac Medico
On 03/21/2017 12:46 AM, Michał Górny wrote: > Use a model of fake FILESDIR path to ensure that invalid accesses to > FILESDIR will result in failures rather than being silently allowed by > Portage. This mostly involves accesses in the global scope and pkg_* > phases, although the current model

Re: [gentoo-portage-dev] [PATCH v2] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-20 Thread Zac Medico
On 03/18/2017 10:26 AM, Michał Górny wrote: > @@ -129,6 +130,9 @@ class EbuildPhase(CompositeTask): > # If the environment.bz2 doesn't exist, then ebuild.sh > will > # source the ebuild as a fallback. > > + if self.phase == "unpack": > +

[gentoo-portage-dev] [PATCH v2] emerge: fix --usepkg when ebuild is not available (bug 613360)

2017-03-20 Thread Zac Medico
Fix emerge --usepkg to use a binary package when the corresponding ebuild is not available (and --use-ebuild-visibility is not enabled), in cases when no other package is available to satisfy the dependency. This reverts an unintended behavior change from commit

Re: [gentoo-portage-dev] [PATCH 3/4] portage.package.ebuild.doebuild: Override DISTDIR unconditionally, #612972

2017-03-18 Thread Zac Medico
On 03/18/2017 02:16 PM, Michał Górny wrote: > On sob, 2017-03-18 at 13:45 -0700, Zac Medico wrote: >> On Sat, Mar 18, 2017 at 1:12 PM, Zac Medico <zmed...@gentoo.org> wrote: >>> On Sat, Mar 18, 2017 at 12:57 PM, Zac Medico <zmed...@gentoo.org> wrote: >>>>

Re: [gentoo-portage-dev] [PATCH 3/4] portage.package.ebuild.doebuild: Override DISTDIR unconditionally, #612972

2017-03-18 Thread Zac Medico
On Sat, Mar 18, 2017 at 1:12 PM, Zac Medico <zmed...@gentoo.org> wrote: > On Sat, Mar 18, 2017 at 12:57 PM, Zac Medico <zmed...@gentoo.org> wrote: >> On Sat, Mar 18, 2017 at 12:04 PM, Michał Górny <mgo...@gentoo.org> wrote: >>> Ensure that DISTDIR is alwa

Re: [gentoo-portage-dev] [PATCH 3/4] portage.package.ebuild.doebuild: Override DISTDIR unconditionally, #612972

2017-03-18 Thread Zac Medico
On Sat, Mar 18, 2017 at 12:57 PM, Zac Medico <zmed...@gentoo.org> wrote: > On Sat, Mar 18, 2017 at 12:04 PM, Michał Górny <mgo...@gentoo.org> wrote: >> Ensure that DISTDIR is always defined to the path to the shadow >> directory. This ensures that PMS rules for consi

Re: [gentoo-portage-dev] [PATCH 3/4] portage.package.ebuild.doebuild: Override DISTDIR unconditionally, #612972

2017-03-18 Thread Zac Medico
On Sat, Mar 18, 2017 at 12:04 PM, Michał Górny wrote: > Ensure that DISTDIR is always defined to the path to the shadow > directory. This ensures that PMS rules for consistent value are > followed, and that no global scope calls should be able to access > the distfile

Re: [gentoo-portage-dev] [PATCH] emerge: fix --use-ebuild-visibility to reject binary packages (bug 612960)

2017-03-18 Thread Zac Medico
On Sat, Mar 18, 2017 at 12:10 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Fri, 17 Mar 2017 20:48:22 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix the --use-ebuild-visibility option to reject binary packages for >> which ebuilds are either masked

[gentoo-portage-dev] [PATCH] emerge: fix --use-ebuild-visibility to reject binary packages (bug 612960)

2017-03-17 Thread Zac Medico
Fix the --use-ebuild-visibility option to reject binary packages for which ebuilds are either masked or unavailable. The included test case fails with out this fix. X-Gentoo-bug: 612960 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=612960 --- pym/_emerge/depgraph.py

Re: [gentoo-portage-dev] [PATCH] depgraph: avoid missed update with slot operator and circ dep (bug 612874)

2017-03-17 Thread Zac Medico
On Fri, Mar 17, 2017 at 8:37 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Fri, 17 Mar 2017 01:18:19 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix check_reverse_dependencies to ignore direct circular dependencies, >> since these dependencies te

Re: [gentoo-portage-dev] [PATCH v2] depgraph: fix missed atom_not_selected initialization (bug 612846)

2017-03-16 Thread Zac Medico
On Thu, Mar 16, 2017 at 3:33 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Thu, 16 Mar 2017 14:19:07 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix the _slot_operator_update_probe method to ensure that the >> atom_not_selected variable is always prop

[gentoo-portage-dev] [PATCH] depgraph: fix missed atom_not_selected initialization (bug 612846)

2017-03-16 Thread Zac Medico
Fix the _slot_operator_update_probe method to ensure that the atom_not_selected variable is always properly initialized. This problem prevented the method from identifying slot operator rebuild candidates, leading to dependency conflicts and/or missed updates. For example, this may have triggered

Re: [gentoo-portage-dev] [PATCH] depgraph: fix slot operator rebuild for llvm:0 to llvm:4 upgrade (bug 612772)

2017-03-15 Thread Zac Medico
On Wed, Mar 15, 2017 at 9:39 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Wed, 15 Mar 2017 20:23:43 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix check_reverse_dependencies to ignore dependencies of parent >> packages that could be uninstalled in ord

[gentoo-portage-dev] [PATCH] depgraph: fix slot operator rebuild for llvm:0 to llvm:4 upgrade (bug 612772)

2017-03-15 Thread Zac Medico
Fix check_reverse_dependencies to ignore dependencies of parent packages that could be uninstalled in order to solve a blocker conflict. This case is similar to the one from bug 584626, except that the relevant parent package is in an older slot which is blocked by a newer slot. In this case, the

Re: [gentoo-portage-dev] [PATCH v3] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-15 Thread Zac Medico
On Wed, Mar 15, 2017 at 3:25 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Fri, 3 Mar 2017 18:18:50 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Perform in-kernel file copying when possible, and also support >> reflinks and sparse files. If the

Re: [gentoo-portage-dev] [PATCH] portage.checksum: Store supported hash types in a frozenset

2017-03-13 Thread Zac Medico
On Mon, Mar 13, 2017 at 7:45 AM, Michał Górny wrote: > Copy the list of supported hash types (hashfunc_map dict) into > a frozenset to support efficient access in the public API. > --- > pym/portage/checksum.py | 25 ++--- > 1 file changed, 14

Re: [gentoo-portage-dev] [PATCHES] portage.checksum hacking, pt. 4

2017-03-12 Thread Zac Medico
On Sun, Mar 12, 2017 at 11:59 AM, Michał Górny wrote: > Hi, > > Here's a huge batch of patches for portage.checksum and relevant stuff. > It's not a complete rewrite as I have originally planned, and it's still > not the code I'd like to see but functionally it has been

Re: [gentoo-portage-dev] [PATCH 01/14] Use public API: hashfunc_map -> get_valid_checksum_keys()

2017-03-12 Thread Zac Medico
On Sun, Mar 12, 2017 at 2:13 PM, Michał Górny <mgo...@gentoo.org> wrote: > W dniu 12.03.2017, nie o godzinie 13∶36 -0700, użytkownik Zac Medico > napisał: >> On Sun, Mar 12, 2017 at 11:59 AM, Michał Górny <mgo...@gentoo.org> wrote: >> > Use get_valid_checksum_key

Re: [gentoo-portage-dev] [PATCH 01/14] Use public API: hashfunc_map -> get_valid_checksum_keys()

2017-03-12 Thread Zac Medico
On Sun, Mar 12, 2017 at 11:59 AM, Michał Górny wrote: > Use get_valid_checksum_keys() function instead of accessing hashfunc_map > directly throughout the Portage. > --- > pym/portage/_emirrordist/FetchTask.py | 2 +- > pym/portage/dbapi/bintree.py | 4 ++-- >

Re: [gentoo-portage-dev] [PATCH] config.setcpv: fix handling of IUSE changes (bug 611896)

2017-03-09 Thread Zac Medico
On Thu, Mar 9, 2017 at 5:33 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Thu, 9 Mar 2017 13:38:04 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix setcpv to correctly regenerate USE when the IUSE differs from >> the previous setcpv call. Changes in I

[gentoo-portage-dev] [PATCH] config.setcpv: fix handling of IUSE changes (bug 611896)

2017-03-09 Thread Zac Medico
Fix setcpv to correctly regenerate USE when the IUSE differs from the previous setcpv call. Changes in IUSE affect USE_EXPAND wildcard expansion in the regenerate method. X-Gentoo-bug: 611896 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=611896 ---

Re: [gentoo-portage-dev] [PATCH] depgraph: fix runtime package mask interaction with slot operator rebuilds (bug 612094)

2017-03-09 Thread Zac Medico
On Thu, Mar 9, 2017 at 11:28 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Wed, 8 Mar 2017 22:11:45 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> In some cases the backtracking runtime package mask can interact badly >> with slot operator rebuilds, preve

Re: [gentoo-portage-dev] [PATCH] depgraph: fix backtracking for slot operator rebuilds (bug 612042)

2017-03-08 Thread Zac Medico
On Wed, Mar 8, 2017 at 10:56 AM, Brian Dolbec wrote: > > looks good :) > > -- > Brian Dolbec > > Thanks, merged: https://gitweb.gentoo.org/proj/portage.git/commit/?id=7c01a73c5a3ff969ddaa43e91730a7372a8a10c8 -- Thanks, Zac

Re: [gentoo-portage-dev] [PATCH] use_reduce: reserve missing_white_space_check for invalid tokens (bug 611838)

2017-03-08 Thread Zac Medico
On Wed, Mar 8, 2017 at 10:50 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 6 Mar 2017 12:51:08 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Since it's possible for a URI to contain parenthesis, only call >> missing_white_space_check

Re: [gentoo-portage-dev] [PATCH v2] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-08 Thread Zac Medico
On Wed, Mar 8, 2017 at 10:48 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 5 Mar 2017 00:40:25 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> It's useful to automatically enable --with-bdeps so that @world >> updates will update all packages

[gentoo-portage-dev] [PATCH] use_reduce: reserve missing_white_space_check for invalid tokens (bug 611838)

2017-03-06 Thread Zac Medico
Since it's possible for a URI to contain parenthesis, only call missing_white_space_check for tokens that fail to validate with token_class. The missing_white_space_check function only serves to clarify exception messages, so it must not be allowed to reject valid tokens. ---

Re: [gentoo-portage-dev] [PATCH v2] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-05 Thread Zac Medico
On 03/05/2017 11:44 AM, Michael Orlitzky wrote: > On 03/05/2017 02:12 PM, Zac Medico wrote: >> >> Incorrect. >> >> ... >> >> Incorrect. >> > > I see my mistakes, but maintain that this is confusing =) It could be worse, and I think it's questio

Re: [gentoo-portage-dev] [PATCH v2] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-05 Thread Zac Medico
On 03/05/2017 07:08 AM, Michael Orlitzky wrote: > On 03/05/2017 03:40 AM, Zac Medico wrote: >> >> A new --with-bdeps-auto=<y|n> option is provided, making it possible to >> enable or disable the program logic that causes --with-bdeps to be >> automatically

[gentoo-portage-dev] [PATCH v2] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-05 Thread Zac Medico
It's useful to automatically enable --with-bdeps so that @world updates will update all packages that are not eligible for removal by emerge --depclean. However, many users of binary packages do not want unnecessary build time dependencies installed, therefore do not auto-enable --with-bdeps for

Re: [gentoo-portage-dev] [PATCH] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-04 Thread Zac Medico
On 03/04/2017 02:30 AM, Zac Medico wrote: > On 03/04/2017 01:59 AM, Michał Górny wrote: >> W dniu 04.03.2017, sob o godzinie 01∶34 -0800, użytkownik Zac Medico >> napisał: >>> It's useful to enable --with-bdeps by default so that @world updates >>> will update a

[gentoo-portage-dev] [PATCH] emerge: auto-enable --with-bdeps if --usepkg is not enabled (bug 598444)

2017-03-04 Thread Zac Medico
It's useful to enable --with-bdeps by default so that @world updates will update all packages that are not eligible for removal by emerge --depclean. However, many users of binary packages do not want unnecessary build time dependencies installed, therefore do not auto-enable --with-bdeps for

Re: [gentoo-portage-dev] [PATCH v2] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-03 Thread Zac Medico
On 03/03/2017 12:45 PM, Michał Górny wrote: > W dniu 02.03.2017, czw o godzinie 17∶09 -0800, użytkownik Zac Medico >> +def copyfile(src, dst): >> +""" >> +Copy the contents (no metadata) of the file named src to a file >> +named dst. >&g

Re: [gentoo-portage-dev] [PATCH] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-03 Thread Zac Medico
On 03/02/2017 08:24 AM, Michał Górny wrote: > W dniu 01.03.2017, śro o godzinie 19∶03 -0800, użytkownik Zac Medico > napisał: >> +def _test_optimized_copyfile(): >> +""" >> +Test if _optimized_copyfile works. It will fail for Linux versions >>

[gentoo-portage-dev] [PATCH v2] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-02 Thread Zac Medico
Perform in-kernel file copying when possible, and also support reflinks and sparse files. If the optimized implementation fails at runtime, gracefully fallback to a plain read/write loop. Compile-time and run-time fallbacks are implemented, so that any incompatiblities will be handled gracefully.

Re: [gentoo-portage-dev] [PATCH] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-02 Thread Zac Medico
On 03/02/2017 08:24 AM, Michał Górny wrote: >> +if (copyfunc_ret < 0) { >> +if ((errno == EXDEV || errno == ENOSYS) && >> +copyfunc == cfr_wrapper) { >> +/* Use sendfile instead of copy_file_range for >> + *

[gentoo-portage-dev] [PATCH] movefile: support in-kernel file copying on Linux (bug 607868)

2017-03-01 Thread Zac Medico
Perform in-kernel file copying when possible, and also support reflinks and sparse files. If the optimized implementation fails at runtime, gracefully fallback to shutil.copyfile. Compile-time and run-time fallbacks are implemented, so that any incompatiblities will be handled gracefully. For

Re: [gentoo-portage-dev] [PATCH 1/2] checksum: Fix overriding fallbacks on broken pycrypto

2017-02-28 Thread Zac Medico
On 02/28/2017 11:34 PM, Michał Górny wrote: > The pycrypto override used the same variables as actual hash functions > before determining whether its functions are useful. As a result, if > pycrypto had a broken module and no hash function was generated, > the possible previous implementation was

Re: [gentoo-portage-dev] [PATCH 2/2] checksum: Add pycryptodome fallbacks for SHA3 and BLAKE2

2017-02-28 Thread Zac Medico
On 02/28/2017 11:34 PM, Michał Górny wrote: > --- > pym/portage/checksum.py | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/pym/portage/checksum.py b/pym/portage/checksum.py > index fc38417a7..042a0a745 100644 > --- a/pym/portage/checksum.py > +++

[gentoo-portage-dev] Re: [PATCH] GitSync: fix spurious "sync-depth is deprecated" messages (bug 610708)

2017-02-24 Thread Zac Medico
On 02/24/2017 04:02 PM, Zac Medico wrote: > The CheckGitConfig._check_depth method must not set the sync_depth > attribute, or else it will trigger "sync-depth is deprecated" messages. > > Fixes: b3f6297a791a ("repos.conf: rename sync-depth option to clone-depth&q

[gentoo-portage-dev] [PATCH] GitSync: fix spurious "sync-depth is deprecated" messages (bug 610708)

2017-02-24 Thread Zac Medico
The CheckGitConfig._check_depth method must not set the sync_depth attribute, or else it will trigger "sync-depth is deprecated" messages. Fixes: b3f6297a791a ("repos.conf: rename sync-depth option to clone-depth") X-Gentoo-Bug: 610708 X-Gentoo-Bug-Url:

Re: [gentoo-portage-dev] [PATCH] grabfile_package: support -* in profile "packages" files (bug 610670)

2017-02-23 Thread Zac Medico
On 02/23/2017 09:03 AM, Joakim Tjernlund wrote: > On Thu, 2017-02-23 at 07:52 -0800, Brian Dolbec wrote: >> On Thu, 23 Feb 2017 11:53:15 + >> Joakim Tjernlund <joakim.tjernl...@infinera.com> wrote: >> >>> On Thu, 2017-02-23 at 02:52 -0800, Zac Medico wro

Re: [gentoo-portage-dev] [PATCH] grabfile_package: support -* in profile "packages" files (bug 610670)

2017-02-23 Thread Zac Medico
On 02/23/2017 07:52 AM, Brian Dolbec wrote: > On Thu, 23 Feb 2017 11:53:15 + > Joakim Tjernlund <joakim.tjernl...@infinera.com> wrote: > >> On Thu, 2017-02-23 at 02:52 -0800, Zac Medico wrote: >>> Support -* in order to make it easier to create profiles for &

[gentoo-portage-dev] [PATCH] grabfile_package: support -* in profile "packages" files (bug 610670)

2017-02-23 Thread Zac Medico
Support -* in order to make it easier to create profiles for minimal systems (especially those built entirely from binary packages). X-Gentoo-Bug: 610670 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=610670 --- pym/portage/util/__init__.py | 9 - 1 file changed, 8

Re: [gentoo-portage-dev] [PATCH] etc-update: fix hang when using_editor is set, bug #544440

2017-02-22 Thread Zac Medico
On 02/22/2017 11:10 AM, Fabian Groffen wrote: > Don't try to use an interactive editor to obtain the difference between > files. Fall back to plain `diff -q` in this case. > --- > bin/etc-update | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git

Re: [gentoo-portage-dev] [PATCH] repos.conf: rename sync-depth option to clone-depth

2017-02-22 Thread Zac Medico
On 02/21/2017 07:38 PM, Brian Dolbec wrote: > hmm, I might be out of sync, but if this isn't merged already, looks > fine. Thanks, merged: https://gitweb.gentoo.org/proj/portage.git/commit/?id=b3f6297a791a748a4bca370283705576568a20c2 -- Thanks, Zac

Re: [gentoo-portage-dev] [PATCH] repoman: use regular expression to detect line continuations

2017-02-22 Thread Zac Medico
On 02/21/2017 07:29 PM, Brian Dolbec wrote: > Code seems fine to me, I trust you ;) Thanks, merged: https://gitweb.gentoo.org/proj/portage.git/commit/?id=3e82d2e09f124f3b77d1b913c945b93341ee4053 -- Thanks, Zac

Re: [gentoo-portage-dev] [PATCH 3/3] repoman: Deprecate confutils.eclass

2017-02-22 Thread Zac Medico
This whole series looks good. -- Thanks, Zac

[gentoo-portage-dev] [PATCH] repoman: use regular expression to detect line continuations

2017-02-21 Thread Zac Medico
Use a regular expression to detect line continuations, instead of the unicode_escape codec, since the unicode_escape codec is not really intended to be used this way. This solves an issue with python3.6, where a DeprecationWarning is triggered by ebuilds containing escape sequences, like this

Re: [gentoo-portage-dev] [PATCH] emerge: sync given repos even if auto-sync is false

2017-02-20 Thread Zac Medico
On 02/20/2017 09:53 AM, Alexandru Elisei wrote: > --- > # > # This will be followed by a series of patches to ignore repos with sync-type > # unset, as per the man page, fail when sync-uri is not specified and an > update > # to the emerge.1 man page to reflect the change in behavior. > # >

Re: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054)

2017-02-19 Thread Zac Medico
On 02/19/2017 01:02 PM, Alexandru Elisei wrote: > if auto_sync_only: > - return self._filter_auto(selected_repos) > - return selected_repos > + selected_repos = self._filter_auto(selected_repos) > + #print("_get_repos(),

Re: [gentoo-portage-dev] [PATCH V2] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054)

2017-02-19 Thread Zac Medico
On 02/19/2017 01:02 PM, Alexandru Elisei wrote: > + valid_repos = [] > + missing_sync_type = [] > + for repo in selected_repos: > + if repo.sync_type is None: > + missing_sync_type.append(repo.name) > +

Re: [gentoo-portage-dev] [PATCH] sync.py: extend the checks in _get_repos() and fail when necessary (bugs 567478, 576272, 601054)

2017-02-19 Thread Zac Medico
On Mon, Feb 13, 2017 at 2:14 AM, Alexandru Elisei wrote: > @@ -204,14 +231,7 @@ class SyncRepos(object): > k = "--" + k.replace("_", "-") > self.emerge_config.opts[k] = v > > -

[gentoo-portage-dev] [PATCH] repos.conf: rename sync-depth option to clone-depth

2017-02-17 Thread Zac Medico
Since sync-depth actually controls clone depth, rename it to clone-depth, and show a warning message when the sync-depth option has been specified: UserWarning: repos.conf: sync-depth is deprecated, use clone-depth instead This makes it feasible to change the meaning of sync-depth in the future

Re: [gentoo-portage-dev] [PATCH] emerge: make emerge --sync print messages from SyncRepos.auto_sync()

2017-02-13 Thread Zac Medico
On 02/04/2017 09:49 AM, Alexandru Elisei wrote: > Emerge will only display messages if --quiet is not set. > > The word 'emaint' has been removed from two messages to avoid confusion. > --- > pym/_emerge/actions.py | 7 +-- > pym/portage/emaint/modules/sync/sync.py | 7

Re: [gentoo-portage-dev] [PATCH] repoman: Check for empty files in filesdir.

2017-02-12 Thread Zac Medico
On 02/12/2017 08:48 AM, Ulrich Mueller wrote: > This checks for files with zero size in filesdir. The QA script at > https://qa-reports.gentoo.org/output/find-binary-files.txt reports a > couple of them which at least in part are blunders. > > Should be harmless enough not to need a discussion

Re: [gentoo-portage-dev] [PATCH 08/18] Add tentative support for EAPI6 eapply_user function

2017-02-09 Thread Zac Medico
On 12/01/2014 01:28 PM, Michał Górny wrote: > Add support for the user patch applying function. > --- > bin/eapi.sh | 4 > bin/phase-helpers.sh | 22 ++ > 2 files changed, 26 insertions(+) > > diff --git a/bin/eapi.sh b/bin/eapi.sh > index 8bb..6e78750

Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

2017-02-01 Thread Zac Medico
On 02/01/2017 01:03 PM, Michał Górny wrote: > W dniu 01.02.2017, śro o godzinie 09∶06 -0800, użytkownik Zac Medico > napisał: >> The native-extensions USE flag will enable building of the >> libc bindings. This is not enabled by default because it does >> not support cr

Re: [gentoo-portage-dev] [PATCH] sys-apps/portage: add native-extensions USE flag (bug 571444)

2017-02-01 Thread Zac Medico
On 02/01/2017 09:57 AM, Brian Dolbec wrote: > On Wed, 1 Feb 2017 09:06:37 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> The native-extensions USE flag will enable building of the >> libc bindings. This is not enabled by default because it does >> not s

Re: [gentoo-portage-dev] [PATCH] sync.py: set returncode when task failed in SyncScheduler._task_exit()

2017-01-26 Thread Zac Medico
On 01/26/2017 11:00 AM, Alexandru Elisei wrote: > If task.returncode is not os.EX_OK then returncode isn't defined when > trying to append the (repo, returncode) tuple to self.retvals. This will > raise an UnboundLocalError exception. > > This reverts the changes to the function made by commit

Re: [gentoo-portage-dev] [PATCH] emerge: fix error handling for clean_logs

2017-01-25 Thread Zac Medico
On 01/25/2017 07:16 PM, Mike Gilbert wrote: > Commit f143e58dd changed the return value of CleanLogs.clean() to a > tuple (returncode, messages). > > X-Gentoo-Bug: 607236 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/607236 > --- > pym/_emerge/post_emerge.py | 6 +++--- > 1 file changed, 3

[gentoo-portage-dev] [PATCH] spawn: instantiate userpriv_groups before fork (bug 582098)

2017-01-25 Thread Zac Medico
Make spawn force instantiation of portage.data.userpriv_groups in the main process, in order to avoid redundant instantiation in child processes. This mitigates the impact of "Bad file descriptor" errors reported in bug 582098, by avoiding redundant instantiation of userpriv_groups in child

Re: [gentoo-portage-dev] Re: [PATCH V2] emerge: check correctly for --sync success (bug 606588)

2017-01-22 Thread Zac Medico
On 01/20/2017 11:23 AM, Alexandru Elisei wrote: > The class SyncRepos will keep a list of (repo, returncode) tuples. > If sync is unsuccessful emerge will use this list to return the first > failed repository return code. I've pushed a minimal fix:

Re: [gentoo-portage-dev] [PATCH v2] repoman: always add a newline if the message body is one line

2017-01-14 Thread Zac Medico
On 01/14/2017 11:00 AM, Mike Gilbert wrote: > The second line in a git commit message is supposed to be blank. > Also, use a regex to more exactly match a Field: value line. > > Before: > dev-libs/libfoo: fix another bug > Package-Manager: Portage-2.3.3, Repoman-2.3.1 > > After: >

Re: [gentoo-portage-dev] [PATCH] repoman: always add a newline if the message body is one line

2017-01-14 Thread Zac Medico
On 01/14/2017 08:58 AM, Mike Gilbert wrote: > The second line in a git commit message is supposed to be blank. > > Before: > dev-libs/libfoo: fix another bug > Package-Manager: Portage-2.3.3, Repoman-2.3.1 > > After: > dev-libs/libfoo: fix another bug > > Package-Manager: Portage-2.3.3,

Re: [gentoo-portage-dev] [PATCH] repoman: add HOMEPAGE.missingurischeme check

2017-01-13 Thread Zac Medico
On 01/09/2017 02:07 AM, Wim Muskee wrote: > thx Zac, I would never have figured that out myself > > the updated patch: > > From c703875bebd82271921d7e94b7cd61936b87d32b Mon Sep 17 00:00:00 2001 > From: Wim Muskee > > Date: Sat, 7 Jan 2017 12:02:41

Re: [gentoo-portage-dev] [PATCH] bin/socks5-server.py: convert address from bytes to str (bug 604474)

2017-01-12 Thread Zac Medico
On 01/12/2017 03:10 PM, Brian Dolbec wrote: > On Thu, 12 Jan 2017 09:36:36 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Use the idna codec to decode the destination address that is read >> from the client. This fixes a "TypeError: must be str, not

[gentoo-portage-dev] [PATCH] bin/socks5-server.py: convert address from bytes to str (bug 604474)

2017-01-12 Thread Zac Medico
Use the idna codec to decode the destination address that is read from the client. This fixes a "TypeError: must be str, not bytes" exception raised from getaddrinfo with Python 3.4.5. X-Gentoo-Bug: 604474 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=604474 --- bin/socks5-server.py

Re: [gentoo-portage-dev] [PATCH] repoman: add HOMEPAGE.missingurischeme check

2017-01-08 Thread Zac Medico
On 01/07/2017 05:32 AM, Michael Orlitzky wrote: > On 01/07/2017 06:08 AM, Wim Muskee wrote: >> >> URISCHEME_RE = re.compile(r'^[a-z\-]+://') >> >> ... >> >> URISCHEME_RE.match(ebuild.metadata.get("HOMEPAGE")) is None: >> > > The PMS allows some weird stuff in HOMEPAGE: > >

Re: [gentoo-portage-dev] [PATCH] man/emaint.1: Add sync to synopsis and fix its in sync --auto

2017-01-08 Thread Zac Medico
On 01/07/2017 09:24 AM, Chris Mayo wrote: > Signed-off-by: Chris Mayo > --- > man/emaint.1 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man/emaint.1 b/man/emaint.1 > index 24e4744..4617ef8 100644 > --- a/man/emaint.1 > +++ b/man/emaint.1 > @@

Re: [gentoo-portage-dev] [PATCH] _dep_check_composite_db: select highest in slot conflict (bug 554070)

2017-01-04 Thread Zac Medico
On 01/04/2017 02:28 PM, Brian Dolbec wrote: > On Tue, 3 Jan 2017 17:13:25 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix the _dep_check_composite_db._visible method to select the highest >> version involved in a slot conflict, for

[gentoo-portage-dev] [PATCH] _dep_check_composite_db: select highest in slot conflict (bug 554070)

2017-01-03 Thread Zac Medico
Fix the _dep_check_composite_db._visible method to select the highest version involved in a slot conflict, for consistency with the change in ab07ac68fa1e04ed64e2e0f6c753ff169a32d517. The included unit test fails without this fix. Fixes: ab07ac68fa1e ("depgraph: select highest version involved in

Re: [gentoo-portage-dev] [PATCH v2] portageq: allow disabling regex matching of maintainer emails #604164

2016-12-31 Thread Zac Medico
On 12/30/2016 01:43 PM, Göktürk Yüksek wrote: > When the email address of a maintainer contains unescaped > regex-special characters (such as '+'), the maintainer-email match may > return undesirable results. > > Add a command line option '--no-regex' to use re.escape() with list > comprehension

Re: [gentoo-portage-dev] [PATCH v1] portageq: escape regex-special characters in maintainer emails #604164

2016-12-30 Thread Zac Medico
On 12/30/2016 10:02 AM, Göktürk Yüksek wrote: > When the email address of a maintainer contains regex-special > characters (such as '+'), re.match() returns incorrect results. Use > re.escape() with list comprehension on maintainer emails when > constructing the matcher regex. I've commented on

Re: [gentoo-portage-dev] [PATCH] depgraph: clarify "update has been skipped" message (bug 602854)

2016-12-29 Thread Zac Medico
On 12/28/2016 05:25 PM, Brian Dolbec wrote: > On Wed, 28 Dec 2016 16:01:04 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> When an update has been skipped, clearly display both the selected and >> skipped packages. >> >> X-Gentoo-bug: 602854 >> X-G

[gentoo-portage-dev] [PATCH] depgraph: clarify "update has been skipped" message (bug 602854)

2016-12-28 Thread Zac Medico
When an update has been skipped, clearly display both the selected and skipped packages. X-Gentoo-bug: 602854 X-Gentoo-bug-url: https://bugs.gentoo.org/602854 --- pym/_emerge/depgraph.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pym/_emerge/depgraph.py

Re: [gentoo-portage-dev] [PATCH] binarytree._read_metadata: return empty strings for undefine values (bug 603826)

2016-12-27 Thread Zac Medico
On 12/27/2016 03:39 PM, Brian Dolbec wrote: > On Tue, 27 Dec 2016 13:33:55 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix the binarytree._read_metadata method to return empty strings for >> undefined metadata values, in order to fulfill a contract

Re: [gentoo-portage-dev] [PATCH] LinkageMapELF: compute mulilib category for preserved libs (bug 598080)

2016-12-27 Thread Zac Medico
On 12/27/2016 01:23 PM, Brian Dolbec wrote: > On Mon, 26 Dec 2016 20:37:39 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> When support for parsing ELF headers in order to compute multilib >> category was added in commit f1c1b8a77eebf7713b32e5f9945690f60f4f46de,

[gentoo-portage-dev] [PATCH] binarytree._read_metadata: return empty strings for undefine values (bug 603826)

2016-12-27 Thread Zac Medico
Fix the binarytree._read_metadata method to return empty strings for undefined metadata values, in order to fulfill a contract with the _pkg_str class. This prevents an AttributeError triggered by old binary packages which have undefined repository metadata, as reported in bug 603826.

Re: [gentoo-portage-dev] [PATCH] slot_conflict_handler: report packages that can't be rebuilt (bug 602964)

2016-12-18 Thread Zac Medico
On 12/18/2016 07:44 AM, Brian Dolbec wrote: > On Sun, 18 Dec 2016 05:58:45 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Report packages that need to be rebuilt in order to solve slot >> conflicts, but cannot be rebuilt for some reason. The following

[gentoo-portage-dev] [PATCH] slot_conflict_handler: report packages that can't be rebuilt (bug 602964)

2016-12-18 Thread Zac Medico
Report packages that need to be rebuilt in order to solve slot conflicts, but cannot be rebuilt for some reason. The following reasons will be detected: * matched by --exclude argument * matched by --useoldpkg-atoms argument * ebuild is masked or unavailable Example output: !!! The slot

Re: [gentoo-portage-dev] [PATCH] man: emaint typo fix, #575178

2016-12-14 Thread Zac Medico
On 12/14/2016 11:19 AM, Wim Muskee wrote: > From 74d266404ec157bf97791f308a4858712028d607 Mon Sep 17 00:00:00 2001 > From: Wim Muskee > > Date: Mon, 12 Dec 2016 19:59:08 +0100 > Subject: [PATCH] man: emaint typo fix, #575178 > > --- > man/emaint.1

Re: [gentoo-portage-dev] [PATCH] repoman: Fix versioning system

2016-12-05 Thread Zac Medico
On 12/05/2016 12:32 PM, Brian Dolbec wrote: > On Mon, 5 Dec 2016 11:42:10 -0800 > Brian Dolbec wrote: > >> From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00 2001 >> From: Brian Dolbec >> Date: Mon, 5 Dec 2016 11:27:15 -0800 >> Subject:

Re: [gentoo-portage-dev] [PATCH] depgraph: select highest version involved in slot conflict (bug 554070)

2016-12-04 Thread Zac Medico
On 12/04/2016 07:43 PM, Brian Dolbec wrote: > On Sun, 4 Dec 2016 18:54:37 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix depgraph's package selection logic to choose the highest version >> involved in a slot conflict, for correct operation of

[gentoo-portage-dev] [PATCH] depgraph: select highest version involved in slot conflict (bug 554070)

2016-12-04 Thread Zac Medico
Fix depgraph's package selection logic to choose the highest version involved in a slot conflict, for correct operation of conflict_downgrade logic in the dep_zapdeps function which was introduced in commit a9064d08ef4c92a5d0d1bfb3dc8a01b7850812b0. This will prevent incorrect re-ordering of ||

Re: [gentoo-portage-dev] [PATCH] _emerge/depgraph.py: Autounmask-write fails when there isn't a file in package.*/ bug 598116

2016-12-03 Thread Zac Medico
On 12/03/2016 01:48 PM, Brian Dolbec wrote: > > From c4a61bebca1cfeb0833cefb2c64be6156bdb8e8d Mon Sep 17 00:00:00 2001 > From: "hackers.terabit" > Date: Thu, 27 Oct 2016 03:29:16 + > Subject: [PATCH] _emerge/depgraph.py: Autounmask-write fails when there isn't > a

Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use

2016-12-03 Thread Zac Medico
On 12/03/2016 01:49 PM, Brian Dolbec wrote: > + if self.file_type_lt(self, other): > + return True > + elif self.file_type_lt(other, self): > + return False Patch looks good, except there are 2 missed renames from file_type_lt to

Re: [gentoo-portage-dev] [PATCH] bin/ebuild: fix EBUILD_FORCE_TEST / RESTRICT interaction (bug 601466)

2016-12-03 Thread Zac Medico
On 12/03/2016 07:30 AM, Brian Dolbec wrote: > On Fri, 2 Dec 2016 22:07:39 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Ensure that config adjustments are applied to all relevant >> config instances, in order to prevent inconsistencies like >> the one t

[gentoo-portage-dev] [PATCH] bin/ebuild: fix EBUILD_FORCE_TEST / RESTRICT interaction (bug 601466)

2016-12-02 Thread Zac Medico
Ensure that config adjustments are applied to all relevant config instances, in order to prevent inconsistencies like the one that triggered bug 601466. X-Gentoo-Bug: 601466 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=601466 --- bin/ebuild | 23 --- 1 file

Re: [gentoo-portage-dev] [PATCH] _post_src_install_uid_fix: allow files with portage group permissions (bug 600804)

2016-11-29 Thread Zac Medico
On 11/29/2016 03:26 PM, Brian Dolbec wrote: > On Tue, 29 Nov 2016 12:43:16 -0800 > Zac Medico <zmed...@gentoo.org> wrote: > >> Allow ebuilds to install files with portage group permissions, as >> a means to restrict access to package manager resources. >> >&g

<    5   6   7   8   9   10   11   12   13   14   >