Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Zac Medico
On 11/17/2015 02:20 PM, Michał Górny wrote: > --- > bin/phase-functions.sh | 6 ++ > bin/phase-helpers.sh | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh > index 7bf4d63..abbc602 100644 > --- a/bin/phase-functions.sh > +++

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Ulrich Mueller
> On Tue, 17 Nov 2015, Zac Medico wrote: >> What happens if an ebuild calls eapply_user in src_unpack but not >> in src_prepare? > It will succeed in that case. It should die if it isn't called in src_prepare. > If necessary, we can make eapply_user die if it's called during the > wrong

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Ulrich Mueller
> On Tue, 17 Nov 2015, Michał Górny wrote: > __ebuild_phase src_prepare > + > + # keep path in eapply_user in sync! > + if [[ ! -f ${T}/.portage_user_patches_applied ]]; then > + die "eapply_user (or default) must be called in src_prepare()!" > + fi > + What

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Michał Górny
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Dnia 18 listopada 2015 08:01:06 CET, Ulrich Mueller napisał(a): >> On Tue, 17 Nov 2015, Michał Górny wrote: > >> __ebuild_phase src_prepare >> + >> +# keep path in eapply_user in sync! >> +if [[ ! -f

Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()

2015-11-17 Thread Michał Górny
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Dnia 18 listopada 2015 08:01:06 CET, Ulrich Mueller napisał(a): >> On Tue, 17 Nov 2015, Michał Górny wrote: > >> __ebuild_phase src_prepare >> + >> +# keep path in eapply_user in sync! >> +if [[ ! -f