Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)

2015-12-15 Thread Michał Górny
On Tue, 15 Dec 2015 08:50:10 -0800 Zac Medico wrote: > On 12/15/2015 12:43 AM, Michał Górny wrote: > > On Tue, 15 Dec 2015 00:10:03 -0800 > > Zac Medico wrote: > > > >> Include directory mtimes in the max mtime calculation, in order > >> to account for removals and renames. > > > > Mildly

Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)

2015-12-15 Thread Zac Medico
On 12/15/2015 12:43 AM, Michał Górny wrote: > On Tue, 15 Dec 2015 00:10:03 -0800 > Zac Medico wrote: > >> Include directory mtimes in the max mtime calculation, in order >> to account for removals and renames. > > Mildly irrelevant but I think this reached the point when we want to > make this o

Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)

2015-12-15 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 This is probably fine. - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCgAGBQJWb9hgAAoJENQqWdRUGk8BCwAQAMJ5/Qm4wmIxyCATt5JLUoP7 mY8HK8xyCR4uiU0tJ2A4tesDSy1uK5iiC90q/Q8

Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)

2015-12-15 Thread Michał Górny
On Tue, 15 Dec 2015 00:10:03 -0800 Zac Medico wrote: > Include directory mtimes in the max mtime calculation, in order > to account for removals and renames. Mildly irrelevant but I think this reached the point when we want to make this optional, and off by default. In other words, we want 'repo

[gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)

2015-12-15 Thread Zac Medico
Include directory mtimes in the max mtime calculation, in order to account for removals and renames. Fixes: 6dacd0ed9f6d ("Manifest.write: stable/predictable Manifest mtime for rsync (bug 557962)") X-Gentoo-Bug: 567920 X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=567920 --- pym/port