Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-10 Thread Zac Medico
On 01/10/2018 09:00 AM, Alec Warner wrote: > The code lgtm. Thanks! > Slightly unsure if we need an entirely new test, as opposed to just > generalizing the test cases (like you did the code). But either way is > probably fine. Well, it seems like the only benefit of combining the tests together

Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-10 Thread Alec Warner
The code lgtm. Slightly unsure if we need an entirely new test, as opposed to just generalizing the test cases (like you did the code). But either way is probably fine. -A On Tue, Jan 9, 2018 at 2:55 PM, Zac Medico wrote: > Prefer to install a new package in order to allow upgrade of an > inst

[gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974)

2018-01-09 Thread Zac Medico
Prefer to install a new package in order to allow upgrade of an installed package. This generalizes the code from bug 635540 so that it both allows desirable upgrades and prevents unwanted downgrades. Fixes: 7c58e3737616 ("dep_zapdeps: install new package, avoid downgrade (bug 635540)") Bug: http