Re: [gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

[Zac Medico]

On Mon, May 29, 2017 at 10:15 PM, Brian Dolbec  wrote:

> On Mon, 29 May 2017 15:11:41 -0700
> Zac Medico  wrote:
>
> > On Mon, May 29, 2017 at 3:03 PM, Brian Dolbec 
> > wrote:
> >
> > > On Sun, 28 May 2017 03:07:50 -0700
> > > Zac Medico  wrote:
> > >
> > > > With FEATURES=binpkg-multi-instance, it is normal to have some
> > > > unused binary packages, so don't warn if the selected package
> > > > is the latest version and the most recent build.
> > > >
> > >^^^
> > > is or isn't  the latest version?
> >
> >
> > is the latest version (in this case we "don't warn").
>
>
> OK, WFM


Thanks, pushed:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=0f9bc8659094fe6a100a64e51cc9d51e95c5d659

-- 
Thanks,
Zac

Re: [gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

[Brian Dolbec]

On Mon, 29 May 2017 15:11:41 -0700
Zac Medico  wrote:

> On Mon, May 29, 2017 at 3:03 PM, Brian Dolbec 
> wrote:
> 
> > On Sun, 28 May 2017 03:07:50 -0700
> > Zac Medico  wrote:
> >  
> > > With FEATURES=binpkg-multi-instance, it is normal to have some
> > > unused binary packages, so don't warn if the selected package
> > > is the latest version and the most recent build.
> > >  
> >^^^
> > is or isn't  the latest version?  
> 
> 
> is the latest version (in this case we "don't warn").


OK, WFM

-- 
Brian Dolbec 

Re: [gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

[Brian Dolbec]

On Sun, 28 May 2017 03:07:50 -0700
Zac Medico  wrote:

> With FEATURES=binpkg-multi-instance, it is normal to have some
> unused binary packages, so don't warn if the selected package
> is the latest version and the most recent build.
> 
   ^^^
is or isn't  the latest version?


> X-Gentoo-bug: 619620
> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=619620
> ---
>  pym/_emerge/depgraph.py | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
> index 726835dd4..2dc432431 100644
> --- a/pym/_emerge/depgraph.py
> +++ b/pym/_emerge/depgraph.py
> @@ -876,6 +876,15 @@ class depgraph(object):
>   
> self._dynamic_config.ignored_binaries.pop(pkg)
>   break
>  
> + # NOTE: The Package.__ge__
> implementation accounts for
> + # differences in build_time, so the
> warning about "ignored"
> + # packages will be triggered if both
> packages are the same
> + # version and selected_pkg is not
> the most recent build.
> + if (selected_pkg.type_name ==
> "binary" and
> + selected_pkg >= pkg):
> +
> self._dynamic_config.ignored_binaries.pop(pkg)
> + break
> +
>   if selected_pkg.installed and \
>   selected_pkg.cpv == pkg.cpv
> and \ selected_pkg.build_time == pkg.build_time:



-- 
Brian Dolbec 

[gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

[Zac Medico]

With FEATURES=binpkg-multi-instance, it is normal to have some
unused binary packages, so don't warn if the selected package
is the latest version and the most recent build.

X-Gentoo-bug: 619620
X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=619620
---
 pym/_emerge/depgraph.py | 9 +
 1 file changed, 9 insertions(+)

diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 726835dd4..2dc432431 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -876,6 +876,15 @@ class depgraph(object):

self._dynamic_config.ignored_binaries.pop(pkg)
break
 
+   # NOTE: The Package.__ge__ implementation 
accounts for
+   # differences in build_time, so the warning 
about "ignored"
+   # packages will be triggered if both packages 
are the same
+   # version and selected_pkg is not the most 
recent build.
+   if (selected_pkg.type_name == "binary" and
+   selected_pkg >= pkg):
+   
self._dynamic_config.ignored_binaries.pop(pkg)
+   break
+
if selected_pkg.installed and \
selected_pkg.cpv == pkg.cpv and \
selected_pkg.build_time == 
pkg.build_time:
-- 
2.13.0