Re: [gentoo-portage-dev] [PATCH] phase-helpers.sh: Loop over A rather than SRC_URI in __eapi0_pkg_nofetch.
> On Thu, 23 Mar 2017, Ulrich Mueller wrote: > On Thu, 23 Mar 2017, Zac Medico wrote: >> On Thu, Mar 23, 2017 at 2:55 AM, Ulrich Müller wrote: >>> Looping over SRC_URI also outputs non-filename elements (e.g, use >>> conditionals) which is avoided when looping over A. >>> >>> Gentoo-Bug: 613132 >>> --- >>> bin/phase-helpers.sh | 8 >>> 1 file changed, 4 insertions(+), 4 deletions(-) >> Looks good. > Presumably we should wait for the ack (or rather the usual consensus > timeout) of the corresponding PMS patch: > https://archives.gentoo.org/gentoo-pms/message/6044537cd2cd36bc23307918a9afced9 Pushed. pgpy3h8Z_85CP.pgp Description: PGP signature
Re: [gentoo-portage-dev] [PATCH] phase-helpers.sh: Loop over A rather than SRC_URI in __eapi0_pkg_nofetch.
> On Thu, 23 Mar 2017, Zac Medico wrote: > On Thu, Mar 23, 2017 at 2:55 AM, Ulrich Müller wrote: >> Looping over SRC_URI also outputs non-filename elements (e.g, use >> conditionals) which is avoided when looping over A. >> >> Gentoo-Bug: 613132 >> --- >> bin/phase-helpers.sh | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) > Looks good. Presumably we should wait for the ack (or rather the usual consensus timeout) of the corresponding PMS patch: https://archives.gentoo.org/gentoo-pms/message/6044537cd2cd36bc23307918a9afced9 Ulrich pgp1eMEcTz3O8.pgp Description: PGP signature
Re: [gentoo-portage-dev] [PATCH] phase-helpers.sh: Loop over A rather than SRC_URI in __eapi0_pkg_nofetch.
On Thu, Mar 23, 2017 at 2:55 AM, Ulrich Müller wrote: > Looping over SRC_URI also outputs non-filename elements (e.g, use > conditionals) which is avoided when looping over A. > > Gentoo-Bug: 613132 > --- > bin/phase-helpers.sh | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Looks good. -- Thanks, Zac
[gentoo-portage-dev] [PATCH] phase-helpers.sh: Loop over A rather than SRC_URI in __eapi0_pkg_nofetch.
Looping over SRC_URI also outputs non-filename elements (e.g, use conditionals) which is avoided when looping over A. Gentoo-Bug: 613132 --- bin/phase-helpers.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh index 9e4e6a2f8..e1dcfd5e8 100644 --- a/bin/phase-helpers.sh +++ b/bin/phase-helpers.sh @@ -1,5 +1,5 @@ #!/bin/bash -# Copyright 1999-2013 Gentoo Foundation +# Copyright 1999-2017 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 export DESTTREE=/usr @@ -726,11 +726,11 @@ einstall() { } __eapi0_pkg_nofetch() { - [ -z "${SRC_URI}" ] && return + [[ -z ${A} ]] && return - elog "The following are listed in SRC_URI for ${PN}:" + elog "The following files cannot be fetched for ${PN}:" local x - for x in $(echo ${SRC_URI}); do + for x in ${A}; do elog " ${x}" done } -- 2.12.1 pgp529zGwiQ94.pgp Description: PGP signature