Re: [gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-24 Thread Michał Górny
On czw, 2017-03-16 at 20:56 +0100, Michał Górny wrote: > Use a model of fake FILESDIR path to ensure that invalid accesses to > FILESDIR will result in failures rather than being silently allowed by > Portage. This mostly involves accesses in the global scope and pkg_* > phases, although the

Re: [gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Michał Górny
On czw, 2017-03-16 at 21:29 +0100, Ulrich Mueller wrote: > > > > > > On Thu, 16 Mar 2017, Michał Górny wrote: > > + mysettings["FILESDIR"] = os.path.join(settings["PORTAGE_BUILDDIR"], > > "files") > > I believe that this contradicts current PMS 11.1, which defines > FILESDIR as follows: "The

Re: [gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Ulrich Mueller
> On Thu, 16 Mar 2017, Michał Górny wrote: > + mysettings["FILESDIR"] = os.path.join(settings["PORTAGE_BUILDDIR"], > "files") I believe that this contradicts current PMS 11.1, which defines FILESDIR as follows: "The full path to the package's files directory, used for small support

[gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Michał Górny
Use a model of fake FILESDIR path to ensure that invalid accesses to FILESDIR will result in failures rather than being silently allowed by Portage. This mostly involves accesses in the global scope and pkg_* phases, although the current model does not cover the latter completely (i.e. does not