Re: [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed

[Brian Dolbec]

On Tue,  7 Jul 2015 14:12:33 +0200
Michael Haubenwallner  wrote:

> X-Gentoo-Bug: 554084
> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
> ---
>  bin/phase-helpers.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
> index efd2cfa..b446060 100644
> --- a/bin/phase-helpers.sh
> +++ b/bin/phase-helpers.sh
> @@ -531,8 +531,8 @@ unpack() {
>   done
>   # Do not chmod '.' since it's probably ${WORKDIR} and
> PORTAGE_WORKDIR_MODE # should be preserved.
> - find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
> - ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
> + find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
> + -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
>  }
>  
>  econf() {

Merged, Thanks

-- 
Brian Dolbec 

[gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed

[Michael Haubenwallner]

X-Gentoo-Bug: 554084
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
---
 bin/phase-helpers.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index efd2cfa..b446060 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -531,8 +531,8 @@ unpack() {
done
# Do not chmod '.' since it's probably ${WORKDIR} and 
PORTAGE_WORKDIR_MODE
# should be preserved.
-   find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
-   ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
+   find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
+   -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
 }
 
 econf() {
-- 
2.0.5

[gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed

[Michael Haubenwallner]

X-Gentoo-Bug: 554084
X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
---
 bin/phase-helpers.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
index efd2cfa..bf3ae1f 100644
--- a/bin/phase-helpers.sh
+++ b/bin/phase-helpers.sh
@@ -531,8 +531,8 @@ unpack() {
done
# Do not chmod '.' since it's probably ${WORKDIR} and 
PORTAGE_WORKDIR_MODE
# should be preserved.
-   find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
-   ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
+   find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w -print0 | \
+   ${XARGS} -0 chmod -f a+rX,u+w,g-w,o-w
 }
 
 econf() {
-- 
2.0.5